Re: Review Request 50087: Ambari should have a script to add new repository and service to existing stack

2016-07-19 Thread Jayush Luniya


> On July 19, 2016, 12:05 p.m., Tim Thorpe wrote:
> > I really like the ability to add new repos.  I'm not so certain we need 
> > another way of adding services to an existing stack.
> > 
> > Jayush and I already added new code to allow Ambari to add new stacks, 
> > extensions and custom services - see AMBARI_15663.
> > 
> > https://issues.apache.org/jira/browse/AMBARI-15663
> > 
> > A custom service can be added via extension-definitions or 
> > stack-addon-service-definitions management packs.  
> > 
> > I understand that this mechanism is a simple and quick way to add HAWQ and 
> > PXF.  Unfortunately this script only works for those custom services which 
> > are actually part of Ambari's common-services.  Ideally the ability to add 
> > new repos would be done in a separate script to allow it to be used when 
> > adding extension-definitions or stack-addon-service-definitions management 
> > packs.

Agree with Tim. Management packs should be the release vehicle for stacks and 
custom services.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50087/#review142730
---


On July 18, 2016, 8:51 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50087/
> ---
> 
> (Updated July 18, 2016, 8:51 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Jayush Luniya, Matt, and Tim 
> Thorpe.
> 
> 
> Bugs: AMBARI-17717
> https://issues.apache.org/jira/browse/AMBARI-17717
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari should have a script that users can run to add a custom service and 
> repository to the stack or an existing cluster.
> 
> ```
> Lavs-MacBook-Pro:scripts ljain$ ./add_common_service.py -h
> Usage: add_common_service.py [options]
> 
> Options:
>   -h, --helpshow this help message and exit
>   -u USER, --user=USER  Ambari login username (Required)
>   -p PASSWORD, --password=PASSWORD
> Ambari login password. Providing password through
> command line is not recommended. The script prompts
> for the password.
>   -t STACK, --stack=STACK
> Stack Name and Version to be added (Required).(Eg:
> HDP-2.4 or HDP-2.5)
>   -s SERVICE, --service=SERVICE
> Service Name and Version to be added.(Eg: HAWQ/2.0.0
> or PXF/3.0.0)
>   -r REPOURL, --repourl=REPOURL
> Repository URL which points to the rpm packages
>   -i REPOID, --repoid=REPOID
> Repository ID of the new repository
>   -o OSTYPE, --ostype=OSTYPE
> OS for the new repository (Eg: redhat6)
> ```
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/add_common_service.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50087/diff/
> 
> 
> Testing
> ---
> 
> Tested manually with various combinations
> 
> 
> Thanks,
> 
> Lav Jain
> 
>



Re: Review Request 50087: Ambari should have a script to add new repository and service to existing stack

2016-07-19 Thread Tim Thorpe

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50087/#review142730
---



I really like the ability to add new repos.  I'm not so certain we need another 
way of adding services to an existing stack.

Jayush and I already added new code to allow Ambari to add new stacks, 
extensions and custom services - see AMBARI_15663.

https://issues.apache.org/jira/browse/AMBARI-15663

A custom service can be added via extension-definitions or 
stack-addon-service-definitions management packs.  

I understand that this mechanism is a simple and quick way to add HAWQ and PXF. 
 Unfortunately this script only works for those custom services which are 
actually part of Ambari's common-services.  Ideally the ability to add new 
repos would be done in a separate script to allow it to be used when adding 
extension-definitions or stack-addon-service-definitions management packs.

- Tim Thorpe


On July 18, 2016, 8:51 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50087/
> ---
> 
> (Updated July 18, 2016, 8:51 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Jayush Luniya, Matt, and Tim 
> Thorpe.
> 
> 
> Bugs: AMBARI-17717
> https://issues.apache.org/jira/browse/AMBARI-17717
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari should have a script that users can run to add a custom service and 
> repository to the stack or an existing cluster.
> 
> ```
> Lavs-MacBook-Pro:scripts ljain$ ./add_common_service.py -h
> Usage: add_common_service.py [options]
> 
> Options:
>   -h, --helpshow this help message and exit
>   -u USER, --user=USER  Ambari login username (Required)
>   -p PASSWORD, --password=PASSWORD
> Ambari login password. Providing password through
> command line is not recommended. The script prompts
> for the password.
>   -t STACK, --stack=STACK
> Stack Name and Version to be added (Required).(Eg:
> HDP-2.4 or HDP-2.5)
>   -s SERVICE, --service=SERVICE
> Service Name and Version to be added.(Eg: HAWQ/2.0.0
> or PXF/3.0.0)
>   -r REPOURL, --repourl=REPOURL
> Repository URL which points to the rpm packages
>   -i REPOID, --repoid=REPOID
> Repository ID of the new repository
>   -o OSTYPE, --ostype=OSTYPE
> OS for the new repository (Eg: redhat6)
> ```
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/add_common_service.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50087/diff/
> 
> 
> Testing
> ---
> 
> Tested manually with various combinations
> 
> 
> Thanks,
> 
> Lav Jain
> 
>



Re: Review Request 50087: Ambari should have a script to add new repository and service to existing stack

2016-07-18 Thread Lav Jain

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50087/
---

(Updated July 18, 2016, 8:51 p.m.)


Review request for Ambari, Alexander Denissov, Jayush Luniya, Matt, and Tim 
Thorpe.


Bugs: AMBARI-17717
https://issues.apache.org/jira/browse/AMBARI-17717


Repository: ambari


Description
---

Ambari should have a script that users can run to add a custom service and 
repository to the stack or an existing cluster.

```
Lavs-MacBook-Pro:scripts ljain$ ./add_common_service.py -h
Usage: add_common_service.py [options]

Options:
  -h, --helpshow this help message and exit
  -u USER, --user=USER  Ambari login username (Required)
  -p PASSWORD, --password=PASSWORD
Ambari login password. Providing password through
command line is not recommended. The script prompts
for the password.
  -t STACK, --stack=STACK
Stack Name and Version to be added (Required).(Eg:
HDP-2.4 or HDP-2.5)
  -s SERVICE, --service=SERVICE
Service Name and Version to be added.(Eg: HAWQ/2.0.0
or PXF/3.0.0)
  -r REPOURL, --repourl=REPOURL
Repository URL which points to the rpm packages
  -i REPOID, --repoid=REPOID
Repository ID of the new repository
  -o OSTYPE, --ostype=OSTYPE
OS for the new repository (Eg: redhat6)
```


Diffs (updated)
-

  ambari-server/src/main/resources/scripts/add_common_service.py PRE-CREATION 

Diff: https://reviews.apache.org/r/50087/diff/


Testing
---

Tested manually with various combinations


Thanks,

Lav Jain