Re: Review Request 50476: UI does not allow to delete service is some host components are in INSTALLED_FAILED state

2016-07-27 Thread Jaimin Jetly

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50476/
---

(Updated July 27, 2016, 7:07 p.m.)


Review request for Ambari, Zhe (Joe) Wang, Sumit Mohanty, and Yusaku Sako.


Bugs: AMBARI-17841
https://issues.apache.org/jira/browse/AMBARI-17841


Repository: ambari


Description
---

*STR:*
# Deploy a service ad abort installation in the middle in a way such that some 
of its slave host components remains in INSTALLED_FAILED state but no all
# Try deleting service

*Expected Result:* UI should allow service deletion as API allows it in this 
scenario
*Actual Result:* UI shows a warning popup in green color and does not let user 
delete a service. screenshot attached


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java
 cb84b89 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
 cc13e39 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 9283e38 
  ambari-server/src/main/resources/properties.json f471628 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java
 cbf3044 
  
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java
 22cf302 
  ambari-web/app/controllers/global/update_controller.js e179a2a 
  ambari-web/app/controllers/main/service/item.js ce0b240 
  ambari-web/app/mappers/components_state_mapper.js 3ad8e49 
  ambari-web/app/models/client_component.js 3902227 

Diff: https://reviews.apache.org/r/50476/diff/


Testing (updated)
---

Tested the patch on deployed cluster.
Verified that ambari-web unit tests passes with the patch

  29224 tests complete (35 seconds)
  154 tests pending

Jenkins QA Job is stuck. So ran ambari-server unit tests and verified that the 
patch does not break any unit tests


Thanks,

Jaimin Jetly



Re: Review Request 50476: UI does not allow to delete service is some host components are in INSTALLED_FAILED state

2016-07-26 Thread Sumit Mohanty

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50476/#review143648
---


Ship it!




Ship It!

- Sumit Mohanty


On July 27, 2016, 12:32 a.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50476/
> ---
> 
> (Updated July 27, 2016, 12:32 a.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17841
> https://issues.apache.org/jira/browse/AMBARI-17841
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *STR:*
> # Deploy a service ad abort installation in the middle in a way such that 
> some of its slave host components remains in INSTALLED_FAILED state but no all
> # Try deleting service
> 
> *Expected Result:* UI should allow service deletion as API allows it in this 
> scenario
> *Actual Result:* UI shows a warning popup in green color and does not let 
> user delete a service. screenshot attached
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java
>  cb84b89 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  cc13e39 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
>  9283e38 
>   ambari-server/src/main/resources/properties.json f471628 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java
>  cbf3044 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java
>  22cf302 
>   ambari-web/app/controllers/global/update_controller.js e179a2a 
>   ambari-web/app/controllers/main/service/item.js ce0b240 
>   ambari-web/app/mappers/components_state_mapper.js 3ad8e49 
>   ambari-web/app/models/client_component.js 3902227 
> 
> Diff: https://reviews.apache.org/r/50476/diff/
> 
> 
> Testing
> ---
> 
> Tested the patch on deployed cluster.
> Verified that ambari-web unit tests passes with the patch
> 
>   29224 tests complete (35 seconds)
>   154 tests pending
> 
> Jenkins QA Job in progress on Jira...
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>