Re: Review Request 50505: Coverity Scan Security Vulnerability - Resource Leak defects
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50505/#review143936
---
Ship it!
This looks good to me; however I might add a comment to the empty catch
blocking indicating the empty block was on purpose...
For example:
```
...
} catch (IOException e) {
// Ignore this exception
}
```
- Robert Levas
On July 27, 2016, 10:52 a.m., Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50505/
> ---
>
> (Updated July 27, 2016, 10:52 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Robert Levas, and
> Sumit Mohanty.
>
>
> Bugs: AMBARI-17922
> https://issues.apache.org/jira/browse/AMBARI-17922
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Fix "Resource Leak" issues that were found by coverity scan.
>
>
> Diffs
> -
>
>
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
> 8697f54
>
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java
> 9881b55
>
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputFile.java
> b4d2bbb
>
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
> 735a83a
>
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditMgr.java
> 3dd8146
>
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/FileUtil.java
> ab52b06
>
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/PropertiesUtil.java
> f32152d
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/AggregatorUtils.java
> 9e41c87
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
> 3035de9
>
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewDirectoryWatcher.java
> c3d443a
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java
> 83a3761
>
> Diff: https://reviews.apache.org/r/50505/diff/
>
>
> Testing
> ---
>
> In progress
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 50505: Coverity Scan Security Vulnerability - Resource Leak defects
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50505/#review143934 --- Ship it! Ship It! - Dmytro Sen On Июль 27, 2016, 2:52 п.п., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50505/ > --- > > (Updated Июль 27, 2016, 2:52 п.п.) > > > Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Robert Levas, and > Sumit Mohanty. > > > Bugs: AMBARI-17922 > https://issues.apache.org/jira/browse/AMBARI-17922 > > > Repository: ambari > > > Description > --- > > Fix "Resource Leak" issues that were found by coverity scan. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java > 8697f54 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java > 9881b55 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputFile.java > b4d2bbb > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java > 735a83a > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditMgr.java > 3dd8146 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/FileUtil.java > ab52b06 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/PropertiesUtil.java > f32152d > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/AggregatorUtils.java > 9e41c87 > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java > 3035de9 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewDirectoryWatcher.java > c3d443a > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 83a3761 > > Diff: https://reviews.apache.org/r/50505/diff/ > > > Testing > --- > > In progress > > > Thanks, > > Vitalyi Brodetskyi > >
