Re: Review Request 50532: [Preview] Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5
> On July 28, 2016, 12:29 p.m., Nate Cole wrote: > > We are going to hold on this patch. Between this and > > https://reviews.apache.org/r/50508/, we're adding more complexity too late > > in the stage. Instead, please pursue a custom java class that will do this > > work, and we'll do Append/Insert for a later version. > > Jonathan Hurley wrote: > Agreed - In Ambari 2.5, we can discuss a proper design for extending the > capabilities of the ConfigureAction. For now, a server-side custom class that > is idempotent is enough. Aravindan, you can use this review, but use the java class approach. - Nate --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50532/#review143951 --- On July 27, 2016, 5:21 p.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50532/ > --- > > (Updated July 27, 2016, 5:21 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan > Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle. > > > Repository: ambari > > > Description > --- > > Added support for "Appending" a value to a config through Upgrade, for > tackling the following config change. > > > In hive-log4j content, the following needs to be added. > > # Silence HadoopMetrics2Reporter INFO logs > log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop=WARN,DRFA > > > This specific config change is valid for only HDP-2.5 . Hence the task has > been added for HDP 2.3, 2.4 upgrade packs. > > A similar problem is being discussed in https://reviews.apache.org/r/50508. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java > f7de8a9 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java > 54431eb > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java > 343c484 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml > c49e18e > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml > 133db26 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml > ff5d4d9 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml > 473d8a0 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml > d648638 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml > e67aebb > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java > be0aeef > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 55cb23b > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml > 44f9e02 > > Diff: https://reviews.apache.org/r/50532/diff/ > > > Testing > --- > > Added unit tests. > > Manual Testing pending. > > > Thanks, > > Aravindan Vijayan > >
Re: Review Request 50532: [Preview] Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5
> On July 28, 2016, 12:29 p.m., Nate Cole wrote: > > We are going to hold on this patch. Between this and > > https://reviews.apache.org/r/50508/, we're adding more complexity too late > > in the stage. Instead, please pursue a custom java class that will do this > > work, and we'll do Append/Insert for a later version. Agreed - In Ambari 2.5, we can discuss a proper design for extending the capabilities of the ConfigureAction. For now, a server-side custom class that is idempotent is enough. - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50532/#review143951 --- On July 27, 2016, 5:21 p.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50532/ > --- > > (Updated July 27, 2016, 5:21 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan > Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle. > > > Repository: ambari > > > Description > --- > > Added support for "Appending" a value to a config through Upgrade, for > tackling the following config change. > > > In hive-log4j content, the following needs to be added. > > # Silence HadoopMetrics2Reporter INFO logs > log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop=WARN,DRFA > > > This specific config change is valid for only HDP-2.5 . Hence the task has > been added for HDP 2.3, 2.4 upgrade packs. > > A similar problem is being discussed in https://reviews.apache.org/r/50508. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java > f7de8a9 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java > 54431eb > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java > 343c484 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml > c49e18e > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml > 133db26 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml > ff5d4d9 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml > 473d8a0 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml > d648638 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml > e67aebb > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java > be0aeef > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 55cb23b > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml > 44f9e02 > > Diff: https://reviews.apache.org/r/50532/diff/ > > > Testing > --- > > Added unit tests. > > Manual Testing pending. > > > Thanks, > > Aravindan Vijayan > >
Re: Review Request 50532: [Preview] Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50532/#review143951 --- We are going to hold on this patch. Between this and https://reviews.apache.org/r/50508/, we're adding more complexity too late in the stage. Instead, please pursue a custom java class that will do this work, and we'll do Append/Insert for a later version. - Nate Cole On July 27, 2016, 5:21 p.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50532/ > --- > > (Updated July 27, 2016, 5:21 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan > Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle. > > > Repository: ambari > > > Description > --- > > Added support for "Appending" a value to a config through Upgrade, for > tackling the following config change. > > > In hive-log4j content, the following needs to be added. > > # Silence HadoopMetrics2Reporter INFO logs > log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop=WARN,DRFA > > > This specific config change is valid for only HDP-2.5 . Hence the task has > been added for HDP 2.3, 2.4 upgrade packs. > > A similar problem is being discussed in https://reviews.apache.org/r/50508. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java > f7de8a9 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java > 54431eb > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java > 343c484 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml > c49e18e > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml > 133db26 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml > ff5d4d9 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml > 473d8a0 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml > d648638 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml > e67aebb > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java > be0aeef > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 55cb23b > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml > 44f9e02 > > Diff: https://reviews.apache.org/r/50532/diff/ > > > Testing > --- > > Added unit tests. > > Manual Testing pending. > > > Thanks, > > Aravindan Vijayan > >