Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-17 Thread Venkat Ranganathan 


> On Aug. 2, 2016, 1:58 a.m., Vitalyi Brodetskyi wrote:
> > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py,
> >  lines 200-217
> > 
> >
> > I don't see here any condition, is it default db for falcon and user 
> > always should registrate/use jdbc for it?
> 
> Vitalyi Brodetskyi wrote:
> And one more, as i remember we set some special permissions for jdbc 
> which was downloaded because later you could have troubles with customized 
> users/permissions/non root user.
> 
> Venkat Ranganathan wrote:
> Yes.  This is only one and it is really not a JDBC driver.  We just use 
> the download mechanism
> 
> Vitalyi Brodetskyi wrote:
> Ok, but anyway i think it will be good to set correct permissions to 
> prevent related issues.

Will create a new JIRA to fix this.   Thanks


- Venkat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/#review144468
---


On Aug. 1, 2016, 2:21 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50595/
> ---
> 
> (Updated Aug. 1, 2016, 2:21 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17955
> https://issues.apache.org/jira/browse/AMBARI-17955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled the registration of optionally downloaded berkeley db jar file.   
> Introduce Berekley DB as a jdbc-db (even though it is actually not.   
> Download je-5.0.73.jar if not already present and inform users on how to 
> register
> 
> also, fixed Atlas integration changes with classname and packagename
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 
> d09bd77 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  dd1cda0 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
>   ambari-server/src/test/python/TestAmbariServer.py 279a172 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 2dd0da9 
> 
> Diff: https://reviews.apache.org/r/50595/diff/
> 
> 
> Testing
> ---
> 
> Tested downloading of the jar file by registering with ambari server
> Tested Falcon/Atlas component names
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-17 Thread Venkat Ranganathan 


> On Aug. 2, 2016, 2:01 a.m., Vitalyi Brodetskyi wrote:
> > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py,
> >  line 174
> > 
> >
> > I don't think it's a good idea to use hard-coded names. Please take a 
> > look how it was done for Hive/Oozie.

This will be the only version that we can support


- Venkat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/#review144469
---


On Aug. 1, 2016, 2:21 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50595/
> ---
> 
> (Updated Aug. 1, 2016, 2:21 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17955
> https://issues.apache.org/jira/browse/AMBARI-17955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled the registration of optionally downloaded berkeley db jar file.   
> Introduce Berekley DB as a jdbc-db (even though it is actually not.   
> Download je-5.0.73.jar if not already present and inform users on how to 
> register
> 
> also, fixed Atlas integration changes with classname and packagename
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 
> d09bd77 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  dd1cda0 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
>   ambari-server/src/test/python/TestAmbariServer.py 279a172 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 2dd0da9 
> 
> Diff: https://reviews.apache.org/r/50595/diff/
> 
> 
> Testing
> ---
> 
> Tested downloading of the jar file by registering with ambari server
> Tested Falcon/Atlas component names
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-03 Thread Vitalyi Brodetskyi 


> On Сер. 2, 2016, 8:58 до полудня, Vitalyi Brodetskyi wrote:
> > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py,
> >  lines 200-217
> > 
> >
> > I don't see here any condition, is it default db for falcon and user 
> > always should registrate/use jdbc for it?
> 
> Vitalyi Brodetskyi wrote:
> And one more, as i remember we set some special permissions for jdbc 
> which was downloaded because later you could have troubles with customized 
> users/permissions/non root user.
> 
> Venkat Ranganathan wrote:
> Yes.  This is only one and it is really not a JDBC driver.  We just use 
> the download mechanism

Ok, but anyway i think it will be good to set correct permissions to prevent 
related issues.


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/#review144468
---


On Сер. 1, 2016, 9:21 після полудня, Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50595/
> ---
> 
> (Updated Сер. 1, 2016, 9:21 після полудня)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17955
> https://issues.apache.org/jira/browse/AMBARI-17955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled the registration of optionally downloaded berkeley db jar file.   
> Introduce Berekley DB as a jdbc-db (even though it is actually not.   
> Download je-5.0.73.jar if not already present and inform users on how to 
> register
> 
> also, fixed Atlas integration changes with classname and packagename
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 
> d09bd77 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  dd1cda0 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
>   ambari-server/src/test/python/TestAmbariServer.py 279a172 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 2dd0da9 
> 
> Diff: https://reviews.apache.org/r/50595/diff/
> 
> 
> Testing
> ---
> 
> Tested downloading of the jar file by registering with ambari server
> Tested Falcon/Atlas component names
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-02 Thread Venkat Ranganathan 


> On Aug. 2, 2016, 1:58 a.m., Vitalyi Brodetskyi wrote:
> > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py,
> >  lines 200-217
> > 
> >
> > I don't see here any condition, is it default db for falcon and user 
> > always should registrate/use jdbc for it?
> 
> Vitalyi Brodetskyi wrote:
> And one more, as i remember we set some special permissions for jdbc 
> which was downloaded because later you could have troubles with customized 
> users/permissions/non root user.

Yes.  This is only one and it is really not a JDBC driver.  We just use the 
download mechanism


- Venkat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/#review144468
---


On Aug. 1, 2016, 2:21 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50595/
> ---
> 
> (Updated Aug. 1, 2016, 2:21 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17955
> https://issues.apache.org/jira/browse/AMBARI-17955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled the registration of optionally downloaded berkeley db jar file.   
> Introduce Berekley DB as a jdbc-db (even though it is actually not.   
> Download je-5.0.73.jar if not already present and inform users on how to 
> register
> 
> also, fixed Atlas integration changes with classname and packagename
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 
> d09bd77 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  dd1cda0 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
>   ambari-server/src/test/python/TestAmbariServer.py 279a172 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 2dd0da9 
> 
> Diff: https://reviews.apache.org/r/50595/diff/
> 
> 
> Testing
> ---
> 
> Tested downloading of the jar file by registering with ambari server
> Tested Falcon/Atlas component names
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-02 Thread Vitalyi Brodetskyi 


> On Сер. 2, 2016, 8:58 до полудня, Vitalyi Brodetskyi wrote:
> > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py,
> >  lines 200-217
> > 
> >
> > I don't see here any condition, is it default db for falcon and user 
> > always should registrate/use jdbc for it?

And one more, as i remember we set some special permissions for jdbc which was 
downloaded because later you could have troubles with customized 
users/permissions/non root user.


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/#review144468
---


On Сер. 1, 2016, 9:21 після полудня, Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50595/
> ---
> 
> (Updated Сер. 1, 2016, 9:21 після полудня)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17955
> https://issues.apache.org/jira/browse/AMBARI-17955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled the registration of optionally downloaded berkeley db jar file.   
> Introduce Berekley DB as a jdbc-db (even though it is actually not.   
> Download je-5.0.73.jar if not already present and inform users on how to 
> register
> 
> also, fixed Atlas integration changes with classname and packagename
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 
> d09bd77 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  dd1cda0 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
>   ambari-server/src/test/python/TestAmbariServer.py 279a172 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 2dd0da9 
> 
> Diff: https://reviews.apache.org/r/50595/diff/
> 
> 
> Testing
> ---
> 
> Tested downloading of the jar file by registering with ambari server
> Tested Falcon/Atlas component names
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-02 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/#review144469
---




ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 (line 174)


I don't think it's a good idea to use hard-coded names. Please take a look 
how it was done for Hive/Oozie.


- Vitalyi Brodetskyi


On Сер. 1, 2016, 9:21 після полудня, Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50595/
> ---
> 
> (Updated Сер. 1, 2016, 9:21 після полудня)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17955
> https://issues.apache.org/jira/browse/AMBARI-17955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled the registration of optionally downloaded berkeley db jar file.   
> Introduce Berekley DB as a jdbc-db (even though it is actually not.   
> Download je-5.0.73.jar if not already present and inform users on how to 
> register
> 
> also, fixed Atlas integration changes with classname and packagename
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 
> d09bd77 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  dd1cda0 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
>   ambari-server/src/test/python/TestAmbariServer.py 279a172 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 2dd0da9 
> 
> Diff: https://reviews.apache.org/r/50595/diff/
> 
> 
> Testing
> ---
> 
> Tested downloading of the jar file by registering with ambari server
> Tested Falcon/Atlas component names
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-02 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/#review144468
---




ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 (lines 200 - 217)


I don't see here any condition, is it default db for falcon and user always 
should registrate/use jdbc for it?


- Vitalyi Brodetskyi


On Сер. 1, 2016, 9:21 після полудня, Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50595/
> ---
> 
> (Updated Сер. 1, 2016, 9:21 після полудня)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17955
> https://issues.apache.org/jira/browse/AMBARI-17955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled the registration of optionally downloaded berkeley db jar file.   
> Introduce Berekley DB as a jdbc-db (even though it is actually not.   
> Download je-5.0.73.jar if not already present and inform users on how to 
> register
> 
> also, fixed Atlas integration changes with classname and packagename
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 
> d09bd77 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  dd1cda0 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
>   ambari-server/src/test/python/TestAmbariServer.py 279a172 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 2dd0da9 
> 
> Diff: https://reviews.apache.org/r/50595/diff/
> 
> 
> Testing
> ---
> 
> Tested downloading of the jar file by registering with ambari server
> Tested Falcon/Atlas component names
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-01 Thread Venkat Ranganathan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/
---

(Updated Aug. 1, 2016, 2:21 p.m.)


Review request for Ambari and Alejandro Fernandez.


Changes
---

Fixed another UT failure in ambariserver


Bugs: AMBARI-17955
https://issues.apache.org/jira/browse/AMBARI-17955


Repository: ambari


Description
---

Enabled the registration of optionally downloaded berkeley db jar file.   
Introduce Berekley DB as a jdbc-db (even though it is actually not.   Download 
je-5.0.73.jar if not already present and inform users on how to register

also, fixed Atlas integration changes with classname and packagename


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
  ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py d09bd77 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 dd1cda0 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 ebe3634 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
8d5cdc9 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
f8ba3e9 
  ambari-server/src/test/python/TestAmbariServer.py 279a172 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 2dd0da9 

Diff: https://reviews.apache.org/r/50595/diff/


Testing
---

Tested downloading of the jar file by registering with ambari server
Tested Falcon/Atlas component names


Thanks,

Venkat Ranganathan

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-01 Thread Venkat Ranganathan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/
---

(Updated Aug. 1, 2016, 11:38 a.m.)


Review request for Ambari and Alejandro Fernandez.


Changes
---

Fixed a trailing blank


Bugs: AMBARI-17955
https://issues.apache.org/jira/browse/AMBARI-17955


Repository: ambari


Description
---

Enabled the registration of optionally downloaded berkeley db jar file.   
Introduce Berekley DB as a jdbc-db (even though it is actually not.   Download 
je-5.0.73.jar if not already present and inform users on how to register

also, fixed Atlas integration changes with classname and packagename


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
  ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py d09bd77 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 dd1cda0 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 ebe3634 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
8d5cdc9 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
f8ba3e9 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 2dd0da9 

Diff: https://reviews.apache.org/r/50595/diff/


Testing
---

Tested downloading of the jar file by registering with ambari server
Tested Falcon/Atlas component names


Thanks,

Venkat Ranganathan

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-01 Thread Venkat Ranganathan 


> On July 31, 2016, 4:34 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py, line 
> > 1131
> > 
> >
> > We should remove the version from the jar name

This is the only version supported - like what we have for sqljdbc4


- Venkat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/#review144291
---


On Aug. 1, 2016, 10:38 a.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50595/
> ---
> 
> (Updated Aug. 1, 2016, 10:38 a.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17955
> https://issues.apache.org/jira/browse/AMBARI-17955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled the registration of optionally downloaded berkeley db jar file.   
> Introduce Berekley DB as a jdbc-db (even though it is actually not.   
> Download je-5.0.73.jar if not already present and inform users on how to 
> register
> 
> also, fixed Atlas integration changes with classname and packagename
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 
> d09bd77 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  dd1cda0 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
> 
> Diff: https://reviews.apache.org/r/50595/diff/
> 
> 
> Testing
> ---
> 
> Tested downloading of the jar file by registering with ambari server
> Tested Falcon/Atlas component names
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-01 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/#review144358
---




ambari-server/src/main/python/ambari_server/dbConfiguration.py (line 46)


Unit tests are failing, this is a dictionary so it needs the key and value.


- Alejandro Fernandez


On Aug. 1, 2016, 5:38 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50595/
> ---
> 
> (Updated Aug. 1, 2016, 5:38 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17955
> https://issues.apache.org/jira/browse/AMBARI-17955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled the registration of optionally downloaded berkeley db jar file.   
> Introduce Berekley DB as a jdbc-db (even though it is actually not.   
> Download je-5.0.73.jar if not already present and inform users on how to 
> register
> 
> also, fixed Atlas integration changes with classname and packagename
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 
> d09bd77 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  dd1cda0 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
> 
> Diff: https://reviews.apache.org/r/50595/diff/
> 
> 
> Testing
> ---
> 
> Tested downloading of the jar file by registering with ambari server
> Tested Falcon/Atlas component names
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-01 Thread Venkat Ranganathan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/
---

(Updated Aug. 1, 2016, 10:38 a.m.)


Review request for Ambari and Alejandro Fernandez.


Changes
---

Fixed review comments


Bugs: AMBARI-17955
https://issues.apache.org/jira/browse/AMBARI-17955


Repository: ambari


Description
---

Enabled the registration of optionally downloaded berkeley db jar file.   
Introduce Berekley DB as a jdbc-db (even though it is actually not.   Download 
je-5.0.73.jar if not already present and inform users on how to register

also, fixed Atlas integration changes with classname and packagename


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
  ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py d09bd77 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 dd1cda0 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 ebe3634 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
8d5cdc9 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
f8ba3e9 

Diff: https://reviews.apache.org/r/50595/diff/


Testing
---

Tested downloading of the jar file by registering with ambari server
Tested Falcon/Atlas component names


Thanks,

Venkat Ranganathan

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-31 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/#review144291
---




ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py (line 1131)


We should remove the version from the jar name



ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 
742)


it's just hasattr(self, "atlasFalconHookClassName"), no need to prepend 
"self."


- Alejandro Fernandez


On July 29, 2016, 8:14 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50595/
> ---
> 
> (Updated July 29, 2016, 8:14 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17955
> https://issues.apache.org/jira/browse/AMBARI-17955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled the registration of optionally downloaded berkeley db jar file.   
> Introduce Berekley DB as a jdbc-db (even though it is actually not.   
> Download je-5.0.73.jar if not already present and inform users on how to 
> register
> 
> also, fixed Atlas integration changes with classname and packagename
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 
> d09bd77 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  dd1cda0 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
> 
> Diff: https://reviews.apache.org/r/50595/diff/
> 
> 
> Testing
> ---
> 
> Tested downloading of the jar file by registering with ambari server
> Tested Falcon/Atlas component names
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-29 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/#review144210
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 29, 2016, 8:14 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50595/
> ---
> 
> (Updated July 29, 2016, 8:14 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17955
> https://issues.apache.org/jira/browse/AMBARI-17955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled the registration of optionally downloaded berkeley db jar file.   
> Introduce Berekley DB as a jdbc-db (even though it is actually not.   
> Download je-5.0.73.jar if not already present and inform users on how to 
> register
> 
> also, fixed Atlas integration changes with classname and packagename
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 
> d09bd77 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  dd1cda0 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
> 
> Diff: https://reviews.apache.org/r/50595/diff/
> 
> 
> Testing
> ---
> 
> Tested downloading of the jar file by registering with ambari server
> Tested Falcon/Atlas component names
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-29 Thread Venkat Ranganathan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/
---

(Updated July 29, 2016, 1:14 p.m.)


Review request for Ambari and Alejandro Fernandez.


Changes
---

Fixed tailing space and fixed HBase name


Bugs: AMBARI-17955
https://issues.apache.org/jira/browse/AMBARI-17955


Repository: ambari


Description
---

Enabled the registration of optionally downloaded berkeley db jar file.   
Introduce Berekley DB as a jdbc-db (even though it is actually not.   Download 
je-5.0.73.jar if not already present and inform users on how to register

also, fixed Atlas integration changes with classname and packagename


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
  ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py d09bd77 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 dd1cda0 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 ebe3634 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
8d5cdc9 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
f8ba3e9 

Diff: https://reviews.apache.org/r/50595/diff/


Testing
---

Tested downloading of the jar file by registering with ambari server
Tested Falcon/Atlas component names


Thanks,

Venkat Ranganathan

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-29 Thread Venkat Ranganathan 


> On July 29, 2016, 10:54 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py, line 
> > 1132
> > 
> >
> > What happens if the version changes?

The version cannot change as that is the only version we can support - but I 
don't think this symlink is even needed - so can drop it


> On July 29, 2016, 10:54 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py, line 
> > 1143
> > 
> >
> > Why is there a version number in this jar name?

Will remove 5.0* but the only version we support is that.


> On July 29, 2016, 10:54 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py,
> >  line 203
> > 
> >
> > If there are any exceptions, please log it.

Since we log exceptions in DonwloadSource did not do it.   But it does not hurt 
to add it here also.  will add


> On July 29, 2016, 10:54 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py,
> >  line 211
> > 
> >
> > Typo.

will fix.  thanks


- Venkat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/#review144139
---


On July 29, 2016, 11:56 a.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50595/
> ---
> 
> (Updated July 29, 2016, 11:56 a.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17955
> https://issues.apache.org/jira/browse/AMBARI-17955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled the registration of optionally downloaded berkeley db jar file.   
> Introduce Berekley DB as a jdbc-db (even though it is actually not.   
> Download je-5.0.73.jar if not already present and inform users on how to 
> register
> 
> also, fixed Atlas integration changes with classname and packagename
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 
> d09bd77 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  dd1cda0 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
> 
> Diff: https://reviews.apache.org/r/50595/diff/
> 
> 
> Testing
> ---
> 
> Tested downloading of the jar file by registering with ambari server
> Tested Falcon/Atlas component names
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-29 Thread Venkat Ranganathan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/
---

(Updated July 29, 2016, 11:56 a.m.)


Review request for Ambari and Alejandro Fernandez.


Changes
---

Addressed review comments


Bugs: AMBARI-17955
https://issues.apache.org/jira/browse/AMBARI-17955


Repository: ambari


Description
---

Enabled the registration of optionally downloaded berkeley db jar file.   
Introduce Berekley DB as a jdbc-db (even though it is actually not.   Download 
je-5.0.73.jar if not already present and inform users on how to register

also, fixed Atlas integration changes with classname and packagename


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
  ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py d09bd77 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 dd1cda0 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 ebe3634 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
8d5cdc9 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
f8ba3e9 

Diff: https://reviews.apache.org/r/50595/diff/


Testing
---

Tested downloading of the jar file by registering with ambari server
Tested Falcon/Atlas component names


Thanks,

Venkat Ranganathan

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-29 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/#review144139
---




ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py (line 1132)


What happens if the version changes?



ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py (line 1143)


Why is there a version number in this jar name?



ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 (line 203)


If there are any exceptions, please log it.



ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 (line 211)


Typo.


- Alejandro Fernandez


On July 29, 2016, 5:51 a.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50595/
> ---
> 
> (Updated July 29, 2016, 5:51 a.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17955
> https://issues.apache.org/jira/browse/AMBARI-17955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled the registration of optionally downloaded berkeley db jar file.   
> Introduce Berekley DB as a jdbc-db (even though it is actually not.   
> Download je-5.0.73.jar if not already present and inform users on how to 
> register
> 
> also, fixed Atlas integration changes with classname and packagename
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 
> d09bd77 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  dd1cda0 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
> 
> Diff: https://reviews.apache.org/r/50595/diff/
> 
> 
> Testing
> ---
> 
> Tested downloading of the jar file by registering with ambari server
> Tested Falcon/Atlas component names
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>