Re: Review Request 50656: Improvements/fixes for AMBARI_INFRA initial service definition
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50656/#review144371 --- Ship it! Ship It! - Jayush Luniya On Aug. 1, 2016, 12:22 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50656/ > --- > > (Updated Aug. 1, 2016, 12:22 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Robert > Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-17974 > https://issues.apache.org/jira/browse/AMBARI-17974 > > > Repository: ambari > > > Description > --- > > contains a few fixes/imporvements for AMBARI_INFRA service definition: > - role command order fix > - implemented service check (test with kerberos too ... check only one of the > solrs has started or not) > - quick links for infra Solrs (adimin UI) > - configuration fixes (1 display name is missing + adding configuration > properties during ambari upgrade is not needed) > - set the order of AMBARI_INFRA service on 'Select Services' page on the UI > > > Diffs > - > > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-client-log4j.xml > f597492 > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml > dfbaac9 > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-log4j.xml > b192a28 > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-xml.xml > 1d9d8ef > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/metainfo.xml > a1cee49 > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py > 898a35c > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/service_check.py > a5a94fc > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/quicklinks/quicklinks.json > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_INFRA/role_command_order.json > 34654c2 > ambari-web/app/models/stack_service.js 3e2d5b4 > > Diff: https://reviews.apache.org/r/50656/diff/ > > > Testing > --- > > Total run:1034 > Total errors:0 > Total failures:0 > OK > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 1:14.391s > [INFO] Finished at: Mon Aug 01 14:16:11 CEST 2016 > [INFO] Final Memory: 59M/985M > [INFO] --- > > > Thanks, > > Oliver Szabo > >
Re: Review Request 50656: Improvements/fixes for AMBARI_INFRA initial service definition
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50656/#review144335 --- Ship it! Ship It! - Robert Nettleton On Aug. 1, 2016, 12:22 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50656/ > --- > > (Updated Aug. 1, 2016, 12:22 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Robert > Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-17974 > https://issues.apache.org/jira/browse/AMBARI-17974 > > > Repository: ambari > > > Description > --- > > contains a few fixes/imporvements for AMBARI_INFRA service definition: > - role command order fix > - implemented service check (test with kerberos too ... check only one of the > solrs has started or not) > - quick links for infra Solrs (adimin UI) > - configuration fixes (1 display name is missing + adding configuration > properties during ambari upgrade is not needed) > - set the order of AMBARI_INFRA service on 'Select Services' page on the UI > > > Diffs > - > > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-client-log4j.xml > f597492 > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml > dfbaac9 > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-log4j.xml > b192a28 > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-xml.xml > 1d9d8ef > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/metainfo.xml > a1cee49 > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py > 898a35c > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/service_check.py > a5a94fc > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/quicklinks/quicklinks.json > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_INFRA/role_command_order.json > 34654c2 > ambari-web/app/models/stack_service.js 3e2d5b4 > > Diff: https://reviews.apache.org/r/50656/diff/ > > > Testing > --- > > Total run:1034 > Total errors:0 > Total failures:0 > OK > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 1:14.391s > [INFO] Finished at: Mon Aug 01 14:16:11 CEST 2016 > [INFO] Final Memory: 59M/985M > [INFO] --- > > > Thanks, > > Oliver Szabo > >