Re: Review Request 50710: Ambari agent unable to register with server when server response is too big

2016-08-10 Thread Dmytro Grinenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50710/#review145318
---


Ship it!




Ship It!

- Dmytro Grinenko


On Aug. 9, 2016, 2:15 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50710/
> ---
> 
> (Updated Aug. 9, 2016, 2:15 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17991
> https://issues.apache.org/jira/browse/AMBARI-17991
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use Jetty 8 instead of 9 in Ambari 2.4.0
> 
> 
> Diffs
> -
> 
>   ambari-funtest/pom.xml ebc34ec 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml 0a24759 
>   ambari-project/pom.xml c7a0a6a 
>   ambari-server/pom.xml 814973b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/AmbariErrorHandler.java
>  373face 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  bd96868 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationDirectory.java
>  44cdf2b 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/JsonUtils.java 
> 63c88d8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/AmbariErrorHandlerTest.java
>  30c22a2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/DefaultEventCreatorTest.java
>  1e063ec 
> 
> Diff: https://reviews.apache.org/r/50710/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>



Re: Review Request 50710: Ambari agent unable to register with server when server response is too big

2016-08-10 Thread Dmitro Lisnichenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50710/#review145317
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Aug. 9, 2016, 5:15 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50710/
> ---
> 
> (Updated Aug. 9, 2016, 5:15 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17991
> https://issues.apache.org/jira/browse/AMBARI-17991
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use Jetty 8 instead of 9 in Ambari 2.4.0
> 
> 
> Diffs
> -
> 
>   ambari-funtest/pom.xml ebc34ec 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml 0a24759 
>   ambari-project/pom.xml c7a0a6a 
>   ambari-server/pom.xml 814973b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/AmbariErrorHandler.java
>  373face 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  bd96868 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationDirectory.java
>  44cdf2b 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/JsonUtils.java 
> 63c88d8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/AmbariErrorHandlerTest.java
>  30c22a2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/DefaultEventCreatorTest.java
>  1e063ec 
> 
> Diff: https://reviews.apache.org/r/50710/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>



Re: Review Request 50710: Ambari agent unable to register with server when server response is too big

2016-08-09 Thread Dmytro Sen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50710/
---

(Updated Авг. 9, 2016, 2:15 п.п.)


Review request for Ambari, Jaimin Jetly, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-17991
https://issues.apache.org/jira/browse/AMBARI-17991


Repository: ambari


Description
---

Use Jetty 8 instead of 9 in Ambari 2.4.0


Diffs (updated)
-

  ambari-funtest/pom.xml ebc34ec 
  ambari-logsearch/ambari-logsearch-portal/pom.xml 0a24759 
  ambari-project/pom.xml c7a0a6a 
  ambari-server/pom.xml 814973b 
  
ambari-server/src/main/java/org/apache/ambari/server/api/AmbariErrorHandler.java
 373face 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 bd96868 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationDirectory.java
 44cdf2b 
  ambari-server/src/main/java/org/apache/ambari/server/utils/JsonUtils.java 
63c88d8 
  
ambari-server/src/test/java/org/apache/ambari/server/api/AmbariErrorHandlerTest.java
 30c22a2 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/DefaultEventCreatorTest.java
 1e063ec 

Diff: https://reviews.apache.org/r/50710/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen



Re: Review Request 50710: Ambari agent unable to register with server when server response is too big

2016-08-03 Thread Jaimin Jetly

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50710/#review144656
---


Ship it!




Ship It!

- Jaimin Jetly


On Aug. 3, 2016, 4:44 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50710/
> ---
> 
> (Updated Aug. 3, 2016, 4:44 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17991
> https://issues.apache.org/jira/browse/AMBARI-17991
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use Jetty 8 instead of 9 in Ambari 2.4.0
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/security.py 72ae954 
>   ambari-funtest/pom.xml ebc34ec 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml 0a24759 
>   ambari-project/pom.xml c7a0a6a 
>   ambari-server/pom.xml 814973b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/AmbariErrorHandler.java
>  373face 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  bd96868 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationDirectory.java
>  44cdf2b 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/JsonUtils.java 
> 63c88d8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/AmbariErrorHandlerTest.java
>  30c22a2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/DefaultEventCreatorTest.java
>  1e063ec 
> 
> Diff: https://reviews.apache.org/r/50710/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>



Re: Review Request 50710: Ambari agent unable to register with server when server response is too big

2016-08-03 Thread Dmytro Sen


> On Авг. 2, 2016, 3:35 п.п., Sid Wagle wrote:
> > ambari-server/pom.xml, line 1117
> > 
> >
> > Where is this being used ?

I think it's a views dependency. It's been there before replacing jetty 8 with 
jetty 9


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50710/#review144497
---


On Авг. 3, 2016, 4:44 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50710/
> ---
> 
> (Updated Авг. 3, 2016, 4:44 п.п.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17991
> https://issues.apache.org/jira/browse/AMBARI-17991
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use Jetty 8 instead of 9 in Ambari 2.4.0
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/security.py 72ae954 
>   ambari-funtest/pom.xml ebc34ec 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml 0a24759 
>   ambari-project/pom.xml c7a0a6a 
>   ambari-server/pom.xml 814973b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/AmbariErrorHandler.java
>  373face 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  bd96868 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationDirectory.java
>  44cdf2b 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/JsonUtils.java 
> 63c88d8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/AmbariErrorHandlerTest.java
>  30c22a2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/DefaultEventCreatorTest.java
>  1e063ec 
> 
> Diff: https://reviews.apache.org/r/50710/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>



Re: Review Request 50710: Ambari agent unable to register with server when server response is too big

2016-08-03 Thread Dmytro Sen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50710/
---

(Updated Авг. 3, 2016, 4:44 п.п.)


Review request for Ambari, Jaimin Jetly, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-17991
https://issues.apache.org/jira/browse/AMBARI-17991


Repository: ambari


Description
---

Use Jetty 8 instead of 9 in Ambari 2.4.0


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/security.py 72ae954 
  ambari-funtest/pom.xml ebc34ec 
  ambari-logsearch/ambari-logsearch-portal/pom.xml 0a24759 
  ambari-project/pom.xml c7a0a6a 
  ambari-server/pom.xml 814973b 
  
ambari-server/src/main/java/org/apache/ambari/server/api/AmbariErrorHandler.java
 373face 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 bd96868 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationDirectory.java
 44cdf2b 
  ambari-server/src/main/java/org/apache/ambari/server/utils/JsonUtils.java 
63c88d8 
  
ambari-server/src/test/java/org/apache/ambari/server/api/AmbariErrorHandlerTest.java
 30c22a2 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/DefaultEventCreatorTest.java
 1e063ec 

Diff: https://reviews.apache.org/r/50710/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen



Re: Review Request 50710: Ambari agent unable to register with server when server response is too big

2016-08-02 Thread Sid Wagle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50710/#review144497
---


Ship it!




Please add jaimin as a revier as well.


ambari-server/pom.xml (line 1116)


Where is this being used ?


- Sid Wagle


On Aug. 2, 2016, 3:29 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50710/
> ---
> 
> (Updated Aug. 2, 2016, 3:29 p.m.)
> 
> 
> Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17991
> https://issues.apache.org/jira/browse/AMBARI-17991
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use Jetty 8 instead of 9 in Ambari 2.4.0
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/security.py 72ae954 
>   ambari-funtest/pom.xml 28225c2 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml 479420f 
>   ambari-project/pom.xml 617e7aa 
>   ambari-server/pom.xml 930aef0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/AmbariErrorHandler.java
>  373face 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  bd96868 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationDirectory.java
>  44cdf2b 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/JsonUtils.java 
> 63c88d8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/AmbariErrorHandlerTest.java
>  30c22a2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/DefaultEventCreatorTest.java
>  1e063ec 
> 
> Diff: https://reviews.apache.org/r/50710/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>