Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

2016-10-18 Thread Swapan Shridhar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/#review152194
---


Ship it!




Ship It!

- Swapan Shridhar


On Oct. 14, 2016, 11:15 a.m., Nishant Bangarwa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50803/
> ---
> 
> (Updated Oct. 14, 2016, 11:15 a.m.)
> 
> 
> Review request for Ambari, Renjith Kamath and Swapan Shridhar.
> 
> 
> Bugs: Ambari-19781
> https://issues.apache.org/jira/browse/Ambari-19781
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Defines Druid as a new service in HDP 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 1f722dc 
>   ambari-server/src/test/python/stacks/2.6/DRUID/test_druid_historical.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50803/diff/
> 
> 
> Testing
> ---
> 
> Tested it locally by installing ambari and adding the newly added resources. 
> Was able to install druid and start all newly added services.
> 
> 
> Thanks,
> 
> Nishant Bangarwa
> 
>



Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

2016-10-14 Thread Slim Bouguerra

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/#review152683
---


Ship it!




Ship It!

- Slim Bouguerra


On Oct. 14, 2016, 11:15 a.m., Nishant Bangarwa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50803/
> ---
> 
> (Updated Oct. 14, 2016, 11:15 a.m.)
> 
> 
> Review request for Ambari, Renjith Kamath and Swapan Shridhar.
> 
> 
> Bugs: Ambari-19781
> https://issues.apache.org/jira/browse/Ambari-19781
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Defines Druid as a new service in HDP 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 1f722dc 
>   ambari-server/src/test/python/stacks/2.6/DRUID/test_druid_historical.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50803/diff/
> 
> 
> Testing
> ---
> 
> Tested it locally by installing ambari and adding the newly added resources. 
> Was able to install druid and start all newly added services.
> 
> 
> Thanks,
> 
> Nishant Bangarwa
> 
>



Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

2016-10-14 Thread Nishant Bangarwa


> On Oct. 9, 2016, 7:16 p.m., Swapan Shridhar wrote:
> > Further, we need to add to Unit test cases for SA, and install, start, stop 
> > cases for components, before we checkin.

Added Unit tests


- Nishant


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/#review151941
---


On Oct. 14, 2016, 11:15 a.m., Nishant Bangarwa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50803/
> ---
> 
> (Updated Oct. 14, 2016, 11:15 a.m.)
> 
> 
> Review request for Ambari, Renjith Kamath and Swapan Shridhar.
> 
> 
> Bugs: Ambari-19781
> https://issues.apache.org/jira/browse/Ambari-19781
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Defines Druid as a new service in HDP 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 1f722dc 
>   ambari-server/src/test/python/stacks/2.6/DRUID/test_druid_historical.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50803/diff/
> 
> 
> Testing
> ---
> 
> Tested it locally by installing ambari and adding the newly added resources. 
> Was able to install druid and start all newly added services.
> 
> 
> Thanks,
> 
> Nishant Bangarwa
> 
>



Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

2016-10-14 Thread Nishant Bangarwa

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/
---

(Updated Oct. 14, 2016, 11:15 a.m.)


Review request for Ambari, Renjith Kamath and Swapan Shridhar.


Bugs: Ambari-19781
https://issues.apache.org/jira/browse/Ambari-19781


Repository: ambari


Description
---

Defines Druid as a new service in HDP 2.6


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
1f722dc 
  ambari-server/src/test/python/stacks/2.6/DRUID/test_druid_historical.py 
PRE-CREATION 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
PRE-CREATION 
  ambari-server/src/test/python/stacks/2.6/configs/default.json PRE-CREATION 

Diff: https://reviews.apache.org/r/50803/diff/


Testing
---

Tested it locally by installing ambari and adding the newly added resources. 
Was able to install druid and start all newly added services.


Thanks,

Nishant Bangarwa



Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

2016-10-14 Thread Nishant Bangarwa

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/
---

(Updated Oct. 14, 2016, 10:16 a.m.)


Review request for Ambari, Renjith Kamath and Swapan Shridhar.


Bugs: Ambari-19781
https://issues.apache.org/jira/browse/Ambari-19781


Repository: ambari


Description
---

Defines Druid as a new service in HDP 2.6


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
1f722dc 
  ambari-server/src/test/python/stacks/2.6/DRUID/test_druid_historical.py 
PRE-CREATION 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
PRE-CREATION 
  ambari-server/src/test/python/stacks/2.6/configs/default.json PRE-CREATION 

Diff: https://reviews.apache.org/r/50803/diff/


Testing
---

Tested it locally by installing ambari and adding the newly added resources. 
Was able to install druid and start all newly added services.


Thanks,

Nishant Bangarwa



Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

2016-10-14 Thread Nishant Bangarwa


> On Oct. 8, 2016, 12:02 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml, 
> > line 26
> > 
> >
> > Are these components going to be supported in Rolling/Express Upgrade?
> > If so, will need to add support in hdp-select and conf-select and set 
> > versionAdvertised to true. Can create a separate Jira for this work.
> 
> Nishant Bangarwa wrote:
> yes, these will be supporting rolling/express upgrades in future. 
> created - https://issues.apache.org/jira/browse/AMBARI-18570
> 
> Alejandro Fernandez wrote:
> Is integration with hdp-select and conf-select already present? Will 
> RU/EU be supported in this release, e.g., HDP 2.6?

for hdp-select and conf-select can you point me on how to integrate ? I am not 
very familiar with hdp-select/conf-select, RU/EU will not be supported for HDP 
2.6.


- Nishant


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/#review151901
---


On Oct. 11, 2016, 2:44 p.m., Nishant Bangarwa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50803/
> ---
> 
> (Updated Oct. 11, 2016, 2:44 p.m.)
> 
> 
> Review request for Ambari, Renjith Kamath and Swapan Shridhar.
> 
> 
> Bugs: Ambari-19781
> https://issues.apache.org/jira/browse/Ambari-19781
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Defines Druid as a new service in HDP 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 1f722dc 
> 
> Diff: https://reviews.apache.org/r/50803/diff/
> 
> 
> 

Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

2016-10-11 Thread Alejandro Fernandez


> On Oct. 8, 2016, 12:02 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml, 
> > line 26
> > 
> >
> > Are these components going to be supported in Rolling/Express Upgrade?
> > If so, will need to add support in hdp-select and conf-select and set 
> > versionAdvertised to true. Can create a separate Jira for this work.
> 
> Nishant Bangarwa wrote:
> yes, these will be supporting rolling/express upgrades in future. 
> created - https://issues.apache.org/jira/browse/AMBARI-18570

Is integration with hdp-select and conf-select already present? Will RU/EU be 
supported in this release, e.g., HDP 2.6?


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/#review151901
---


On Oct. 11, 2016, 2:44 p.m., Nishant Bangarwa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50803/
> ---
> 
> (Updated Oct. 11, 2016, 2:44 p.m.)
> 
> 
> Review request for Ambari, Renjith Kamath and Swapan Shridhar.
> 
> 
> Bugs: Ambari-19781
> https://issues.apache.org/jira/browse/Ambari-19781
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Defines Druid as a new service in HDP 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 1f722dc 
> 
> Diff: https://reviews.apache.org/r/50803/diff/
> 
> 
> Testing
> ---
> 
> Tested it locally by installing ambari and adding the newly added resources. 
> Was able to install druid and start all newly added services.
> 
> 
> Thanks,
> 
> Nishant Bangarwa
> 

Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

2016-10-11 Thread Slim Bouguerra

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/#review152150
---




ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
 (line 89)


this is not used thought we can remove it i guess



ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
 (line 37)


this is using curl which means it will fail if curl is not installed or 
part of the bin path.
Not an issue but it will be better to use python http clients.


- Slim Bouguerra


On Oct. 11, 2016, 2:44 p.m., Nishant Bangarwa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50803/
> ---
> 
> (Updated Oct. 11, 2016, 2:44 p.m.)
> 
> 
> Review request for Ambari, Renjith Kamath and Swapan Shridhar.
> 
> 
> Bugs: Ambari-19781
> https://issues.apache.org/jira/browse/Ambari-19781
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Defines Druid as a new service in HDP 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 1f722dc 
> 
> Diff: https://reviews.apache.org/r/50803/diff/
> 
> 
> Testing
> ---
> 
> Tested it locally by installing ambari and adding the newly added resources. 
> Was able to install druid and start all newly added services.
> 
> 
> Thanks,
> 
> Nishant Bangarwa
> 
>



Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

2016-10-11 Thread Nishant Bangarwa


> On Oct. 8, 2016, 12:02 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml, 
> > line 26
> > 
> >
> > Are these components going to be supported in Rolling/Express Upgrade?
> > If so, will need to add support in hdp-select and conf-select and set 
> > versionAdvertised to true. Can create a separate Jira for this work.

yes, these will be supporting rolling/express upgrades in future. 
created - https://issues.apache.org/jira/browse/AMBARI-18570


- Nishant


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/#review151901
---


On Oct. 11, 2016, 2:44 p.m., Nishant Bangarwa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50803/
> ---
> 
> (Updated Oct. 11, 2016, 2:44 p.m.)
> 
> 
> Review request for Ambari, Renjith Kamath and Swapan Shridhar.
> 
> 
> Bugs: Ambari-19781
> https://issues.apache.org/jira/browse/Ambari-19781
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Defines Druid as a new service in HDP 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 1f722dc 
> 
> Diff: https://reviews.apache.org/r/50803/diff/
> 
> 
> Testing
> ---
> 
> Tested it locally by installing ambari and adding the newly added resources. 
> Was able to install druid and start all newly added services.
> 
> 
> Thanks,
> 
> Nishant Bangarwa
> 
>



Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

2016-10-11 Thread Nishant Bangarwa


> On Oct. 7, 2016, 10:39 p.m., Swapan Shridhar wrote:
> > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml,
> >  line 5
> > 
> >
> > 
> > for all configs for consistency.

setting it to add="false" for all configs as per @Alejandro comment below.


> On Oct. 7, 2016, 10:39 p.m., Swapan Shridhar wrote:
> > ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml, 
> > line 107
> > 
> >
> > I assume HDFS is not always required as S3 was also an option.

correct.


- Nishant


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/#review151889
---


On Oct. 11, 2016, 2:44 p.m., Nishant Bangarwa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50803/
> ---
> 
> (Updated Oct. 11, 2016, 2:44 p.m.)
> 
> 
> Review request for Ambari, Renjith Kamath and Swapan Shridhar.
> 
> 
> Bugs: Ambari-19781
> https://issues.apache.org/jira/browse/Ambari-19781
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Defines Druid as a new service in HDP 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 1f722dc 
> 
> Diff: https://reviews.apache.org/r/50803/diff/
> 
> 
> Testing
> ---
> 
> Tested it locally by installing ambari and adding the newly added resources. 
> Was able to install druid and start all newly added services.
> 
> 
> Thanks,
> 
> Nishant Bangarwa
> 
>



Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

2016-10-11 Thread Nishant Bangarwa

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/
---

(Updated Oct. 11, 2016, 2:44 p.m.)


Review request for Ambari, Renjith Kamath and Swapan Shridhar.


Changes
---

Handle review comments and reformat files.


Bugs: Ambari-19781
https://issues.apache.org/jira/browse/Ambari-19781


Repository: ambari


Description
---

Defines Druid as a new service in HDP 2.6


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
1f722dc 

Diff: https://reviews.apache.org/r/50803/diff/


Testing
---

Tested it locally by installing ambari and adding the newly added resources. 
Was able to install druid and start all newly added services.


Thanks,

Nishant Bangarwa



Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

2016-10-09 Thread Swapan Shridhar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/#review151941
---



Further, we need to add to Unit test cases for SA, and install, start, stop 
cases for components, before we checkin.

- Swapan Shridhar


On Oct. 8, 2016, 3:05 a.m., Nishant Bangarwa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50803/
> ---
> 
> (Updated Oct. 8, 2016, 3:05 a.m.)
> 
> 
> Review request for Ambari, Renjith Kamath and Swapan Shridhar.
> 
> 
> Bugs: Ambari-19781
> https://issues.apache.org/jira/browse/Ambari-19781
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Defines Druid as a new service in HDP 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 1f722dc 
> 
> Diff: https://reviews.apache.org/r/50803/diff/
> 
> 
> Testing
> ---
> 
> Tested it locally by installing ambari and adding the newly added resources. 
> Was able to install druid and start all newly added services.
> 
> 
> Thanks,
> 
> Nishant Bangarwa
> 
>



Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

2016-10-07 Thread Nishant Bangarwa

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/
---

(Updated Oct. 8, 2016, 3:05 a.m.)


Review request for Ambari, Renjith Kamath and Swapan Shridhar.


Bugs: Ambari-19781
https://issues.apache.org/jira/browse/Ambari-19781


Repository: ambari


Description
---

Defines Druid as a new service in HDP 2.6


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
1f722dc 

Diff: https://reviews.apache.org/r/50803/diff/


Testing
---

Tested it locally by installing ambari and adding the newly added resources. 
Was able to install druid and start all newly added services.


Thanks,

Nishant Bangarwa



Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

2016-10-07 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/#review151901
---




ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
 (line 9)


Typically, we should set  unless we have a 
good reason to add the property after an Ambari Upgrade. 
Do this for all props.



ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml (line 
26)


Are these components going to be supported in Rolling/Express Upgrade?
If so, will need to add support in hdp-select and conf-select and set 
versionAdvertised to true. Can create a separate Jira for this work.



ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
 (line 33)


Let's indent with 2 spaces


- Alejandro Fernandez


On Aug. 4, 2016, 4:15 p.m., Nishant Bangarwa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50803/
> ---
> 
> (Updated Aug. 4, 2016, 4:15 p.m.)
> 
> 
> Review request for Ambari, Renjith Kamath and Swapan Shridhar.
> 
> 
> Bugs: Ambari-19781
> https://issues.apache.org/jira/browse/Ambari-19781
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Defines Druid as a new service in HDP 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/templates/jvm.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ACCUMULO/metainfo.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/FALCON/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/FLUME/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HBASE/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/metainfo.xml 
> PRE-CREATION 
>   

Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

2016-10-07 Thread Swapan Shridhar


> On Oct. 7, 2016, 10:39 p.m., Swapan Shridhar wrote:
> > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml,
> >  line 67
> > 
> >
> > In case you want to show bytes as unit for all configs wherever 
> > applicable (aesthetics on UI), you can refer this.
> > 
> > 
> > https://github.com/apache/ambari/blob/2ad42074f1633c5c6f56cf979bdaa49440457566/ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml#L404

Applicable for any config where unit is clear and would like to show.


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/#review151889
---


On Aug. 4, 2016, 4:15 p.m., Nishant Bangarwa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50803/
> ---
> 
> (Updated Aug. 4, 2016, 4:15 p.m.)
> 
> 
> Review request for Ambari, Renjith Kamath and Swapan Shridhar.
> 
> 
> Bugs: Ambari-19781
> https://issues.apache.org/jira/browse/Ambari-19781
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Defines Druid as a new service in HDP 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/templates/jvm.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ACCUMULO/metainfo.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/FALCON/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/FLUME/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HBASE/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/KAFKA/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KERBEROS/metainfo.xml
>  PRE-CREATION 
>   

Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

2016-10-07 Thread Swapan Shridhar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/#review151889
---


Fix it, then Ship it!




Please remove 2.6 non-druid related stack files as 
https://hortonworks.jira.com/browse/BUG-66341 has created 2.6 stack.

Fix it and ship it.


ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
 (line 67)


In case you want to show bytes as unit for all configs wherever applicable 
(aesthetics on UI), you can refer this.


https://github.com/apache/ambari/blob/2ad42074f1633c5c6f56cf979bdaa49440457566/ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml#L404



ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
 (line 5)



for all configs for consistency.



ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml (line 
107)


I assume HDFS is not always required as S3 was also an option.



ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
 (line 33)


Just a suggestion. 
It can be made information by atleast separating the logging based on 
component and port in test, to avoid one jumbled o/p.

Something like this:

SC for Component : Component1 at Port :  





SC for Component : Component2 at Port : 







- Swapan Shridhar


On Aug. 4, 2016, 4:15 p.m., Nishant Bangarwa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50803/
> ---
> 
> (Updated Aug. 4, 2016, 4:15 p.m.)
> 
> 
> Review request for Ambari, Renjith Kamath and Swapan Shridhar.
> 
> 
> Bugs: Ambari-19781
> https://issues.apache.org/jira/browse/Ambari-19781
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Defines Druid as a new service in HDP 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/templates/jvm.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml 
> PRE-CREATION 
>   
>