Re: Review Request 50963: Add Kerberos Automation documentation to Ambari source tree so it may be versioned

2016-08-11 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50963/#review145559
---


Ship it!




Ship It!

- Jonathan Hurley


On Aug. 11, 2016, 5:03 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50963/
> ---
> 
> (Updated Aug. 11, 2016, 5:03 p.m.)
> 
> 
> Review request for Ambari, Hitesh Shah, Jonathan Hurley, Mahadev Konar, Nate 
> Cole, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18100
> https://issues.apache.org/jira/browse/AMBARI-18100
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Kerberos Automation documentation to Ambari source tree so it may be 
> versioned. This documentation should be added as MD (markdown) files to 
> .../ambari-server/docs/security/kerberos.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/security/kerberos/enabling_kerberos.md PRE-CREATION 
>   ambari-server/docs/security/kerberos/index.md PRE-CREATION 
>   ambari-server/docs/security/kerberos/kerberos_descriptor.md PRE-CREATION 
>   ambari-server/docs/security/kerberos/kerberos_service.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50963/diff/
> 
> 
> Testing
> ---
> 
> None needed, documentation only.
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 50963: Add Kerberos Automation documentation to Ambari source tree so it may be versioned

2016-08-11 Thread Robert Levas 


> On Aug. 10, 2016, 9:39 p.m., Jonathan Hurley wrote:
> >

The pages rendered fine using IntelliJ's Markdown Support plugin.  I will 
download Mou and fix issues seen there.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50963/#review145449
---


On Aug. 10, 2016, 2:31 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50963/
> ---
> 
> (Updated Aug. 10, 2016, 2:31 p.m.)
> 
> 
> Review request for Ambari, Hitesh Shah, Jonathan Hurley, Mahadev Konar, Nate 
> Cole, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18100
> https://issues.apache.org/jira/browse/AMBARI-18100
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Kerberos Automation documentation to Ambari source tree so it may be 
> versioned. This documentation should be added as MD (markdown) files to 
> .../ambari-server/docs/security/kerberos.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/security/kerberos/enabling_kerberos.md PRE-CREATION 
>   ambari-server/docs/security/kerberos/index.md PRE-CREATION 
>   ambari-server/docs/security/kerberos/kerberos_descriptor.md PRE-CREATION 
>   ambari-server/docs/security/kerberos/kerberos_service.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50963/diff/
> 
> 
> Testing
> ---
> 
> None needed, documentation only.
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 50963: Add Kerberos Automation documentation to Ambari source tree so it may be versioned

2016-08-10 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50963/#review145449
---


Fix it, then Ship it!





ambari-server/docs/security/kerberos/enabling_kerberos.md (lines 42 - 59)


These bullets aren't rendering in any of the MD editors I tried them in. 
It's just one paragraph.



ambari-server/docs/security/kerberos/enabling_kerberos.md (lines 76 - 119)


None of the payloads rendered with any formatting in Mou or MacDown.



ambari-server/docs/security/kerberos/kerberos_service.md (lines 182 - 194)


Not formatted in Mou or MacDown



ambari-server/docs/security/kerberos/kerberos_service.md (lines 262 - 263)


These are huge headers; probably meant to just be commented out?



ambari-server/docs/security/kerberos/kerberos_service.md (lines 265 - 283)


None of this is actually formatted and it's hard to read in MD.


- Jonathan Hurley


On Aug. 10, 2016, 2:31 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50963/
> ---
> 
> (Updated Aug. 10, 2016, 2:31 p.m.)
> 
> 
> Review request for Ambari, Hitesh Shah, Jonathan Hurley, Mahadev Konar, Nate 
> Cole, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18100
> https://issues.apache.org/jira/browse/AMBARI-18100
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Kerberos Automation documentation to Ambari source tree so it may be 
> versioned. This documentation should be added as MD (markdown) files to 
> .../ambari-server/docs/security/kerberos.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/security/kerberos/enabling_kerberos.md PRE-CREATION 
>   ambari-server/docs/security/kerberos/index.md PRE-CREATION 
>   ambari-server/docs/security/kerberos/kerberos_descriptor.md PRE-CREATION 
>   ambari-server/docs/security/kerberos/kerberos_service.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50963/diff/
> 
> 
> Testing
> ---
> 
> None needed, documentation only.
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 50963: Add Kerberos Automation documentation to Ambari source tree so it may be versioned

2016-08-10 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50963/#review145446
---


Ship it!





ambari-server/docs/security/kerberos/index.md (lines 91 - 94)


Mou is not showing these on new lines.  Do you need a carriage return 
before the asterisk?



ambari-server/docs/security/kerberos/kerberos_descriptor.md (lines 148 - 153)


Mou isn't showing json formatted correctly, hopefully your editor does :)


- Nate Cole


On Aug. 10, 2016, 2:31 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50963/
> ---
> 
> (Updated Aug. 10, 2016, 2:31 p.m.)
> 
> 
> Review request for Ambari, Hitesh Shah, Jonathan Hurley, Mahadev Konar, Nate 
> Cole, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18100
> https://issues.apache.org/jira/browse/AMBARI-18100
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Kerberos Automation documentation to Ambari source tree so it may be 
> versioned. This documentation should be added as MD (markdown) files to 
> .../ambari-server/docs/security/kerberos.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/security/kerberos/enabling_kerberos.md PRE-CREATION 
>   ambari-server/docs/security/kerberos/index.md PRE-CREATION 
>   ambari-server/docs/security/kerberos/kerberos_descriptor.md PRE-CREATION 
>   ambari-server/docs/security/kerberos/kerberos_service.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50963/diff/
> 
> 
> Testing
> ---
> 
> None needed, documentation only.
> 
> 
> Thanks,
> 
> Robert Levas
> 
>