Re: Review Request 50990: HDFS Finalize Upgrade alert shows up in Unknown state after EU to 2.3.6

2016-08-12 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50990/
---

(Updated Aug. 12, 2016, 1:13 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
---

Fixed comment


Bugs: AMBARI-18124
https://issues.apache.org/jira/browse/AMBARI-18124


Repository: ambari


Description
---

*Steps*
# Deploy HDP-2.2.6 cluster with Ambari 2.0.2
# Upgrade Ambari to 2.4.0.0
# Perform Express Upgrade to 2.3.6.0 and let it complete
# Go to Alerts page and filter by "HDFS Upgrade Finalized State" Alert 
definition

*Result*
The alert shows in UNKWN state
{code}
Traceback (most recent call last):
File 
"/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/alerts/alert_upgrade_finalized.py",
 line 132, in execute
upgrade_finalized_response_json = json.loads(last_checkpoint_time_response)
File "/usr/lib/python2.6/site-packages/ambari_simplejson/__init__.py", line 
307, in loads
return _default_decoder.decode(s)
File "/usr/lib/python2.6/site-packages/ambari_simplejson/decoder.py", line 335, 
in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/lib/python2.6/site-packages/ambari_simplejson/decoder.py", line 353, 
in raw_decode
raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded
{code}


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_upgrade_finalized.py
 fbda22e 

Diff: https://reviews.apache.org/r/50990/diff/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 50990: HDFS Finalize Upgrade alert shows up in Unknown state after EU to 2.3.6

2016-08-11 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50990/#review145548
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_upgrade_finalized.py
 (line 112)


Is it possible for the NN address not to have a port defined (and use a 
default port?)


- Jonathan Hurley


On Aug. 11, 2016, 12:32 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50990/
> ---
> 
> (Updated Aug. 11, 2016, 12:32 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-18124
> https://issues.apache.org/jira/browse/AMBARI-18124
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Steps*
> # Deploy HDP-2.2.6 cluster with Ambari 2.0.2
> # Upgrade Ambari to 2.4.0.0
> # Perform Express Upgrade to 2.3.6.0 and let it complete
> # Go to Alerts page and filter by "HDFS Upgrade Finalized State" Alert 
> definition
> 
> *Result*
> The alert shows in UNKWN state
> {code}
> Traceback (most recent call last):
> File 
> "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/alerts/alert_upgrade_finalized.py",
>  line 132, in execute
> upgrade_finalized_response_json = json.loads(last_checkpoint_time_response)
> File "/usr/lib/python2.6/site-packages/ambari_simplejson/__init__.py", line 
> 307, in loads
> return _default_decoder.decode(s)
> File "/usr/lib/python2.6/site-packages/ambari_simplejson/decoder.py", line 
> 335, in decode
> obj, end = self.raw_decode(s, idx=_w(s, 0).end())
> File "/usr/lib/python2.6/site-packages/ambari_simplejson/decoder.py", line 
> 353, in raw_decode
> raise ValueError("No JSON object could be decoded")
> ValueError: No JSON object could be decoded
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_upgrade_finalized.py
>  fbda22e 
> 
> Diff: https://reviews.apache.org/r/50990/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>