Re: Review Request 51303: AMBARI-18234. Fix for : (1). Hive service check for HSI and (2). HSI alert on wire encrypted cluster.

[Swapan Shridhar]

> On Aug. 22, 2016, 10:30 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_interactive_thrift_port.py,
> >  line 46
> > 
> >
> > Lets verify that we do not need to read it from hive-site if the 
> > properties exist in hive-site but not in hive-interactive-site

Confirmed with Deepesh. Wire Encryption doc should make it clear about the step 
by step process of doing it and adding the configs both for hive-site and 
hive-interactive-site.


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51303/#review146448
---


On Aug. 22, 2016, 10:20 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51303/
> ---
> 
> (Updated Aug. 22, 2016, 10:20 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18234
> https://issues.apache.org/jira/browse/AMBARI-18234
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Current/Problem :** SSL custom configs 'hive.server2.keystore.path' and 
> 'hive.server2.keystore.password' are currently read from hive1/hive-site. If 
> a user had added it separately in Hive2/hive-interactive-site, we have a 
> problem that we are not reading it from Hive2/hive-interactive-site.
> 
> **Fix:** Read 'hive.server2.keystore.path' and 
> 'hive.server2.keystore.password' from Hive2/hive-interactive-site for (1). 
> Service Check and (2). Alert.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_interactive_thrift_port.py
>  6917160 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  1cd58c3 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/service_check.py
>  303bdda 
> 
> Diff: https://reviews.apache.org/r/51303/diff/
> 
> 
> Testing
> ---
> 
> - Python UT passes.
> - Tested the behavior on live cluster. Works.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 51303: AMBARI-18234. Fix for : (1). Hive service check for HSI and (2). HSI alert on wire encrypted cluster.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51303/#review146448
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_interactive_thrift_port.py
 (line 46)


Lets verify that we do not need to read it from hive-site if the properties 
exist in hive-site but not in hive-interactive-site


- Sumit Mohanty


On Aug. 22, 2016, 10:20 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51303/
> ---
> 
> (Updated Aug. 22, 2016, 10:20 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18234
> https://issues.apache.org/jira/browse/AMBARI-18234
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Current/Problem :** SSL custom configs 'hive.server2.keystore.path' and 
> 'hive.server2.keystore.password' are currently read from hive1/hive-site. If 
> a user had added it separately in Hive2/hive-interactive-site, we have a 
> problem that we are not reading it from Hive2/hive-interactive-site.
> 
> **Fix:** Read 'hive.server2.keystore.path' and 
> 'hive.server2.keystore.password' from Hive2/hive-interactive-site for (1). 
> Service Check and (2). Alert.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_interactive_thrift_port.py
>  6917160 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  1cd58c3 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/service_check.py
>  303bdda 
> 
> Diff: https://reviews.apache.org/r/51303/diff/
> 
> 
> Testing
> ---
> 
> - Python UT passes.
> - Tested the behavior on live cluster. Works.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 51303: AMBARI-18234. Fix for : (1). Hive service check for HSI and (2). HSI alert on wire encrypted cluster.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51303/#review146442
---


Ship it!




Ship It!

- Alejandro Fernandez


On Aug. 22, 2016, 10:20 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51303/
> ---
> 
> (Updated Aug. 22, 2016, 10:20 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18234
> https://issues.apache.org/jira/browse/AMBARI-18234
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Current/Problem :** SSL custom configs 'hive.server2.keystore.path' and 
> 'hive.server2.keystore.password' are currently read from hive1/hive-site. If 
> a user had added it separately in Hive2/hive-interactive-site, we have a 
> problem that we are not reading it from Hive2/hive-interactive-site.
> 
> **Fix:** Read 'hive.server2.keystore.path' and 
> 'hive.server2.keystore.password' from Hive2/hive-interactive-site for (1). 
> Service Check and (2). Alert.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_interactive_thrift_port.py
>  6917160 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  1cd58c3 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/service_check.py
>  303bdda 
> 
> Diff: https://reviews.apache.org/r/51303/diff/
> 
> 
> Testing
> ---
> 
> - Python UT passes.
> - Tested the behavior on live cluster. Works.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 51303: AMBARI-18234. Fix for : (1). Hive service check for HSI and (2). HSI alert on wire encrypted cluster.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51303/
---

(Updated Aug. 22, 2016, 10:20 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
---

Branch updated.


Bugs: AMBARI-18234
https://issues.apache.org/jira/browse/AMBARI-18234


Repository: ambari


Description
---

**Current/Problem :** SSL custom configs 'hive.server2.keystore.path' and 
'hive.server2.keystore.password' are currently read from hive1/hive-site. If a 
user had added it separately in Hive2/hive-interactive-site, we have a problem 
that we are not reading it from Hive2/hive-interactive-site.

**Fix:** Read 'hive.server2.keystore.path' and 'hive.server2.keystore.password' 
from Hive2/hive-interactive-site for (1). Service Check and (2). Alert.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_interactive_thrift_port.py
 6917160 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 1cd58c3 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/service_check.py
 303bdda 

Diff: https://reviews.apache.org/r/51303/diff/


Testing
---

- Python UT passes.
- Tested the behavior on live cluster. Works.


Thanks,

Swapan Shridhar