Re: Review Request 51557: status commands get all the *-env files irrespective of a service exists or not

2016-09-01 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51557/#review147567
---


Ship it!




Ship It!

- Sumit Mohanty


On Sept. 1, 2016, 2:59 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51557/
> ---
> 
> (Updated Sept. 1, 2016, 2:59 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18287
> https://issues.apache.org/jira/browse/AMBARI-18287
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari should not send env files corresponding to the deleted services for 
> the status commands.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  c353049 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java
>  a5396d8 
> 
> Diff: https://reviews.apache.org/r/51557/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 51557: status commands get all the *-env files irrespective of a service exists or not

2016-09-01 Thread Vitalyi Brodetskyi 


> On Вер. 1, 2016, 2:13 після полудня, Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java,
> >  line 269
> > 
> >
> > Can we add a unit test?

Done


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51557/#review147558
---


On Вер. 1, 2016, 2:59 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51557/
> ---
> 
> (Updated Вер. 1, 2016, 2:59 після полудня)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18287
> https://issues.apache.org/jira/browse/AMBARI-18287
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari should not send env files corresponding to the deleted services for 
> the status commands.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  c353049 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java
>  a5396d8 
> 
> Diff: https://reviews.apache.org/r/51557/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 51557: status commands get all the *-env files irrespective of a service exists or not

2016-09-01 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51557/
---

(Updated Вер. 1, 2016, 2:59 після полудня)


Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, and 
Sumit Mohanty.


Bugs: AMBARI-18287
https://issues.apache.org/jira/browse/AMBARI-18287


Repository: ambari


Description
---

Ambari should not send env files corresponding to the deleted services for the 
status commands.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
 c353049 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java
 a5396d8 

Diff: https://reviews.apache.org/r/51557/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 51557: status commands get all the *-env files irrespective of a service exists or not

2016-09-01 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51557/#review147558
---




ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
 (line 269)


Can we add a unit test?


- Sumit Mohanty


On Aug. 31, 2016, 12:27 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51557/
> ---
> 
> (Updated Aug. 31, 2016, 12:27 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18287
> https://issues.apache.org/jira/browse/AMBARI-18287
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari should not send env files corresponding to the deleted services for 
> the status commands.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  c353049 
> 
> Diff: https://reviews.apache.org/r/51557/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 51557: status commands get all the *-env files irrespective of a service exists or not

2016-08-31 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51557/#review147424
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Aug. 31, 2016, 3:27 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51557/
> ---
> 
> (Updated Aug. 31, 2016, 3:27 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18287
> https://issues.apache.org/jira/browse/AMBARI-18287
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari should not send env files corresponding to the deleted services for 
> the status commands.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  c353049 
> 
> Diff: https://reviews.apache.org/r/51557/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>