Re: Review Request 51575: Provide stack-advisor support for Microsoft-R service

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51575/#review147915
---


Ship it!




Ship It!

- Alejandro Fernandez


On Sept. 1, 2016, 1:36 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51575/
> ---
> 
> (Updated Sept. 1, 2016, 1:36 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17891
> https://issues.apache.org/jira/browse/AMBARI-17891
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update existing service_advisor.py for Microsoft-R service to conform to the 
> updated interface (changed in AMBARI-16663).  Also fix leftover comment.
> 
> 
> Diffs
> -
> 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/service_advisor.py
>  554be2d 
> 
> Diff: https://reviews.apache.org/r/51575/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on local cluster (created cluster with HDFS, YARN, and 
> ZooKeeper; added Microsoft-R service via web UI; verified that service 
> advisor is invoked in both recommend-component-layout and 
> validate-component-layout requests, and that it correctly 
> recommends/validates service colocation).
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 51575: Provide stack-advisor support for Microsoft-R service

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51575/#review147644
---


Ship it!




Ship It!

- Oliver Szabo


On Sept. 1, 2016, 1:36 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51575/
> ---
> 
> (Updated Sept. 1, 2016, 1:36 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17891
> https://issues.apache.org/jira/browse/AMBARI-17891
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update existing service_advisor.py for Microsoft-R service to conform to the 
> updated interface (changed in AMBARI-16663).  Also fix leftover comment.
> 
> 
> Diffs
> -
> 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/service_advisor.py
>  554be2d 
> 
> Diff: https://reviews.apache.org/r/51575/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on local cluster (created cluster with HDFS, YARN, and 
> ZooKeeper; added Microsoft-R service via web UI; verified that service 
> advisor is invoked in both recommend-component-layout and 
> validate-component-layout requests, and that it correctly 
> recommends/validates service colocation).
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 51575: Provide stack-advisor support for Microsoft-R service

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51575/#review147643
---


Ship it!




Ship It!

- Sebastian Toader


On Sept. 1, 2016, 3:36 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51575/
> ---
> 
> (Updated Sept. 1, 2016, 3:36 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17891
> https://issues.apache.org/jira/browse/AMBARI-17891
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update existing service_advisor.py for Microsoft-R service to conform to the 
> updated interface (changed in AMBARI-16663).  Also fix leftover comment.
> 
> 
> Diffs
> -
> 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/service_advisor.py
>  554be2d 
> 
> Diff: https://reviews.apache.org/r/51575/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on local cluster (created cluster with HDFS, YARN, and 
> ZooKeeper; added Microsoft-R service via web UI; verified that service 
> advisor is invoked in both recommend-component-layout and 
> validate-component-layout requests, and that it correctly 
> recommends/validates service colocation).
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 51575: Provide stack-advisor support for Microsoft-R service

[Attila Doroszlai]

> On Sept. 1, 2016, 1:57 p.m., Sebastian Toader wrote:
> > contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/service_advisor.py,
> >  line 37
> > 
> >
> > Is there any unit test framework for m-pack? If so please add unit 
> > tests for this class.

There is no unit test framework for mpacks.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51575/#review147556
---


On Sept. 1, 2016, 1:36 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51575/
> ---
> 
> (Updated Sept. 1, 2016, 1:36 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17891
> https://issues.apache.org/jira/browse/AMBARI-17891
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update existing service_advisor.py for Microsoft-R service to conform to the 
> updated interface (changed in AMBARI-16663).  Also fix leftover comment.
> 
> 
> Diffs
> -
> 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/service_advisor.py
>  554be2d 
> 
> Diff: https://reviews.apache.org/r/51575/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on local cluster (created cluster with HDFS, YARN, and 
> ZooKeeper; added Microsoft-R service via web UI; verified that service 
> advisor is invoked in both recommend-component-layout and 
> validate-component-layout requests, and that it correctly 
> recommends/validates service colocation).
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 51575: Provide stack-advisor support for Microsoft-R service

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51575/#review147556
---




contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/service_advisor.py
 (line 37)


Is there any unit test framework for m-pack? If so please add unit tests 
for this class.


- Sebastian Toader


On Sept. 1, 2016, 3:36 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51575/
> ---
> 
> (Updated Sept. 1, 2016, 3:36 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17891
> https://issues.apache.org/jira/browse/AMBARI-17891
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update existing service_advisor.py for Microsoft-R service to conform to the 
> updated interface (changed in AMBARI-16663).  Also fix leftover comment.
> 
> 
> Diffs
> -
> 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/service_advisor.py
>  554be2d 
> 
> Diff: https://reviews.apache.org/r/51575/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on local cluster (created cluster with HDFS, YARN, and 
> ZooKeeper; added Microsoft-R service via web UI; verified that service 
> advisor is invoked in both recommend-component-layout and 
> validate-component-layout requests, and that it correctly 
> recommends/validates service colocation).
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>