Re: Review Request 51691: JMX metric retrieval method may unnecessarily refresh metrics at a high rate

2016-09-08 Thread Jonathan Hurley
> On Sept. 8, 2016, 8:40 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2289 > > > > > > Samme comment as above related to wording...

Re: Review Request 51691: JMX metric retrieval method may unnecessarily refresh metrics at a high rate

2016-09-08 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51691/#review148177 --- Ship it! Ship It! ambari-server/docs/configuration/index.md (

Re: Review Request 51691: JMX metric retrieval method may unnecessarily refresh metrics at a high rate

2016-09-08 Thread Jonathan Hurley
> On Sept. 7, 2016, 1:36 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/services/MetricsRetrievalService.java, > > lines 88-98 > > > > > > Just a nit, but this might be called M

Re: Review Request 51691: JMX metric retrieval method may unnecessarily refresh metrics at a high rate

2016-09-07 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51691/#review148036 --- Ship it! Ship It! - Nate Cole On Sept. 7, 2016, 1:18 p.m., J

Re: Review Request 51691: JMX metric retrieval method may unnecessarily refresh metrics at a high rate

2016-09-07 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51691/#review148019 --- ambari-server/src/main/java/org/apache/ambari/server/state/servic

Re: Review Request 51691: JMX metric retrieval method may unnecessarily refresh metrics at a high rate

2016-09-07 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51691/ --- (Updated Sept. 7, 2016, 1:18 p.m.) Review request for Ambari, Alejandro Fernand