Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

2016-10-02 Thread Anita Jebaraj
> On Sept. 30, 2016, 8:14 p.m., Nate Cole wrote: > > What is the state of this review? Hi Nate...based on your comments and the comments from Jonathan Hurley, it is clear that writing out the passwords in the commands*.json and just masking it in the configurations.json might not be an effecti

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

2016-09-30 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51705/#review151074 --- What is the state of this review? - Nate Cole On Sept. 12, 2016

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

2016-09-14 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51705/#review148923 --- I agree with Nate in that there's a much larger problem looming he

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

2016-09-13 Thread Nate Cole
> On Sept. 13, 2016, 8:37 a.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/ClusterConfiguration.py, lines > > 138-140 > > > > > > Again, I'm not sure what you're fixing here. Every execution com

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

2016-09-13 Thread Anita Jebaraj
> On Sept. 13, 2016, 12:37 p.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/ClusterConfiguration.py, lines > > 138-140 > > > > > > Again, I'm not sure what you're fixing here. Every execution co

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

2016-09-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51705/#review148705 --- ambari-agent/src/main/python/ambari_agent/ClusterConfiguration.py

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

2016-09-12 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51705/ --- (Updated Sept. 12, 2016, 10:48 p.m.) Review request for Ambari, Di Li, Jonathan

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

2016-09-12 Thread Anita Jebaraj
> On Sept. 8, 2016, 5:42 p.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/ClusterConfiguration.py, line 103 > > > > > > This will cause problems since you're storing the obfuscated > > prop

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

2016-09-12 Thread Anita Jebaraj
> On Sept. 8, 2016, 3:25 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java, > > lines 252-257 > > > > > > Will this be a performance issue? On large clusters th

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

2016-09-12 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51705/ --- (Updated Sept. 12, 2016, 8:20 p.m.) Review request for Ambari, Di Li, Jonathan

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

2016-09-08 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51705/#review148212 --- ambari-agent/src/main/python/ambari_agent/ClusterConfiguration.py

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

2016-09-08 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51705/#review148191 --- I'm not sure what you're fixing here. Every execution command is

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

2016-09-07 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51705/ --- (Updated Sept. 7, 2016, 9:14 p.m.) Review request for Ambari, Di Li, Jonathan H