Re: Review Request 51733: AMBARI-18342: Unit Tests failure: test_update_open_files_ulimit (TestMain.TestMain)

2016-09-08 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51733/#review148233
---


Ship it!




Ship It!

- Jonathan Hurley


On Sept. 8, 2016, 2:37 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51733/
> ---
> 
> (Updated Sept. 8, 2016, 2:37 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18342
> https://issues.apache.org/jira/browse/AMBARI-18342
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-18342: Unit Tests failure: test_update_open_files_ulimit 
> (TestMain.TestMain)
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py 
> aa62f299fbe06c95b8566ad60378c302d30c7ac0 
> 
> Diff: https://reviews.apache.org/r/51733/diff/
> 
> 
> Testing
> ---
> 
> In test_update_open_files_ulimit, modified the new value to 240 (which is 
> less than the soft limit on the dev box) and verified that the test passed.
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Re: Review Request 51733: AMBARI-18342: Unit Tests failure: test_update_open_files_ulimit (TestMain.TestMain)

2016-09-08 Thread Nahappan Somasundaram 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51733/
---

(Updated Sept. 8, 2016, 11:37 a.m.)


Review request for Ambari, Jonathan Hurley and Sumit Mohanty.


Changes
---

New value of hard limit is now computed based on the system, instead of a 
hard-code random value. This ensures that the new value is always >= soft limit 
and the assertion always runs.


Bugs: AMBARI-18342
https://issues.apache.org/jira/browse/AMBARI-18342


Repository: ambari


Description
---

AMBARI-18342: Unit Tests failure: test_update_open_files_ulimit 
(TestMain.TestMain)


Diffs (updated)
-

  ambari-agent/src/test/python/ambari_agent/TestMain.py 
aa62f299fbe06c95b8566ad60378c302d30c7ac0 

Diff: https://reviews.apache.org/r/51733/diff/


Testing
---

In test_update_open_files_ulimit, modified the new value to 240 (which is less 
than the soft limit on the dev box) and verified that the test passed.


Thanks,

Nahappan Somasundaram

Re: Review Request 51733: AMBARI-18342: Unit Tests failure: test_update_open_files_ulimit (TestMain.TestMain)

2016-09-08 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51733/#review148211
---




ambari-agent/src/test/python/ambari_agent/TestMain.py (lines 138 - 139)


Doesn't this mean that the test won't run on some boxes since it won't 
assert anything?


- Jonathan Hurley


On Sept. 8, 2016, 12:57 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51733/
> ---
> 
> (Updated Sept. 8, 2016, 12:57 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18342
> https://issues.apache.org/jira/browse/AMBARI-18342
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-18342: Unit Tests failure: test_update_open_files_ulimit 
> (TestMain.TestMain)
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py 
> aa62f299fbe06c95b8566ad60378c302d30c7ac0 
> 
> Diff: https://reviews.apache.org/r/51733/diff/
> 
> 
> Testing
> ---
> 
> In test_update_open_files_ulimit, modified the new value to 240 (which is 
> less than the soft limit on the dev box) and verified that the test passed.
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>