Re: Review Request 51916: YAML Maps Can Include Dashes and Other Non-Word Characters
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51916/#review149079
---
Ship it!
Ship It!
- Robert Levas
On Sept. 15, 2016, 11:54 a.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51916/
> ---
>
> (Updated Sept. 15, 2016, 11:54 a.m.)
>
>
> Review request for Ambari, Nate Cole and Robert Levas.
>
>
> Bugs: AMBARI-18403
> https://issues.apache.org/jira/browse/AMBARI-18403
>
>
> Repository: ambari
>
>
> Description
> ---
>
> AMBARI-18366 introduced a pattern to match in when converting properties to
> YAML which looks for Maps of Maps. Example:
>
> {noformat}
> foo :
> bar :
> [baz]
> foobar :
> [biz]
> {noformat}
>
> However, this does not take into account non-word characters such as dashes.
> The regex should be revised to look for specific markers for the
> map-within-a-map, allowing for non-space characters as keys. The following
> should pass:
>
> {noformat}
> storm-cluster :
> hosts:
> [c6401.ambari.apache.org, c6402.ambari.apache.org,
> c6403-master.ambari.apache.org]
> groups:
> [hadoop, hadoop-secure]
> {noformat}
>
>
> Diffs
> -
>
> ambari-common/src/main/python/ambari_commons/yaml_utils.py 9753177
> ambari-server/src/test/python/TestYAMLUtils.py c6ee343
>
> Diff: https://reviews.apache.org/r/51916/diff/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 51916: YAML Maps Can Include Dashes and Other Non-Word Characters
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51916/#review149072
---
Ship it!
Ship It!
- Nate Cole
On Sept. 15, 2016, 11:54 a.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51916/
> ---
>
> (Updated Sept. 15, 2016, 11:54 a.m.)
>
>
> Review request for Ambari, Nate Cole and Robert Levas.
>
>
> Bugs: AMBARI-18403
> https://issues.apache.org/jira/browse/AMBARI-18403
>
>
> Repository: ambari
>
>
> Description
> ---
>
> AMBARI-18366 introduced a pattern to match in when converting properties to
> YAML which looks for Maps of Maps. Example:
>
> {noformat}
> foo :
> bar :
> [baz]
> foobar :
> [biz]
> {noformat}
>
> However, this does not take into account non-word characters such as dashes.
> The regex should be revised to look for specific markers for the
> map-within-a-map, allowing for non-space characters as keys. The following
> should pass:
>
> {noformat}
> storm-cluster :
> hosts:
> [c6401.ambari.apache.org, c6402.ambari.apache.org,
> c6403-master.ambari.apache.org]
> groups:
> [hadoop, hadoop-secure]
> {noformat}
>
>
> Diffs
> -
>
> ambari-common/src/main/python/ambari_commons/yaml_utils.py 9753177
> ambari-server/src/test/python/TestYAMLUtils.py c6ee343
>
> Diff: https://reviews.apache.org/r/51916/diff/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
