Re: Review Request 52044: Analyze and Optimize Ambari Server Unit Tests - Group 6

2016-09-20 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52044/
---

(Updated Вер. 20, 2016, 2:16 після полудня)


Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Sumit 
Mohanty.


Bugs: AMBARI-18420
https://issues.apache.org/jira/browse/AMBARI-18420


Repository: ambari


Description
---

||Test||Count||Time (s)||
|org.apache.ambari.server.orm.dao.AlertDispatchDAOTest|26|62.096|
|org.apache.ambari.server.serveraction.upgrades.ConfigureActionTest 
|17|51.291|
|org.apache.ambari.server.orm.TestOrmImpl|11|33.667|
|org.apache.ambari.server.state.ServiceTest|9|30.218|
|org.apache.ambari.server.controller.test.BufferedThreadPoolExecutorCompletionServiceTest|4|36.114|


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostConfigMappingDAO.java
 77ff4a2 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java
 b6f5ec2 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java
 ede1f1f 
  ambari-server/src/test/java/org/apache/ambari/server/orm/TestOrmImpl.java 
ce1c7e6 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java
 2518e0a 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
 9b9fee5 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java
 be0aeef 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
 cb63b0f 
  ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java 
79fe0e9 
  
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
 afcc90e 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java
 50ba3ef 

Diff: https://reviews.apache.org/r/52044/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 52044: Analyze and Optimize Ambari Server Unit Tests - Group 6

2016-09-20 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52044/#review149663
---


Ship it!




Ship It!

- Andrew Onischuk


On Sept. 20, 2016, 2:16 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52044/
> ---
> 
> (Updated Sept. 20, 2016, 2:16 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-18420
> https://issues.apache.org/jira/browse/AMBARI-18420
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ||Test||Count||Time (s)||
> |org.apache.ambari.server.orm.dao.AlertDispatchDAOTest|26|62.096|
> |org.apache.ambari.server.serveraction.upgrades.ConfigureActionTest   
> |17|51.291|
> |org.apache.ambari.server.orm.TestOrmImpl|11|33.667|
> |org.apache.ambari.server.state.ServiceTest|9|30.218|
> |org.apache.ambari.server.controller.test.BufferedThreadPoolExecutorCompletionServiceTest|4|36.114|
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostConfigMappingDAO.java
>  77ff4a2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java
>  b6f5ec2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java
>  ede1f1f 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/TestOrmImpl.java 
> ce1c7e6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java
>  2518e0a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
>  9b9fee5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java
>  be0aeef 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
>  cb63b0f 
>   ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java 
> 79fe0e9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
>  afcc90e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java
>  50ba3ef 
> 
> Diff: https://reviews.apache.org/r/52044/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 52044: Analyze and Optimize Ambari Server Unit Tests - Group 6

2016-09-20 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52044/#review149645
---


Ship it!





ambari-server/src/test/java/org/apache/ambari/server/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java
 (line 34)


lol


- Dmitro Lisnichenko


On Sept. 20, 2016, 11:59 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52044/
> ---
> 
> (Updated Sept. 20, 2016, 11:59 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-18420
> https://issues.apache.org/jira/browse/AMBARI-18420
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ||Test||Count||Time (s)||
> |org.apache.ambari.server.orm.dao.AlertDispatchDAOTest|26|62.096|
> |org.apache.ambari.server.serveraction.upgrades.ConfigureActionTest   
> |17|51.291|
> |org.apache.ambari.server.orm.TestOrmImpl|11|33.667|
> |org.apache.ambari.server.state.ServiceTest|9|30.218|
> |org.apache.ambari.server.controller.test.BufferedThreadPoolExecutorCompletionServiceTest|4|36.114|
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostConfigMappingDAO.java
>  77ff4a2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java
>  b6f5ec2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java
>  ede1f1f 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/TestOrmImpl.java 
> ce1c7e6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java
>  2518e0a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
>  9b9fee5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java
>  be0aeef 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
>  cb63b0f 
>   ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java 
> 79fe0e9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
>  afcc90e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java
>  50ba3ef 
> 
> Diff: https://reviews.apache.org/r/52044/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 52044: Analyze and Optimize Ambari Server Unit Tests - Group 6

2016-09-20 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52044/
---

(Updated Вер. 20, 2016, 8:59 до полудня)


Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Sumit 
Mohanty.


Bugs: AMBARI-18420
https://issues.apache.org/jira/browse/AMBARI-18420


Repository: ambari


Description
---

||Test||Count||Time (s)||
|org.apache.ambari.server.orm.dao.AlertDispatchDAOTest|26|62.096|
|org.apache.ambari.server.serveraction.upgrades.ConfigureActionTest 
|17|51.291|
|org.apache.ambari.server.orm.TestOrmImpl|11|33.667|
|org.apache.ambari.server.state.ServiceTest|9|30.218|
|org.apache.ambari.server.controller.test.BufferedThreadPoolExecutorCompletionServiceTest|4|36.114|


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostConfigMappingDAO.java
 77ff4a2 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java
 b6f5ec2 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java
 ede1f1f 
  ambari-server/src/test/java/org/apache/ambari/server/orm/TestOrmImpl.java 
ce1c7e6 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java
 2518e0a 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
 9b9fee5 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java
 be0aeef 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
 cb63b0f 
  ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java 
79fe0e9 
  
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
 afcc90e 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java
 50ba3ef 

Diff: https://reviews.apache.org/r/52044/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 52044: Analyze and Optimize Ambari Server Unit Tests - Group 6

2016-09-19 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52044/
---

(Updated Вер. 19, 2016, 9:10 після полудня)


Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Sumit 
Mohanty.


Bugs: AMBARI-18420
https://issues.apache.org/jira/browse/AMBARI-18420


Repository: ambari


Description
---

||Test||Count||Time (s)||
|org.apache.ambari.server.orm.dao.AlertDispatchDAOTest|26|62.096|
|org.apache.ambari.server.serveraction.upgrades.ConfigureActionTest 
|17|51.291|
|org.apache.ambari.server.orm.TestOrmImpl|11|33.667|
|org.apache.ambari.server.state.ServiceTest|9|30.218|
|org.apache.ambari.server.controller.test.BufferedThreadPoolExecutorCompletionServiceTest|4|36.114|


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostConfigMappingDAO.java
 77ff4a2 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java
 b6f5ec2 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java
 ede1f1f 
  ambari-server/src/test/java/org/apache/ambari/server/orm/TestOrmImpl.java 
ce1c7e6 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java
 2518e0a 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
 9b9fee5 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java
 be0aeef 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
 cb63b0f 
  ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java 
79fe0e9 
  
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
 afcc90e 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java
 50ba3ef 

Diff: https://reviews.apache.org/r/52044/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi