Re: Review Request 52136: Add granular flags for sysprepped clusters to copy tarballs, Oozie share lib, fast jar, and create users
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52136/ --- (Updated Sept. 22, 2016, 10:50 p.m.) Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Sumit Mohanty. Bugs: AMBARI-18438 https://issues.apache.org/jira/browse/AMBARI-18438 Repository: ambari Description (updated) --- In order to support sysprepped clusters using Docker containers, we need more granular flags about what steps must be done, e.g., * Copy tarballs to HDFS * Copy Oozie share lib to HDFS * Copy fast jar (fast-hdfs-resource.jar) to /var/lib/ambari-agent/lib/ * Create users and groups These properties will be stored in cluster-env instead of ambari.properties so they can be changed without requiring a restart of Ambari Server. sysprep_skip_copy_tarballs_hdfs=true|false (default is false) sysprep_skip_copy_oozie_share_lib_to_hdfs=true|false (default is false) sysprep_skip_copy_fast_jar_hdfs=true|false (default is false) sysprep_skip_create_users_and_groups=true|false (default is false) For existing users that have automated everything on a sysprepped cluster, they should set these flags as true. These flags are only valid if ambari.properties knows the cluster is sysprepped, i.e., packages.pre.installed=true Diffs (updated) - ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py 2626990 ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py 591c064 ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 4c111f1 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 6934924 ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py d3a9294 ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params.py f3208ce ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py 7514918 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 3249dd4 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py 6511d0e ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 7c886b2 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 0251d27 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params.py f10a3f3 ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py f631ac9 ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py fe367b6 ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py 14e021d ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py 8ef3ba8 ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py 4740131 ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params.py 28d654e ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py 36541e7 ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py e029092 ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py e63627d ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params.py 842e5ed ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_linux.py 6bf41b4 ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/service_check.py 468dfb1 ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/job_history_server.py 2825f35 ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py 4e525db ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_service.py 82a010a ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py 3a0cff5 ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py e461186 ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py 590b299 ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params.py ec71506 ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params.py f10a3f3 ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 1e591f4
Re: Review Request 52136: Add granular flags for sysprepped clusters to copy tarballs, Oozie share lib, fast jar, and create users
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52136/#review149965 --- Ship it! sysprep_create_users_and_groups=true|false (default is true) How about renaming it to sysprep_skip_creating_users_and_groups to avoid confusion about inverted default value? I mean that "For existing users that have automated everything on a sysprepped cluster, they should set these flags as true, true, true, false, respectively." the last false is somewhat counter-intuitive - Dmitro Lisnichenko On Sept. 22, 2016, 12:53 a.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52136/ > --- > > (Updated Sept. 22, 2016, 12:53 a.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Sumit > Mohanty. > > > Bugs: AMBARI-18438 > https://issues.apache.org/jira/browse/AMBARI-18438 > > > Repository: ambari > > > Description > --- > > In order to support sysprepped clusters using Docker containers, we need more > granular flags about what steps must be done, e.g., > > * Copy tarballs to HDFS > * Copy Oozie share lib to HDFS > * Copy fast jar (fast-hdfs-resource.jar) to /var/lib/ambari-agent/lib/ > * Create users and groups > > These properties will be stored in cluster-env instead of ambari.properties > so they can be changed without requiring a restart of Ambari Server. > > sysprep_skip_copy_tarballs_hdfs=true|false (default is false) > sysprep_skip_copy_oozie_share_lib_to_hdfs=true|false (default is false) > sysprep_skip_copy_fast_jar_hdfs=true|false (default is false) > sysprep_create_users_and_groups=true|false (default is true) > > For existing users that have automated everything on a sysprepped cluster, > they should set these flags as true, true, true, false, respectively. > > These flags are only valid if ambari.properties knows the cluster is > sysprepped, i.e., > packages.pre.installed=true > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py > 2626990 > > ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py > 591c064 > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py > 4c111f1 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py > 6934924 > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py > d3a9294 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params.py > f3208ce > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py > 7514918 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py > 3249dd4 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py > 6511d0e > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py > 7c886b2 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py > da05913 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params.py > f10a3f3 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > f631ac9 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py > fe367b6 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py > 14e021d > > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py > 8ef3ba8 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py > 4740131 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params.py > 28d654e > > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py > 36541e7 > > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py > e029092 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > e63627d > > ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params.py > 842e5ed > > ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_linux.py > 6bf41b4 > > ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/service_check.py > 468dfb1 > >
