Re: Review Request 52139: AMBARI-18440. Add the option of providing 'aux jars' while creating LLAP package.

2016-09-21 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52139/#review149927
---


Ship it!




Ship It!

- Alejandro Fernandez


On Sept. 21, 2016, 11:56 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52139/
> ---
> 
> (Updated Sept. 21, 2016, 11:56 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18440
> https://issues.apache.org/jira/browse/AMBARI-18440
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - This option will help the user to provide auxiliary jars that they want to 
> be included in the LLAP package creation and available for LLAP.
> - User can provide the path and JAR name as a comma separated list in 
> 'hive-interactive-env' config 'hive_aux_jars'.
> 
> 
> *How to use the option of specifying the JARs :*
> 
> I have added a new config in hive-interactive-env named *'hive_aux_jars'*.
> 
> You can add it in Blueprint in your hive-interactive-env config bag, just 
> like you would be adding any other config.
> 
> **Points to note:**
> 
> - A comma separated list can be specified with the full paths.
> - By default, its empty.
> - If the config is empty, the '--auxjars' param wont be added to the command 
> used for creating LLAP. Els, it will be added with the supplied value.
> 
> **Example**
> 
> hive_aux_jars config having value:
> 
> ==
> '/usr/hdp/current/hive-server2-hive2/bin/hive --service llap --instances 1 
> --slider-am-container-mb 3072 --size 3072m  --cache 0m --xmx 2457m --loglevel 
> INFO --output /var/lib/ambari-agent/tmp/llap-slider2016-09-21_23-12-54 
> **--auxjars /tmp/dummy.jar,/tmp/dummy1.jar** --args " -XX:+AlwaysPreTouch 
> -XX:+UseG1GC -XX:TLABSize=8m -XX:+ResizeTLAB -XX:+UseNUMA -XX:+AggressiveOpts 
> -XX:MetaspaceSize=1024m -XX:InitiatingHeapOccupancyPercent=80 
> -XX:MaxGCPauseMillis=200"'
> ==
> 
> hive_aux_jars config when empty:
> 
> ==
> '/usr/hdp/current/hive-server2-hive2/bin/hive --service llap --instances 1 
> --slider-am-container-mb 3072 --size 3072m  --cache 0m --xmx 2457m --loglevel 
> INFO --output /var/lib/ambari-agent/tmp/llap-slider2016-09-21_22-40-50 --args 
> " -XX:+AlwaysPreTouch -XX:+UseG1GC -XX:TLABSize=8m -XX:+ResizeTLAB 
> -XX:+UseNUMA -XX:+AggressiveOpts -XX:MetaspaceSize=1024m 
> -XX:InitiatingHeapOccupancyPercent=80 -XX:MaxGCPauseMillis=200"'
> ==
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  da05913 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  5f78a1f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  f5ef902 
> 
> Diff: https://reviews.apache.org/r/52139/diff/
> 
> 
> Testing
> ---
> 
> - Python UT passes.
> 
> --
> Ran 268 tests in 6.699s
> 
> OK
> --
> Total run:1126
> Total errors:0
> Total failures:0
> OK
> 
> 
> - jenkins pending.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>



Re: Review Request 52139: AMBARI-18440. Add the option of providing 'aux jars' while creating LLAP package.

2016-09-21 Thread Sumit Mohanty

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52139/#review149923
---


Ship it!




Ship It!

- Sumit Mohanty


On Sept. 21, 2016, 11:56 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52139/
> ---
> 
> (Updated Sept. 21, 2016, 11:56 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18440
> https://issues.apache.org/jira/browse/AMBARI-18440
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - This option will help the user to provide auxiliary jars that they want to 
> be included in the LLAP package creation and available for LLAP.
> - User can provide the path and JAR name as a comma separated list in 
> 'hive-interactive-env' config 'hive_aux_jars'.
> 
> 
> *How to use the option of specifying the JARs :*
> 
> I have added a new config in hive-interactive-env named *'hive_aux_jars'*.
> 
> You can add it in Blueprint in your hive-interactive-env config bag, just 
> like you would be adding any other config.
> 
> **Points to note:**
> 
> - A comma separated list can be specified with the full paths.
> - By default, its empty.
> - If the config is empty, the '--auxjars' param wont be added to the command 
> used for creating LLAP. Els, it will be added with the supplied value.
> 
> **Example**
> 
> hive_aux_jars config having value:
> 
> ==
> '/usr/hdp/current/hive-server2-hive2/bin/hive --service llap --instances 1 
> --slider-am-container-mb 3072 --size 3072m  --cache 0m --xmx 2457m --loglevel 
> INFO --output /var/lib/ambari-agent/tmp/llap-slider2016-09-21_23-12-54 
> **--auxjars /tmp/dummy.jar,/tmp/dummy1.jar** --args " -XX:+AlwaysPreTouch 
> -XX:+UseG1GC -XX:TLABSize=8m -XX:+ResizeTLAB -XX:+UseNUMA -XX:+AggressiveOpts 
> -XX:MetaspaceSize=1024m -XX:InitiatingHeapOccupancyPercent=80 
> -XX:MaxGCPauseMillis=200"'
> ==
> 
> hive_aux_jars config when empty:
> 
> ==
> '/usr/hdp/current/hive-server2-hive2/bin/hive --service llap --instances 1 
> --slider-am-container-mb 3072 --size 3072m  --cache 0m --xmx 2457m --loglevel 
> INFO --output /var/lib/ambari-agent/tmp/llap-slider2016-09-21_22-40-50 --args 
> " -XX:+AlwaysPreTouch -XX:+UseG1GC -XX:TLABSize=8m -XX:+ResizeTLAB 
> -XX:+UseNUMA -XX:+AggressiveOpts -XX:MetaspaceSize=1024m 
> -XX:InitiatingHeapOccupancyPercent=80 -XX:MaxGCPauseMillis=200"'
> ==
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  da05913 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  5f78a1f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  f5ef902 
> 
> Diff: https://reviews.apache.org/r/52139/diff/
> 
> 
> Testing
> ---
> 
> - Python UT passes.
> 
> --
> Ran 268 tests in 6.699s
> 
> OK
> --
> Total run:1126
> Total errors:0
> Total failures:0
> OK
> 
> 
> - jenkins pending.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>



Re: Review Request 52139: AMBARI-18440. Add the option of providing 'aux jars' while creating LLAP package.

2016-09-21 Thread Swapan Shridhar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52139/
---

(Updated Sept. 21, 2016, 11:56 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
---

Updated description.


Bugs: AMBARI-18440
https://issues.apache.org/jira/browse/AMBARI-18440


Repository: ambari


Description (updated)
---

- This option will help the user to provide auxiliary jars that they want to be 
included in the LLAP package creation and available for LLAP.
- User can provide the path and JAR name as a comma separated list in 
'hive-interactive-env' config 'hive_aux_jars'.


*How to use the option of specifying the JARs :*

I have added a new config in hive-interactive-env named *'hive_aux_jars'*.

You can add it in Blueprint in your hive-interactive-env config bag, just like 
you would be adding any other config.

**Points to note:**

- A comma separated list can be specified with the full paths.
- By default, its empty.
- If the config is empty, the '--auxjars' param wont be added to the command 
used for creating LLAP. Els, it will be added with the supplied value.

**Example**

hive_aux_jars config having value:

==
'/usr/hdp/current/hive-server2-hive2/bin/hive --service llap --instances 1 
--slider-am-container-mb 3072 --size 3072m  --cache 0m --xmx 2457m --loglevel 
INFO --output /var/lib/ambari-agent/tmp/llap-slider2016-09-21_23-12-54 
**--auxjars /tmp/dummy.jar,/tmp/dummy1.jar** --args " -XX:+AlwaysPreTouch 
-XX:+UseG1GC -XX:TLABSize=8m -XX:+ResizeTLAB -XX:+UseNUMA -XX:+AggressiveOpts 
-XX:MetaspaceSize=1024m -XX:InitiatingHeapOccupancyPercent=80 
-XX:MaxGCPauseMillis=200"'
==

hive_aux_jars config when empty:

==
'/usr/hdp/current/hive-server2-hive2/bin/hive --service llap --instances 1 
--slider-am-container-mb 3072 --size 3072m  --cache 0m --xmx 2457m --loglevel 
INFO --output /var/lib/ambari-agent/tmp/llap-slider2016-09-21_22-40-50 --args " 
-XX:+AlwaysPreTouch -XX:+UseG1GC -XX:TLABSize=8m -XX:+ResizeTLAB -XX:+UseNUMA 
-XX:+AggressiveOpts -XX:MetaspaceSize=1024m 
-XX:InitiatingHeapOccupancyPercent=80 -XX:MaxGCPauseMillis=200"'
==


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 da05913 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 5f78a1f 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
 f5ef902 

Diff: https://reviews.apache.org/r/52139/diff/


Testing
---

- Python UT passes.

--
Ran 268 tests in 6.699s

OK
--
Total run:1126
Total errors:0
Total failures:0
OK


- jenkins pending.


Thanks,

Swapan Shridhar