Re: Review Request 52396: Need to click Cancel twice to dismiss Set Rack dialog when no value entered
> On Sept. 29, 2016, 5:26 p.m., Alexandr Antonenko wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thanks Alexandr. Can you please help push the fix. np done - Alexandr --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52396/#review150877 --- On Sept. 29, 2016, 4:40 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52396/ > --- > > (Updated Sept. 29, 2016, 4:40 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Di Li. > > > Bugs: AMBARI-18490 > https://issues.apache.org/jira/browse/AMBARI-18490 > > > Repository: ambari > > > Description > --- > > If you cancel the Set Rack dialog without entering any value, an error > appears at the bottom of the dialog instead of the dialog being dismissed. > Only when you click the second time does the dialog disappear. This happens > because the validate function gets called during cancel and because no value > was entered for rack id, the rack id is null and the validation code flags > the error. > > Fix is to initialize the rack id to an empty string so that validation does > not flag an error even during Cancel. > > > Diffs > - > > ambari-web/app/utils/hosts.js e4a437c > > Diff: https://reviews.apache.org/r/52396/diff/ > > > Testing > --- > > Manual testing. > mvn clean test > 30366 tests complete (45 seconds) > 151 tests pending > > There are existing test cases for validation of rackID. > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 52396: Need to click Cancel twice to dismiss Set Rack dialog when no value entered
> On Sept. 29, 2016, 5:25 p.m., Di Li wrote: > > Ship It! Thank you Di. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52396/#review150875 --- On Sept. 29, 2016, 4:40 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52396/ > --- > > (Updated Sept. 29, 2016, 4:40 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Di Li. > > > Bugs: AMBARI-18490 > https://issues.apache.org/jira/browse/AMBARI-18490 > > > Repository: ambari > > > Description > --- > > If you cancel the Set Rack dialog without entering any value, an error > appears at the bottom of the dialog instead of the dialog being dismissed. > Only when you click the second time does the dialog disappear. This happens > because the validate function gets called during cancel and because no value > was entered for rack id, the rack id is null and the validation code flags > the error. > > Fix is to initialize the rack id to an empty string so that validation does > not flag an error even during Cancel. > > > Diffs > - > > ambari-web/app/utils/hosts.js e4a437c > > Diff: https://reviews.apache.org/r/52396/diff/ > > > Testing > --- > > Manual testing. > mvn clean test > 30366 tests complete (45 seconds) > 151 tests pending > > There are existing test cases for validation of rackID. > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 52396: Need to click Cancel twice to dismiss Set Rack dialog when no value entered
> On Sept. 29, 2016, 5:26 p.m., Alexandr Antonenko wrote: > > Ship It! Thanks Alexandr. Can you please help push the fix. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52396/#review150877 --- On Sept. 29, 2016, 4:40 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52396/ > --- > > (Updated Sept. 29, 2016, 4:40 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Di Li. > > > Bugs: AMBARI-18490 > https://issues.apache.org/jira/browse/AMBARI-18490 > > > Repository: ambari > > > Description > --- > > If you cancel the Set Rack dialog without entering any value, an error > appears at the bottom of the dialog instead of the dialog being dismissed. > Only when you click the second time does the dialog disappear. This happens > because the validate function gets called during cancel and because no value > was entered for rack id, the rack id is null and the validation code flags > the error. > > Fix is to initialize the rack id to an empty string so that validation does > not flag an error even during Cancel. > > > Diffs > - > > ambari-web/app/utils/hosts.js e4a437c > > Diff: https://reviews.apache.org/r/52396/diff/ > > > Testing > --- > > Manual testing. > mvn clean test > 30366 tests complete (45 seconds) > 151 tests pending > > There are existing test cases for validation of rackID. > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 52396: Need to click Cancel twice to dismiss Set Rack dialog when no value entered
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52396/#review150877 --- Ship it! Ship It! - Alexandr Antonenko On Sept. 29, 2016, 4:40 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52396/ > --- > > (Updated Sept. 29, 2016, 4:40 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Di Li. > > > Bugs: AMBARI-18490 > https://issues.apache.org/jira/browse/AMBARI-18490 > > > Repository: ambari > > > Description > --- > > If you cancel the Set Rack dialog without entering any value, an error > appears at the bottom of the dialog instead of the dialog being dismissed. > Only when you click the second time does the dialog disappear. This happens > because the validate function gets called during cancel and because no value > was entered for rack id, the rack id is null and the validation code flags > the error. > > Fix is to initialize the rack id to an empty string so that validation does > not flag an error even during Cancel. > > > Diffs > - > > ambari-web/app/utils/hosts.js e4a437c > > Diff: https://reviews.apache.org/r/52396/diff/ > > > Testing > --- > > Manual testing. > mvn clean test > 30366 tests complete (45 seconds) > 151 tests pending > > There are existing test cases for validation of rackID. > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 52396: Need to click Cancel twice to dismiss Set Rack dialog when no value entered
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52396/#review150875 --- Ship it! Ship It! - Di Li On Sept. 29, 2016, 4:40 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52396/ > --- > > (Updated Sept. 29, 2016, 4:40 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Di Li. > > > Bugs: AMBARI-18490 > https://issues.apache.org/jira/browse/AMBARI-18490 > > > Repository: ambari > > > Description > --- > > If you cancel the Set Rack dialog without entering any value, an error > appears at the bottom of the dialog instead of the dialog being dismissed. > Only when you click the second time does the dialog disappear. This happens > because the validate function gets called during cancel and because no value > was entered for rack id, the rack id is null and the validation code flags > the error. > > Fix is to initialize the rack id to an empty string so that validation does > not flag an error even during Cancel. > > > Diffs > - > > ambari-web/app/utils/hosts.js e4a437c > > Diff: https://reviews.apache.org/r/52396/diff/ > > > Testing > --- > > Manual testing. > mvn clean test > 30366 tests complete (45 seconds) > 151 tests pending > > There are existing test cases for validation of rackID. > > > Thanks, > > Sangeeta Ravindran > >
