Re: Review Request 52430: Include an option to download the saved query in hive view

> On Oct. 7, 2016, 4:41 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! > > Anita Jebaraj wrote: > Hi Dipayan...thank you for reviewing the code.Can you please help in > pushing the code? Push it into trunk, branch-2.5 - DIPAYAN ---

Re: Review Request 52430: Include an option to download the saved query in hive view

> On Oct. 7, 2016, 4:41 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! Hi Dipayan...thank you for reviewing the code.Can you please help in pushing the code? - Anita --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 52430: Include an option to download the saved query in hive view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/#review151812 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Oct. 7, 2016, 4:33

Re: Review Request 52430: Include an option to download the saved query in hive view

> On Oct. 4, 2016, 7:18 p.m., Alexandr Antonenko wrote: > > UI changes are looking good, but you need also aprove from java developer Thank you Alex - Anita --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 52430: Include an option to download the saved query in hive view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/#review151374 --- Ship it! UI changes are looking good, but you need also aprove

Re: Review Request 52430: Include an option to download the saved query in hive view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/#review151367 --- Ship it! Ship It! - Di Li On Oct. 3, 2016, 11:25 p.m.,

Re: Review Request 52430: Include an option to download the saved query in hive view

> On Oct. 3, 2016, 7:41 p.m., Di Li wrote: > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java, > > line 86 > > > > > > what's the point of passing

Re: Review Request 52430: Include an option to download the saved query in hive view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/ --- (Updated Oct. 3, 2016, 11:25 p.m.) Review request for Ambari, Alexandr

Re: Review Request 52430: Include an option to download the saved query in hive view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/#review151220 ---

Re: Review Request 52430: Include an option to download the saved query in hive view

> On Sept. 30, 2016, 7:48 p.m., Di Li wrote: > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java, > > line 117 > > > > > > Does this store the entire

Re: Review Request 52430: Include an option to download the saved query in hive view

> On Sept. 30, 2016, 7:45 p.m., Di Li wrote: > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java, > > line 103 > > > > > > REST API URLs mostly use

Re: Review Request 52430: Include an option to download the saved query in hive view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/ --- (Updated Oct. 3, 2016, 6:13 p.m.) Review request for Ambari, Alexandr

Re: Review Request 52430: Include an option to download the saved query in hive view

> On Sept. 30, 2016, 7:46 p.m., Di Li wrote: > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/queries.js, > > line 107 > > > > > > what can the file name be? is it the same as the query id

Re: Review Request 52430: Include an option to download the saved query in hive view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/#review151070 ---

Re: Review Request 52430: Include an option to download the saved query in hive view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/#review151068 ---

Re: Review Request 52430: Include an option to download the saved query in hive view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/#review151067 ---

Re: Review Request 52430: Include an option to download the saved query in hive view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/ --- (Updated Sept. 30, 2016, 4:41 p.m.) Review request for Ambari. Bugs: