----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52876/#review152680 -----------------------------------------------------------
Ship it! Ship It! - Tim Thorpe On Oct. 14, 2016, 2:44 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52876/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2016, 2:44 p.m.) > > > Review request for Ambari and Tim Thorpe. > > > Bugs: AMBARI-18588 > https://issues.apache.org/jira/browse/AMBARI-18588 > > > Repository: ambari > > > Description > ------- > > When YARN RM HTTP response is a 404, the response body is empty and this > results in an empty responseMap, that later caused Ambari server to crash > with NPE when it tries to read properties from the responseMap. > > This JIRA proposes to set property values as null when the responseMap is > null (due to empty body passed back from the YARN web server side). > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JsonHttpPropertyRequest.java > 6a93b4b > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java > c176ceb > > Diff: https://reviews.apache.org/r/52876/diff/ > > > Testing > ------- > > 1. existing unit testing > 2. patch a cluster with the change > > > Thanks, > > Di Li > >
