Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/#review157822 --- Ship it! Ship It! - Jonathan Hurley On Dec. 2, 2016, 3:45 p.

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

> On Dec. 2, 2016, 2:41 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java, > > line 335 > > > > > > What if the cluster name is provided, but doesn't

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/ --- (Updated Dec. 2, 2016, 12:45 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

> On Dec. 2, 2016, 11:41 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java, > > line 335 > > > > > > What if the cluster name is provided, but doesn'

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

> On Dec. 2, 2016, 11:41 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java, > > line 335 > > > > > > What if the cluster name is provided, but doesn'

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/#review157803 --- ambari-server/src/main/java/org/apache/ambari/server/agent/HeartB

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/#review157783 --- Ship it! Ship It! - Nate Cole On Dec. 2, 2016, 1:18 p.m., Na

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/ --- (Updated Dec. 2, 2016, 10:18 a.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/ --- (Updated Dec. 1, 2016, 1:50 p.m.) Review request for Ambari, Jonathan Hurley, N

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

> On Dec. 1, 2016, 11:44 a.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py, > > lines 226-227 > > > > > > The default password of the keystore file from CredentialShel

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/#review157631 --- Fix it, then Ship it! ambari-agent/src/main/python/ambari_agen

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

> On Dec. 1, 2016, 9:04 a.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py, > > lines 150-154 > > > > > > If you use the temp directory, don't you run the risk of

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/#review157607 --- ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrat

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/ --- (Updated Nov. 30, 2016, 2:09 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

> On Nov. 30, 2016, 10:13 a.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py, > > lines 203-204 > > > > > > Would still prefer keytool over a custom class. What did yo

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

> On Nov. 30, 2016, 7:13 a.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py, > > line 71 > > > > > > You are os.path.joining with a '*' below, so you'll end up with > >

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

> On Nov. 30, 2016, 7:21 a.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py, > > lines 144-149 > > > > > > Do you expect this to be overridden in the future? If n

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/#review157413 --- ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrat

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/#review157408 --- ambari-agent/conf/unix/ambari-agent.ini (line 49)

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/ --- (Updated Nov. 29, 2016, 8:29 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/ --- (Updated Nov. 29, 2016, 1:40 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

> On Nov. 29, 2016, 1:16 p.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py, > > lines 165-170 > > > > > > The problem with the Orchestrator doing this is that the stac

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

> On Nov. 29, 2016, 10:16 a.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py, > > lines 165-170 > > > > > > The problem with the Orchestrator doing this is that the sta

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/#review157285 --- ambari-agent/pom.xml (lines 671 - 680)

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/ --- (Updated Nov. 29, 2016, 9:07 a.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

> On Nov. 29, 2016, 8:42 a.m., Nate Cole wrote: > > What's the state of this review? There is a small change to the patch that I'm testing out. Will publish that and submit it today. Thank you. - Nahappan --- This is an automatically g

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/#review157271 --- What's the state of this review? - Nate Cole On Nov. 14, 2016,

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/#review156781 --- Ship it! Ship It! - Nate Cole On Nov. 14, 2016, 6:50 p.m., N

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/#review156046 --- Ship it! Ship It! - Robert Levas On Nov. 14, 2016, 6:50 p.m.

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/#review156007 --- Ship it! Ship It! - Jonathan Hurley On Nov. 14, 2016, 6:50 p