----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54254/#review157589 -----------------------------------------------------------
Ship it! Ship It! - Andrii Tkach On Dec. 1, 2016, 2 p.m., Andriy Babiichuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54254/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2016, 2 p.m.) > > > Review request for Ambari and Andrii Tkach. > > > Bugs: AMBARI-19048 > https://issues.apache.org/jira/browse/AMBARI-19048 > > > Repository: ambari > > > Description > ------- > > When a service is deleted, it's related configuration are changed as per > stack advisor recommendation. > > As scope of this ticket, ambari-web should show all the configuration that > will be changed in recommendation popup when a service is deleted. This popup > should be same as the one shown while doing service->config change and > clicking on save button. > > Following similar flow as on service->config page, When user confirms > recommended changes, ambari-web should male API call for checked config > changes. > > If no config will be changed on any service deletion action then in that case > recommendation popup should bot be shown > > > Diffs > ----- > > ambari-web/app/controllers/main/service/info/configs.js 130b1b5 > ambari-web/app/controllers/main/service/item.js 18a121f > ambari-web/app/controllers/wizard/step7_controller.js d43b69b > ambari-web/app/mixins/main/service/groups_mapping.js df2fabf > ambari-web/app/templates/main/service/info/delete_service_warning_popup.hbs > PRE-CREATION > ambari-web/test/controllers/main/service/item_test.js 082fbd9 > > Diff: https://reviews.apache.org/r/54254/diff/ > > > Testing > ------- > > 20020 tests complete (26 seconds) > 155 tests pending > > > Thanks, > > Andriy Babiichuk > >