Re: Review Request 54267: RU: wrong version exposed when Downgrade is going
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54267/ --- (Updated Dec. 2, 2016, 11:18 a.m.) Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs: AMBARI-19053 https://issues.apache.org/jira/browse/AMBARI-19053 Repository: ambari Description --- We are incorrectly using the current cluster_version as the from_version on the entity. For a downgrade, the from_ and to_ versions were the same. Also added downgrade_allowed=false when downgrading, as that is more logically correct. Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9034989 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 14e3d08 Diff: https://reviews.apache.org/r/54267/diff/ Testing (updated) --- Manual. Automated: Tests run: 4791, Failures: 0, Errors: 0, Skipped: 37 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 34:31.727s [INFO] Finished at: Fri Dec 02 10:56:52 EST 2016 [INFO] Final Memory: 37M/677M [INFO] Thanks, Nate Cole
Re: Review Request 54267: RU: wrong version exposed when Downgrade is going
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54267/#review157672 --- Ship it! Ship It! - Jonathan Hurley On Dec. 1, 2016, 4:45 p.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54267/ > --- > > (Updated Dec. 1, 2016, 4:45 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. > > > Bugs: AMBARI-19053 > https://issues.apache.org/jira/browse/AMBARI-19053 > > > Repository: ambari > > > Description > --- > > We are incorrectly using the current cluster_version as the from_version on > the entity. For a downgrade, the from_ and to_ versions were the same. Also > added downgrade_allowed=false when downgrading, as that is more logically > correct. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 9034989 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > 14e3d08 > > Diff: https://reviews.apache.org/r/54267/diff/ > > > Testing > --- > > Manual. Automated pending. > > > Thanks, > > Nate Cole > >
Re: Review Request 54267: RU: wrong version exposed when Downgrade is going
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54267/#review157666 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 1, 2016, 9:45 p.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54267/ > --- > > (Updated Dec. 1, 2016, 9:45 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. > > > Bugs: AMBARI-19053 > https://issues.apache.org/jira/browse/AMBARI-19053 > > > Repository: ambari > > > Description > --- > > We are incorrectly using the current cluster_version as the from_version on > the entity. For a downgrade, the from_ and to_ versions were the same. Also > added downgrade_allowed=false when downgrading, as that is more logically > correct. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 9034989 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > 14e3d08 > > Diff: https://reviews.apache.org/r/54267/diff/ > > > Testing > --- > > Manual. Automated pending. > > > Thanks, > > Nate Cole > >
