Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[Di Li]

> On Jan. 3, 2017, 4:09 p.m., Di Li wrote:
> > Ship It!
> 
> ping wang wrote:
> Hi Di, could you please help commit the code? Thanks!

Done. Please close this RB request.


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review160392
---


On Dec. 24, 2016, 7:12 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated Dec. 24, 2016, 7:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[ping wang]

> On 一月 11, 2017, 7:18 p.m., Alejandro Fernandez wrote:
> > Ship It!

Hi Alejandro, thank you very much for your approval!


- ping


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review161286
---


On 十二月 24, 2016, 7:12 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated 十二月 24, 2016, 7:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[ping wang]

> On 一月 3, 2017, 4:09 p.m., Di Li wrote:
> > Ship It!

Hi Di, could you please help commit the code? Thanks!


- ping


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review160392
---


On 十二月 24, 2016, 7:12 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated 十二月 24, 2016, 7:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review161286
---


Ship it!




Ship It!

- Alejandro Fernandez


On Dec. 24, 2016, 7:12 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated Dec. 24, 2016, 7:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[ping wang]

> On 一月 9, 2017, 7:26 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml,
> >  line 22
> > 
> >
> > If the user edited the config in HDP 2.3 or 2.4 from the original value 
> > of "*=spark-conf", should an upgrade to HDP 2.5 keep their edited value of 
> > forcibly change it to "*={{spark_conf_dir}}"?
> > 
> > If the answer is keep their current value, then no change needed.
> > If it must force it to "*={{spark_conf_dir}}", then this will also 
> > require a change in the EU/RU upgrade packs to set the config value.
> 
> ping wang wrote:
> Hi Alejandro,
> Thanks for comment.
> I think the upgrade will keep the user edited value. If so "no change 
> needed", does this mean for any existing property the default value defined 
> in common-service can not be changed anymore? 
> @dili, what's your view about this?
> 
> Thanks a lot!
> 
> Alejandro Fernandez wrote:
> Basically, if the user edited the value, does EU/RU need to forcibly 
> change it to "*={{spark_conf_dir}}"? Today, the default behavior is to 
> persist the user's modified value. If you want to forcibly change it to 
> "*={{spark_conf_dir}}", then it will need to modify the EU/RU upgrade packs 
> and config packs.
> 
> ping wang wrote:
> The default behavior makes sense. I do not want to forcibly change it to 
> "={{spark_conf_dir}}".  
> This fix can work for new fresh installed build with the new ambari 
> version that the fix into.  What's your view about this point?

Hi Alejandro, Hi Di,  
I think this is common issue. Any other similar JIRA has broken the current 
upgrade behaviour (persist user changes)? If users found their most properties 
were persisted but some were not, they will have confusion.
I think the default value changes do not impact current upgrade logic. 
By your rich experience what should be done if default value is not correct? 
Thanks for any guidance.


- ping


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review160940
---


On 十二月 24, 2016, 7:12 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated 十二月 24, 2016, 7:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[ping wang]

> On 一月 9, 2017, 7:26 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml,
> >  line 22
> > 
> >
> > If the user edited the config in HDP 2.3 or 2.4 from the original value 
> > of "*=spark-conf", should an upgrade to HDP 2.5 keep their edited value of 
> > forcibly change it to "*={{spark_conf_dir}}"?
> > 
> > If the answer is keep their current value, then no change needed.
> > If it must force it to "*={{spark_conf_dir}}", then this will also 
> > require a change in the EU/RU upgrade packs to set the config value.
> 
> ping wang wrote:
> Hi Alejandro,
> Thanks for comment.
> I think the upgrade will keep the user edited value. If so "no change 
> needed", does this mean for any existing property the default value defined 
> in common-service can not be changed anymore? 
> @dili, what's your view about this?
> 
> Thanks a lot!
> 
> Alejandro Fernandez wrote:
> Basically, if the user edited the value, does EU/RU need to forcibly 
> change it to "*={{spark_conf_dir}}"? Today, the default behavior is to 
> persist the user's modified value. If you want to forcibly change it to 
> "*={{spark_conf_dir}}", then it will need to modify the EU/RU upgrade packs 
> and config packs.

The default behavior makes sense. I do not want to forcibly change it to 
"={{spark_conf_dir}}".  
This fix can work for new fresh installed build with the new ambari version 
that the fix into.  What's your view about this point?


- ping


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review160940
---


On 十二月 24, 2016, 7:12 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated 十二月 24, 2016, 7:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[Alejandro Fernandez]

> On Jan. 9, 2017, 7:26 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml,
> >  line 22
> > 
> >
> > If the user edited the config in HDP 2.3 or 2.4 from the original value 
> > of "*=spark-conf", should an upgrade to HDP 2.5 keep their edited value of 
> > forcibly change it to "*={{spark_conf_dir}}"?
> > 
> > If the answer is keep their current value, then no change needed.
> > If it must force it to "*={{spark_conf_dir}}", then this will also 
> > require a change in the EU/RU upgrade packs to set the config value.
> 
> ping wang wrote:
> Hi Alejandro,
> Thanks for comment.
> I think the upgrade will keep the user edited value. If so "no change 
> needed", does this mean for any existing property the default value defined 
> in common-service can not be changed anymore? 
> @dili, what's your view about this?
> 
> Thanks a lot!

Basically, if the user edited the value, does EU/RU need to forcibly change it 
to "*={{spark_conf_dir}}"? Today, the default behavior is to persist the user's 
modified value. If you want to forcibly change it to "*={{spark_conf_dir}}", 
then it will need to modify the EU/RU upgrade packs and config packs.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review160940
---


On Dec. 24, 2016, 7:12 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated Dec. 24, 2016, 7:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[ping wang]

> On 一月 9, 2017, 7:26 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml,
> >  line 22
> > 
> >
> > If the user edited the config in HDP 2.3 or 2.4 from the original value 
> > of "*=spark-conf", should an upgrade to HDP 2.5 keep their edited value of 
> > forcibly change it to "*={{spark_conf_dir}}"?
> > 
> > If the answer is keep their current value, then no change needed.
> > If it must force it to "*={{spark_conf_dir}}", then this will also 
> > require a change in the EU/RU upgrade packs to set the config value.

Hi Alejandro,
Thanks for comment.
I think the upgrade will keep the user edited value. If so "no change needed", 
does this mean for any existing property the default value defined in 
common-service can not be changed anymore? 
@dili, what's your view about this?

Thanks a lot!


- ping


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review160940
---


On 十二月 24, 2016, 7:12 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated 十二月 24, 2016, 7:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review160940
---




ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
 (line 22)


If the user edited the config in HDP 2.3 or 2.4 from the original value of 
"*=spark-conf", should an upgrade to HDP 2.5 keep their edited value of 
forcibly change it to "*={{spark_conf_dir}}"?

If the answer is keep their current value, then no change needed.
If it must force it to "*={{spark_conf_dir}}", then this will also require 
a change in the EU/RU upgrade packs to set the config value.


- Alejandro Fernandez


On Dec. 24, 2016, 7:12 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated Dec. 24, 2016, 7:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[ping wang]

> On 一月 6, 2017, 6:42 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml,
> >  line 22
> > 
> >
> > HDP 2.5 and higher use Oozie 4.2.0.2.5
> > What should happen during EU/RU to HDP 2.5 or 2.6?
> > 
> > Should this config value change?

Hi Alejandro,
Thanks for comment. 
By the ambari upgrade logic: any properties that the user modified in the base 
stack will be persisted even if the new stack has a different value. 
I think the default value in the base stack will be persisted as well. If new 
stack has a different default value, user can pick it up by clicking the Set 
Recommended button besides the property. So for users already have HDP 2.5 
installed, the default value is still the old one and will not be changed in 
RU/EU.
If users do fresh install for HDP 2.5 or higher with newer ambari code, they 
will get the updated default value.

The fix is to make the property with valid value and can be used directly, 
orelse users have to update it. 
Please let me know if any problems. Thanks a lot!


- ping


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review160741
---


On 十二月 24, 2016, 7:12 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated 十二月 24, 2016, 7:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review160741
---




ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
 (line 22)


HDP 2.5 and higher use Oozie 4.2.0.2.5
What should happen during EU/RU to HDP 2.5 or 2.6?

Should this config value change?


- Alejandro Fernandez


On Dec. 24, 2016, 7:12 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated Dec. 24, 2016, 7:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review160392
---


Ship it!




Ship It!

- Di Li


On Dec. 24, 2016, 7:12 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated Dec. 24, 2016, 7:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[ping wang]

> On 十二月 22, 2016, 4:04 p.m., Di Li wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml,
> >  line 22
> > 
> >
> > Why not use spark_conf placeholder and calculate the full patch in one 
> > shot, than having to calculate the spark home then concatenate the /conf

I thought spark_home is more common than spark_conf. But yes, it will be better 
to directly show spark_conf. 
Upload the new diff file. Thanks Di.


- ping


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review159973
---


On 十二月 23, 2016, 11:58 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated 十二月 23, 2016, 11:58 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[ping wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/
---

(Updated 十二月 24, 2016, 7:12 a.m.)


Review request for Ambari, Alejandro Fernandez and Di Li.


Bugs: AMBARI-19250
https://issues.apache.org/jira/browse/AMBARI-19250


Repository: ambari


Description
---

Change default Spark configuration property in Oozie configuration settings to 
valid value


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 a2d725c 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
 cdb6972 

Diff: https://reviews.apache.org/r/54970/diff/


Testing
---

I have tested the fix by:
1) copy the changed files into ambari host and restart ambari-server
2) delete oozie service and then add it back
3) check the property value is point to the spark configuration directory 
correctly


Thanks,

ping wang

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review160089
---




ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 (line 70)


I don't think spark_home is being used by Oozie Python script. Can this be 
shorten to spark_conf = format("{stack_root}/current/spark-client/conf")


- Di Li


On Dec. 23, 2016, 11:58 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated Dec. 23, 2016, 11:58 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[ping wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/
---

(Updated 十二月 23, 2016, 11:58 a.m.)


Review request for Ambari, Alejandro Fernandez and Di Li.


Bugs: AMBARI-19250
https://issues.apache.org/jira/browse/AMBARI-19250


Repository: ambari


Description
---

Change default Spark configuration property in Oozie configuration settings to 
valid value


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 a2d725c 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
 cdb6972 

Diff: https://reviews.apache.org/r/54970/diff/


Testing
---

I have tested the fix by:
1) copy the changed files into ambari host and restart ambari-server
2) delete oozie service and then add it back
3) check the property value is point to the spark configuration directory 
correctly


Thanks,

ping wang

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review159973
---




ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
 (line 22)


Why not use spark_conf placeholder and calculate the full patch in one 
shot, than having to calculate the spark home then concatenate the /conf


- Di Li


On Dec. 22, 2016, 9:48 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated Dec. 22, 2016, 9:48 a.m.)
> 
> 
> Review request for Ambari and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review159972
---



Hello Ping,

Please also add Alejandro Fernandez (@afernandez)for the review.

- Di Li


On Dec. 22, 2016, 9:48 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated Dec. 22, 2016, 9:48 a.m.)
> 
> 
> Review request for Ambari and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>