Re: Review Request 55308: AMBARI-19414. Cannot install Accumulo via blueprint with default settings

2017-01-13 Thread Sandor Magyari

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55308/#review161541
---


Ship it!




Ship It!

- Sandor Magyari


On Jan. 11, 2017, 9:28 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55308/
> ---
> 
> (Updated Jan. 11, 2017, 9:28 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Myroslav Papirkovskyy, Sandor 
> Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19414
> https://issues.apache.org/jira/browse/AMBARI-19414
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Avoid using `status_params` in `__init__`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
>  f9d5fce3fa864a6a987b1c007fd88f069dd8a02f 
> 
> Diff: https://reviews.apache.org/r/55308/diff/
> 
> 
> Testing
> ---
> 
> Manual test:
>  * create cluster with Accumulo via blueprint
>  * verify install and start are successful
>  * verify PID is logged:
> 
> ```
> $ grep -l 'bin/accumulo' out*txt | xargs tail -n 1
> ==> output-17.txt <==
> 2017-01-07 21:29:08,656 - Component has started with pid(s): 18166
> 
> ==> output-19.txt <==
> 2017-01-07 21:29:26,636 - Component has started with pid(s): 18568
> 
> ==> output-20.txt <==
> 2017-01-07 21:29:36,031 - Component has started with pid(s): 18792
> 
> ==> output-21.txt <==
> 2017-01-07 21:29:37,691 - Component has started with pid(s): 18893
> 
> ==> output-22.txt <==
> 2017-01-07 21:30:12,982 - Component has started with pid(s): 19816
> ```
> 
> Ran existing unit tests:
> 
> ```
> Total run:1157
> Total errors:0
> Total failures:0
> OK
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>



Re: Review Request 55308: AMBARI-19414. Cannot install Accumulo via blueprint with default settings

2017-01-13 Thread Laszlo Puskas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55308/#review161540
---


Ship it!




Ship It!

- Laszlo Puskas


On Jan. 11, 2017, 9:28 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55308/
> ---
> 
> (Updated Jan. 11, 2017, 9:28 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Myroslav Papirkovskyy, Sandor 
> Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19414
> https://issues.apache.org/jira/browse/AMBARI-19414
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Avoid using `status_params` in `__init__`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
>  f9d5fce3fa864a6a987b1c007fd88f069dd8a02f 
> 
> Diff: https://reviews.apache.org/r/55308/diff/
> 
> 
> Testing
> ---
> 
> Manual test:
>  * create cluster with Accumulo via blueprint
>  * verify install and start are successful
>  * verify PID is logged:
> 
> ```
> $ grep -l 'bin/accumulo' out*txt | xargs tail -n 1
> ==> output-17.txt <==
> 2017-01-07 21:29:08,656 - Component has started with pid(s): 18166
> 
> ==> output-19.txt <==
> 2017-01-07 21:29:26,636 - Component has started with pid(s): 18568
> 
> ==> output-20.txt <==
> 2017-01-07 21:29:36,031 - Component has started with pid(s): 18792
> 
> ==> output-21.txt <==
> 2017-01-07 21:29:37,691 - Component has started with pid(s): 18893
> 
> ==> output-22.txt <==
> 2017-01-07 21:30:12,982 - Component has started with pid(s): 19816
> ```
> 
> Ran existing unit tests:
> 
> ```
> Total run:1157
> Total errors:0
> Total failures:0
> OK
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>



Re: Review Request 55308: AMBARI-19414. Cannot install Accumulo via blueprint with default settings

2017-01-08 Thread Sebastian Toader

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55308/#review160832
---


Ship it!




Ship It!

- Sebastian Toader


On Jan. 7, 2017, 10:34 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55308/
> ---
> 
> (Updated Jan. 7, 2017, 10:34 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19414
> https://issues.apache.org/jira/browse/AMBARI-19414
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Avoid using `status_params` in `__init__`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
>  f9d5fce3fa864a6a987b1c007fd88f069dd8a02f 
> 
> Diff: https://reviews.apache.org/r/55308/diff/
> 
> 
> Testing
> ---
> 
> Manual test:
>  * create cluster with Accumulo via blueprint
>  * verify install and start are successful
>  * verify PID is logged:
> 
> ```
> $ grep -l 'bin/accumulo' out*txt | xargs tail -n 1
> ==> output-17.txt <==
> 2017-01-07 21:29:08,656 - Component has started with pid(s): 18166
> 
> ==> output-19.txt <==
> 2017-01-07 21:29:26,636 - Component has started with pid(s): 18568
> 
> ==> output-20.txt <==
> 2017-01-07 21:29:36,031 - Component has started with pid(s): 18792
> 
> ==> output-21.txt <==
> 2017-01-07 21:29:37,691 - Component has started with pid(s): 18893
> 
> ==> output-22.txt <==
> 2017-01-07 21:30:12,982 - Component has started with pid(s): 19816
> ```
> 
> Ran existing unit tests:
> 
> ```
> Total run:1157
> Total errors:0
> Total failures:0
> OK
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>