Re: Review Request 55444: AMBARI-19478: Need to handle unsupported configurations gracefully in workflow actions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55444/#review161497 --- Ship it! Ship It! - Gaurav Nagar On Jan. 12, 2017, 6:49 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55444/ > --- > > (Updated Jan. 12, 2017, 6:49 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Pallav Kulshreshtha. > > > Bugs: AMBARI-19478 > https://issues.apache.org/jira/browse/AMBARI-19478 > > > Repository: ambari > > > Description > --- > > Scenario - During import Workflow. > If any of the action contains configuration that the workflow designer does > not understand(eg. streaming in map-reduce), the action editor should warn > the users and show a text area for manually editing the configuration > The configuration should be taken into consideration while the final workflow > xml is generated. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/sla-info.js > 7390205 > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js > 8ee5a0a > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js > 99d96ac > > contrib/views/wfmanager/src/main/resources/ui/app/domain/custom-mapping-handler.js > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js > d4d8f50 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js > 527badf > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js > b9e4307 > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less dcf2905 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs > 069c052 > > Diff: https://reviews.apache.org/r/55444/diff/ > > > Testing > --- > > Manual > > > Thanks, > > Padma Priya N > >
Re: Review Request 55444: AMBARI-19478: Need to handle unsupported configurations gracefully in workflow actions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55444/#review161359 --- Ship it! Ship It! - Nitiraj Rathore On Jan. 12, 2017, 6:49 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55444/ > --- > > (Updated Jan. 12, 2017, 6:49 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Pallav Kulshreshtha. > > > Bugs: AMBARI-19478 > https://issues.apache.org/jira/browse/AMBARI-19478 > > > Repository: ambari > > > Description > --- > > Scenario - During import Workflow. > If any of the action contains configuration that the workflow designer does > not understand(eg. streaming in map-reduce), the action editor should warn > the users and show a text area for manually editing the configuration > The configuration should be taken into consideration while the final workflow > xml is generated. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/sla-info.js > 7390205 > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js > 8ee5a0a > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js > 99d96ac > > contrib/views/wfmanager/src/main/resources/ui/app/domain/custom-mapping-handler.js > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js > d4d8f50 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js > 527badf > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js > b9e4307 > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less dcf2905 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs > 069c052 > > Diff: https://reviews.apache.org/r/55444/diff/ > > > Testing > --- > > Manual > > > Thanks, > > Padma Priya N > >
