Re: Review Request 55478: Add log rotation settings - handle upgrade scenario

2017-01-16 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55478/ --- (Updated Jan. 16, 2017, 10:16 p.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 55478: Add log rotation settings - handle upgrade scenario

2017-01-16 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55478/#review161728 --- Fix it, then Ship it! ambari-server/src/main/resources/stacks/

Re: Review Request 55478: Add log rotation settings - handle upgrade scenario

2017-01-16 Thread Jonathan Hurley
> On Jan. 13, 2017, 8:56 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java, > > line 226 > > > > > > I don't think you want

Re: Review Request 55478: Add log rotation settings - handle upgrade scenario

2017-01-13 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55478/ --- (Updated Jan. 14, 2017, 5:06 a.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 55478: Add log rotation settings - handle upgrade scenario

2017-01-13 Thread Madhuvanthi Radhakrishnan
> On Jan. 13, 2017, 1:56 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java, > > line 226 > > > > > > I don't think you want

Re: Review Request 55478: Add log rotation settings - handle upgrade scenario

2017-01-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55478/#review161523 --- ambari-server/src/main/java/org/apache/ambari/server/state/stack/

Re: Review Request 55478: Add log rotation settings - handle upgrade scenario

2017-01-13 Thread Jonathan Hurley
> On Jan. 12, 2017, 8:20 p.m., Oliver Szabo wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml, > > line 173 > > > > > > INFRA_SOLR is not part of the HDP upgrade (instead of that

Re: Review Request 55478: Add log rotation settings - handle upgrade scenario

2017-01-12 Thread Aravindan Vijayan
> On Jan. 13, 2017, 1:20 a.m., Oliver Szabo wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml, > > line 173 > > > > > > INFRA_SOLR is not part of the HDP upgrade (instead of that

Re: Review Request 55478: Add log rotation settings - handle upgrade scenario

2017-01-12 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55478/#review161474 --- ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-u

Re: Review Request 55478: Add log rotation settings - handle upgrade scenario

2017-01-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55478/#review161456 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a