Re: Review Request 55501: Hive View 2.0: Saving worksheet as saved query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55501/#review161687 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 14, 2017, 3:35 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55501/ > --- > > (Updated Jan. 14, 2017, 3:35 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19522 > https://issues.apache.org/jira/browse/AMBARI-19522 > > > Repository: ambari > > > Description > --- > > Saving worksheet as saved query and Export query results featutes > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/adapters/job.js 8ccd7ad > contrib/views/hive20/src/main/resources/ui/app/adapters/saved-query.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js > b42c495 > > contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js > 17df66d > contrib/views/hive20/src/main/resources/ui/app/components/save-hdfs.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/models/saved-query.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js d254ed1 > contrib/views/hive20/src/main/resources/ui/app/routes/queries.js 2346345 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 5eac78a > contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js > 8719170 > contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 4928e5c > contrib/views/hive20/src/main/resources/ui/app/services/query.js 5a2f62d > contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 6bf8e5a > > contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs > 441352e > > contrib/views/hive20/src/main/resources/ui/app/templates/components/save-hdfs.hbs > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 371f404 > contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs > b776fd2 > > Diff: https://reviews.apache.org/r/55501/diff/ > > > Testing > --- > > manually tested > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 55501: Hive View 2.0: Saving worksheet as saved query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55501/#review161683 --- Ship it! Ship It! - Nitiraj Rathore On Jan. 14, 2017, 3:35 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55501/ > --- > > (Updated Jan. 14, 2017, 3:35 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19522 > https://issues.apache.org/jira/browse/AMBARI-19522 > > > Repository: ambari > > > Description > --- > > Saving worksheet as saved query and Export query results featutes > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/adapters/job.js 8ccd7ad > contrib/views/hive20/src/main/resources/ui/app/adapters/saved-query.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js > b42c495 > > contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js > 17df66d > contrib/views/hive20/src/main/resources/ui/app/components/save-hdfs.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/models/saved-query.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js d254ed1 > contrib/views/hive20/src/main/resources/ui/app/routes/queries.js 2346345 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 5eac78a > contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js > 8719170 > contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 4928e5c > contrib/views/hive20/src/main/resources/ui/app/services/query.js 5a2f62d > contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 6bf8e5a > > contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs > 441352e > > contrib/views/hive20/src/main/resources/ui/app/templates/components/save-hdfs.hbs > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 371f404 > contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs > b776fd2 > > Diff: https://reviews.apache.org/r/55501/diff/ > > > Testing > --- > > manually tested > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 55501: Hive View 2.0: Saving worksheet as saved query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55501/ --- (Updated Jan. 14, 2017, 3:35 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary. Bugs: AMBARI-19522 https://issues.apache.org/jira/browse/AMBARI-19522 Repository: ambari Description --- Saving worksheet as saved query and Export query results featutes Diffs (updated) - contrib/views/hive20/src/main/resources/ui/app/adapters/job.js 8ccd7ad contrib/views/hive20/src/main/resources/ui/app/adapters/saved-query.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js b42c495 contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js 17df66d contrib/views/hive20/src/main/resources/ui/app/components/save-hdfs.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/models/saved-query.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js d254ed1 contrib/views/hive20/src/main/resources/ui/app/routes/queries.js 2346345 contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 5eac78a contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js 8719170 contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 4928e5c contrib/views/hive20/src/main/resources/ui/app/services/query.js 5a2f62d contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 6bf8e5a contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs 441352e contrib/views/hive20/src/main/resources/ui/app/templates/components/save-hdfs.hbs PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 371f404 contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs b776fd2 Diff: https://reviews.apache.org/r/55501/diff/ Testing --- manually tested Thanks, Pallav Kulshreshtha
Re: Review Request 55501: Hive View 2.0: Saving worksheet as saved query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55501/ --- (Updated Jan. 13, 2017, 1:42 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary. Bugs: AMBARI-19522 https://issues.apache.org/jira/browse/AMBARI-19522 Repository: ambari Description --- Saving worksheet as saved query and Export query results featutes Diffs (updated) - contrib/views/hive20/src/main/resources/ui/app/adapters/job.js 8ccd7ad contrib/views/hive20/src/main/resources/ui/app/adapters/saved-query.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js b42c495 contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js 17df66d contrib/views/hive20/src/main/resources/ui/app/components/save-hdfs.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/models/saved-query.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js d254ed1 contrib/views/hive20/src/main/resources/ui/app/routes/queries.js 2346345 contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 5eac78a contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js 8719170 contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 4928e5c contrib/views/hive20/src/main/resources/ui/app/services/query.js 5a2f62d contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 6bf8e5a contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs 441352e contrib/views/hive20/src/main/resources/ui/app/templates/components/save-hdfs.hbs PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 371f404 contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs b776fd2 Diff: https://reviews.apache.org/r/55501/diff/ Testing --- manually tested Thanks, Pallav Kulshreshtha
