Re: Review Request 56647: AMBARI-20000.Workflow Manager optimising finding nodes

2017-02-14 Thread Gaurav Nagar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56647/#review165495
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 14, 2017, 9:13 a.m., belliraj hb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56647/
> ---
> 
> (Updated Feb. 14, 2017, 9:13 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-2
> https://issues.apache.org/jira/browse/AMBARI-2
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Find node is optimized using cytoscape methods. object is serialized and 
> deserialized using JSOG rather than json.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-add-branch.js
>  65d097414b 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-config.js
>  ad664d7709 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> a5536af377 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js
>  8202c6d484 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js 
> 92820f9b42 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 
> b918d70200 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js
>  656df4bb73 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 
> 02842c5d41 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs
>  0810f64285 
>   contrib/views/wfmanager/src/main/resources/ui/bower.json b66a190fcc 
>   contrib/views/wfmanager/src/main/resources/ui/ember-cli-build.js bf48e9c911 
> 
> Diff: https://reviews.apache.org/r/56647/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> belliraj hb
> 
>



Re: Review Request 56647: AMBARI-20000.Workflow Manager optimising finding nodes

2017-02-14 Thread Pallav Kulshreshtha

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56647/#review165479
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Feb. 14, 2017, 9:13 a.m., belliraj hb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56647/
> ---
> 
> (Updated Feb. 14, 2017, 9:13 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-2
> https://issues.apache.org/jira/browse/AMBARI-2
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Find node is optimized using cytoscape methods. object is serialized and 
> deserialized using JSOG rather than json.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-add-branch.js
>  65d097414b 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-config.js
>  ad664d7709 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> a5536af377 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js
>  8202c6d484 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js 
> 92820f9b42 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 
> b918d70200 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js
>  656df4bb73 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 
> 02842c5d41 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs
>  0810f64285 
>   contrib/views/wfmanager/src/main/resources/ui/bower.json b66a190fcc 
>   contrib/views/wfmanager/src/main/resources/ui/ember-cli-build.js bf48e9c911 
> 
> Diff: https://reviews.apache.org/r/56647/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> belliraj hb
> 
>