Re: Review Request 56745: Workflow Manager workflow rendering is broken in designer page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56745/#review165831 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 16, 2017, 10:58 a.m., belliraj hb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56745/ > --- > > (Updated Feb. 16, 2017, 10:58 a.m.) > > > Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav > Kulshreshtha. > > > Bugs: AMBARI-20040 > https://issues.apache.org/jira/browse/AMBARI-20040 > > > Repository: ambari > > > Description > --- > > Error nodes are now displayed if transition points to kill node on an > non-error condition. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js > 4194d5e612 > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js > 5a074dfdac > > contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-data-node-name.js > 5282544a93 > > Diff: https://reviews.apache.org/r/56745/diff/ > > > Testing > --- > > Manual testing > > > Thanks, > > belliraj hb > >
Re: Review Request 56745: Workflow Manager workflow rendering is broken in designer page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56745/#review165827 --- Ship it! Ship It! - Gaurav Nagar On Feb. 16, 2017, 10:58 a.m., belliraj hb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56745/ > --- > > (Updated Feb. 16, 2017, 10:58 a.m.) > > > Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav > Kulshreshtha. > > > Bugs: AMBARI-20040 > https://issues.apache.org/jira/browse/AMBARI-20040 > > > Repository: ambari > > > Description > --- > > Error nodes are now displayed if transition points to kill node on an > non-error condition. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js > 4194d5e612 > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js > 5a074dfdac > > contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-data-node-name.js > 5282544a93 > > Diff: https://reviews.apache.org/r/56745/diff/ > > > Testing > --- > > Manual testing > > > Thanks, > > belliraj hb > >
