Re: Review Request 61616: AMBARI-21714. Intermittent unit test failure in ExecutionCommandWrapperTest

2017-08-14 Thread Nate Cole

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61616/#review182862
---


Ship it!




Ship It!

- Nate Cole


On Aug. 14, 2017, 7:09 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61616/
> ---
> 
> (Updated Aug. 14, 2017, 7:09 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21714
> https://issues.apache.org/jira/browse/AMBARI-21714
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Move service addition to common setup.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java
>  52d54aa9e58d8bd3593095df3e87b70b3b2ffba8 
> 
> 
> Diff: https://reviews.apache.org/r/61616/diff/1/
> 
> 
> Testing
> ---
> 
> All tests:
> 
> ```
> Running org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.814 sec - 
> in org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
> ```
> 
> Without `testGetExecutionCommand()`:
> 
> ```
> Running org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.456 sec - 
> in org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>



Re: Review Request 61616: AMBARI-21714. Intermittent unit test failure in ExecutionCommandWrapperTest

2017-08-14 Thread Jonathan Hurley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61616/#review182860
---


Ship it!




Ship It!

- Jonathan Hurley


On Aug. 14, 2017, 7:09 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61616/
> ---
> 
> (Updated Aug. 14, 2017, 7:09 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21714
> https://issues.apache.org/jira/browse/AMBARI-21714
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Move service addition to common setup.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java
>  52d54aa9e58d8bd3593095df3e87b70b3b2ffba8 
> 
> 
> Diff: https://reviews.apache.org/r/61616/diff/1/
> 
> 
> Testing
> ---
> 
> All tests:
> 
> ```
> Running org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.814 sec - 
> in org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
> ```
> 
> Without `testGetExecutionCommand()`:
> 
> ```
> Running org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.456 sec - 
> in org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>



Re: Review Request 61616: AMBARI-21714. Intermittent unit test failure in ExecutionCommandWrapperTest

2017-08-14 Thread Laszlo Puskas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61616/#review182854
---


Ship it!




Ship It!

- Laszlo Puskas


On Aug. 14, 2017, 11:09 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61616/
> ---
> 
> (Updated Aug. 14, 2017, 11:09 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21714
> https://issues.apache.org/jira/browse/AMBARI-21714
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Move service addition to common setup.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java
>  52d54aa9e58d8bd3593095df3e87b70b3b2ffba8 
> 
> 
> Diff: https://reviews.apache.org/r/61616/diff/1/
> 
> 
> Testing
> ---
> 
> All tests:
> 
> ```
> Running org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.814 sec - 
> in org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
> ```
> 
> Without `testGetExecutionCommand()`:
> 
> ```
> Running org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.456 sec - 
> in org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>



Re: Review Request 61616: AMBARI-21714. Intermittent unit test failure in ExecutionCommandWrapperTest

2017-08-14 Thread Sebastian Toader

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61616/#review182853
---


Ship it!




Ship It!

- Sebastian Toader


On Aug. 14, 2017, 1:09 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61616/
> ---
> 
> (Updated Aug. 14, 2017, 1:09 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21714
> https://issues.apache.org/jira/browse/AMBARI-21714
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Move service addition to common setup.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java
>  52d54aa9e58d8bd3593095df3e87b70b3b2ffba8 
> 
> 
> Diff: https://reviews.apache.org/r/61616/diff/1/
> 
> 
> Testing
> ---
> 
> All tests:
> 
> ```
> Running org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.814 sec - 
> in org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
> ```
> 
> Without `testGetExecutionCommand()`:
> 
> ```
> Running org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.456 sec - 
> in org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>