Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

[Jonathan Hurley]

> On Sept. 12, 2017, 12:02 p.m., Dmytro Grinenko wrote:
> > ambari-server/src/test/python/stacks/utils/RMFTestCase.py
> > Line 142 (original), 142 (patched)
> > 
> >
> > i like this way more than that big "stairs"

Eventually, we'd be off the page, so I figured I'd just fix it now...


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62226/#review185206
---


On Sept. 12, 2017, 11:50 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62226/
> ---
> 
> (Updated Sept. 12, 2017, 11:50 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21931
> https://issues.apache.org/jira/browse/AMBARI-21931
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are several "INVALID" types listed in the stack_packages.json file. 
> These were placeholders that need to be updated with the packages exposed by 
> the stack-select tool. 
> 
> {code}
> ...
> "HDFS_CLIENT": {
>   "STACK-SELECT-PACKAGE": "hadoop-client",
>   "INSTALL": [
> "hadoop-client"
>   ],
>   "PATCH": [
> "INVALID"
>   ],
>   "STANDARD": [
> "hadoop-client"
>   ]
> },
> ...
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  eac1bef13c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  6a2d58d24c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  704fb54293 
>   ambari-server/src/test/python/TestStackSelect.py 3d4e5b6a43 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 0341092b69 
> 
> 
> Diff: https://reviews.apache.org/r/62226/diff/4/
> 
> 
> Testing
> ---
> 
> --
> Total run:1191
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 58.379 s
> [INFO] Finished at: 2017-09-11T16:25:26-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62226/#review185207
---


Ship it!




Ship It!

- Dmytro Grinenko


On Sept. 12, 2017, 3:50 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62226/
> ---
> 
> (Updated Sept. 12, 2017, 3:50 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21931
> https://issues.apache.org/jira/browse/AMBARI-21931
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are several "INVALID" types listed in the stack_packages.json file. 
> These were placeholders that need to be updated with the packages exposed by 
> the stack-select tool. 
> 
> {code}
> ...
> "HDFS_CLIENT": {
>   "STACK-SELECT-PACKAGE": "hadoop-client",
>   "INSTALL": [
> "hadoop-client"
>   ],
>   "PATCH": [
> "INVALID"
>   ],
>   "STANDARD": [
> "hadoop-client"
>   ]
> },
> ...
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  eac1bef13c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  6a2d58d24c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  704fb54293 
>   ambari-server/src/test/python/TestStackSelect.py 3d4e5b6a43 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 0341092b69 
> 
> 
> Diff: https://reviews.apache.org/r/62226/diff/4/
> 
> 
> Testing
> ---
> 
> --
> Total run:1191
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 58.379 s
> [INFO] Finished at: 2017-09-11T16:25:26-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62226/#review185206
---




ambari-server/src/test/python/stacks/utils/RMFTestCase.py
Line 142 (original), 142 (patched)


i like this way more than that big "stairs"


- Dmytro Grinenko


On Sept. 12, 2017, 3:50 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62226/
> ---
> 
> (Updated Sept. 12, 2017, 3:50 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21931
> https://issues.apache.org/jira/browse/AMBARI-21931
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are several "INVALID" types listed in the stack_packages.json file. 
> These were placeholders that need to be updated with the packages exposed by 
> the stack-select tool. 
> 
> {code}
> ...
> "HDFS_CLIENT": {
>   "STACK-SELECT-PACKAGE": "hadoop-client",
>   "INSTALL": [
> "hadoop-client"
>   ],
>   "PATCH": [
> "INVALID"
>   ],
>   "STANDARD": [
> "hadoop-client"
>   ]
> },
> ...
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  eac1bef13c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  6a2d58d24c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  704fb54293 
>   ambari-server/src/test/python/TestStackSelect.py 3d4e5b6a43 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 0341092b69 
> 
> 
> Diff: https://reviews.apache.org/r/62226/diff/4/
> 
> 
> Testing
> ---
> 
> --
> Total run:1191
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 58.379 s
> [INFO] Finished at: 2017-09-11T16:25:26-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62226/
---

(Updated Sept. 12, 2017, 11:50 a.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.


Bugs: AMBARI-21931
https://issues.apache.org/jira/browse/AMBARI-21931


Repository: ambari


Description
---

There are several "INVALID" types listed in the stack_packages.json file. These 
were placeholders that need to be updated with the packages exposed by the 
stack-select tool. 

{code}
...
"HDFS_CLIENT": {
  "STACK-SELECT-PACKAGE": "hadoop-client",
  "INSTALL": [
"hadoop-client"
  ],
  "PATCH": [
"INVALID"
  ],
  "STANDARD": [
"hadoop-client"
  ]
},
...
{code}


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
 eac1bef13c 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
 6a2d58d24c 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
 704fb54293 
  ambari-server/src/test/python/TestStackSelect.py 3d4e5b6a43 
  ambari-server/src/test/python/stacks/utils/RMFTestCase.py 0341092b69 


Diff: https://reviews.apache.org/r/62226/diff/4/

Changes: https://reviews.apache.org/r/62226/diff/3-4/


Testing
---

--
Total run:1191
Total errors:0
Total failures:0
OK
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 58.379 s
[INFO] Finished at: 2017-09-11T16:25:26-04:00
[INFO] Final Memory: 21M/619M
[INFO] 


Thanks,

Jonathan Hurley

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

[Jonathan Hurley]

> On Sept. 12, 2017, 11:42 a.m., Dmytro Grinenko wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
> > Lines 126 (patched)
> > 
> >
> > if not supported_packages:
> >supported_packages = get_supported_packages()
> >
> >
> >  else no sence on this
> 
> Dmytro Grinenko wrote:
> sense*

Ugh - stupid patch didn't have staged changes ... 1 sec.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62226/#review185198
---


On Sept. 12, 2017, 10:21 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62226/
> ---
> 
> (Updated Sept. 12, 2017, 10:21 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21931
> https://issues.apache.org/jira/browse/AMBARI-21931
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are several "INVALID" types listed in the stack_packages.json file. 
> These were placeholders that need to be updated with the packages exposed by 
> the stack-select tool. 
> 
> {code}
> ...
> "HDFS_CLIENT": {
>   "STACK-SELECT-PACKAGE": "hadoop-client",
>   "INSTALL": [
> "hadoop-client"
>   ],
>   "PATCH": [
> "INVALID"
>   ],
>   "STANDARD": [
> "hadoop-client"
>   ]
> },
> ...
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  eac1bef13c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  704fb54293 
>   ambari-server/src/test/python/TestStackSelect.py 3d4e5b6a43 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 0341092b69 
> 
> 
> Diff: https://reviews.apache.org/r/62226/diff/3/
> 
> 
> Testing
> ---
> 
> --
> Total run:1191
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 58.379 s
> [INFO] Finished at: 2017-09-11T16:25:26-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

[Dmytro Grinenko]

> On Sept. 12, 2017, 3:42 p.m., Dmytro Grinenko wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
> > Lines 126 (patched)
> > 
> >
> > if not supported_packages:
> >supported_packages = get_supported_packages()
> >
> >
> >  else no sence on this

sense*


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62226/#review185198
---


On Sept. 12, 2017, 2:21 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62226/
> ---
> 
> (Updated Sept. 12, 2017, 2:21 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21931
> https://issues.apache.org/jira/browse/AMBARI-21931
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are several "INVALID" types listed in the stack_packages.json file. 
> These were placeholders that need to be updated with the packages exposed by 
> the stack-select tool. 
> 
> {code}
> ...
> "HDFS_CLIENT": {
>   "STACK-SELECT-PACKAGE": "hadoop-client",
>   "INSTALL": [
> "hadoop-client"
>   ],
>   "PATCH": [
> "INVALID"
>   ],
>   "STANDARD": [
> "hadoop-client"
>   ]
> },
> ...
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  eac1bef13c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  704fb54293 
>   ambari-server/src/test/python/TestStackSelect.py 3d4e5b6a43 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 0341092b69 
> 
> 
> Diff: https://reviews.apache.org/r/62226/diff/3/
> 
> 
> Testing
> ---
> 
> --
> Total run:1191
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 58.379 s
> [INFO] Finished at: 2017-09-11T16:25:26-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62226/#review185198
---




ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
Lines 126 (patched)


if not supported_packages:
   supported_packages = get_supported_packages()
   
   
 else no sence on this


- Dmytro Grinenko


On Sept. 12, 2017, 2:21 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62226/
> ---
> 
> (Updated Sept. 12, 2017, 2:21 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21931
> https://issues.apache.org/jira/browse/AMBARI-21931
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are several "INVALID" types listed in the stack_packages.json file. 
> These were placeholders that need to be updated with the packages exposed by 
> the stack-select tool. 
> 
> {code}
> ...
> "HDFS_CLIENT": {
>   "STACK-SELECT-PACKAGE": "hadoop-client",
>   "INSTALL": [
> "hadoop-client"
>   ],
>   "PATCH": [
> "INVALID"
>   ],
>   "STANDARD": [
> "hadoop-client"
>   ]
> },
> ...
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  eac1bef13c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  704fb54293 
>   ambari-server/src/test/python/TestStackSelect.py 3d4e5b6a43 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 0341092b69 
> 
> 
> Diff: https://reviews.apache.org/r/62226/diff/3/
> 
> 
> Testing
> ---
> 
> --
> Total run:1191
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 58.379 s
> [INFO] Finished at: 2017-09-11T16:25:26-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62226/#review185197
---


Ship it!




Ship It!

- Dmytro Grinenko


On Sept. 12, 2017, 2:21 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62226/
> ---
> 
> (Updated Sept. 12, 2017, 2:21 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21931
> https://issues.apache.org/jira/browse/AMBARI-21931
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are several "INVALID" types listed in the stack_packages.json file. 
> These were placeholders that need to be updated with the packages exposed by 
> the stack-select tool. 
> 
> {code}
> ...
> "HDFS_CLIENT": {
>   "STACK-SELECT-PACKAGE": "hadoop-client",
>   "INSTALL": [
> "hadoop-client"
>   ],
>   "PATCH": [
> "INVALID"
>   ],
>   "STANDARD": [
> "hadoop-client"
>   ]
> },
> ...
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  eac1bef13c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  704fb54293 
>   ambari-server/src/test/python/TestStackSelect.py 3d4e5b6a43 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 0341092b69 
> 
> 
> Diff: https://reviews.apache.org/r/62226/diff/3/
> 
> 
> Testing
> ---
> 
> --
> Total run:1191
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 58.379 s
> [INFO] Finished at: 2017-09-11T16:25:26-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

[Dmytro Grinenko]

> On Sept. 12, 2017, 1:07 p.m., Dmytro Grinenko wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
> > Lines 145 (patched)
> > 
> >
> > while map function is present in python, using generators is more 
> > prefferable
> 
> Jonathan Hurley wrote:
> I've never used generators before - the syntax looks a bit cumbersome for 
> what's needed here. Can you provide an example of what a generator to trim a 
> string would look like?
> 
> Dmytro Grinenko wrote:
> return (s.strip() for s in stdout.splitlines())# this would return 
> gerator, which supports iterative interface
> 
> pros:
>  - actuall method execution would be issues only when you will call 
> iterator, each result would return via "yield" (code would run only once)
> 
> cons:
>  - this would be not list, so no index accessing and only one cycle
> 
> return [s.strip() for s in stdout.splitlines()]# this would return 
> list
>  - this will return list
> 
> Dmytro Grinenko wrote:
> however for python36, it looks that map is faster that list comphersation 
> :)
> 
> Jonathan Hurley wrote:
> Hah! I changed it. If you'd like me to switch it back, let me know.

sience the day, when we will move to python 3.x is even not on horizon, it is 
fine to stay with generators/list comphersation


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62226/#review185174
---


On Sept. 12, 2017, 2:21 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62226/
> ---
> 
> (Updated Sept. 12, 2017, 2:21 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21931
> https://issues.apache.org/jira/browse/AMBARI-21931
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are several "INVALID" types listed in the stack_packages.json file. 
> These were placeholders that need to be updated with the packages exposed by 
> the stack-select tool. 
> 
> {code}
> ...
> "HDFS_CLIENT": {
>   "STACK-SELECT-PACKAGE": "hadoop-client",
>   "INSTALL": [
> "hadoop-client"
>   ],
>   "PATCH": [
> "INVALID"
>   ],
>   "STANDARD": [
> "hadoop-client"
>   ]
> },
> ...
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  eac1bef13c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  704fb54293 
>   ambari-server/src/test/python/TestStackSelect.py 3d4e5b6a43 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 0341092b69 
> 
> 
> Diff: https://reviews.apache.org/r/62226/diff/3/
> 
> 
> Testing
> ---
> 
> --
> Total run:1191
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 58.379 s
> [INFO] Finished at: 2017-09-11T16:25:26-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62226/
---

(Updated Sept. 12, 2017, 10:21 a.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.


Bugs: AMBARI-21931
https://issues.apache.org/jira/browse/AMBARI-21931


Repository: ambari


Description
---

There are several "INVALID" types listed in the stack_packages.json file. These 
were placeholders that need to be updated with the packages exposed by the 
stack-select tool. 

{code}
...
"HDFS_CLIENT": {
  "STACK-SELECT-PACKAGE": "hadoop-client",
  "INSTALL": [
"hadoop-client"
  ],
  "PATCH": [
"INVALID"
  ],
  "STANDARD": [
"hadoop-client"
  ]
},
...
{code}


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
 eac1bef13c 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
 704fb54293 
  ambari-server/src/test/python/TestStackSelect.py 3d4e5b6a43 
  ambari-server/src/test/python/stacks/utils/RMFTestCase.py 0341092b69 


Diff: https://reviews.apache.org/r/62226/diff/3/

Changes: https://reviews.apache.org/r/62226/diff/2-3/


Testing
---

--
Total run:1191
Total errors:0
Total failures:0
OK
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 58.379 s
[INFO] Finished at: 2017-09-11T16:25:26-04:00
[INFO] Final Memory: 21M/619M
[INFO] 


Thanks,

Jonathan Hurley

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

[Jonathan Hurley]

> On Sept. 12, 2017, 9:07 a.m., Dmytro Grinenko wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
> > Lines 145 (patched)
> > 
> >
> > while map function is present in python, using generators is more 
> > prefferable
> 
> Jonathan Hurley wrote:
> I've never used generators before - the syntax looks a bit cumbersome for 
> what's needed here. Can you provide an example of what a generator to trim a 
> string would look like?
> 
> Dmytro Grinenko wrote:
> return (s.strip() for s in stdout.splitlines())# this would return 
> gerator, which supports iterative interface
> 
> pros:
>  - actuall method execution would be issues only when you will call 
> iterator, each result would return via "yield" (code would run only once)
> 
> cons:
>  - this would be not list, so no index accessing and only one cycle
> 
> return [s.strip() for s in stdout.splitlines()]# this would return 
> list
>  - this will return list
> 
> Dmytro Grinenko wrote:
> however for python36, it looks that map is faster that list comphersation 
> :)

Hah! I changed it. If you'd like me to switch it back, let me know.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62226/#review185174
---


On Sept. 11, 2017, 3:43 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62226/
> ---
> 
> (Updated Sept. 11, 2017, 3:43 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21931
> https://issues.apache.org/jira/browse/AMBARI-21931
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are several "INVALID" types listed in the stack_packages.json file. 
> These were placeholders that need to be updated with the packages exposed by 
> the stack-select tool. 
> 
> {code}
> ...
> "HDFS_CLIENT": {
>   "STACK-SELECT-PACKAGE": "hadoop-client",
>   "INSTALL": [
> "hadoop-client"
>   ],
>   "PATCH": [
> "INVALID"
>   ],
>   "STANDARD": [
> "hadoop-client"
>   ]
> },
> ...
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  eac1bef13c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  704fb54293 
>   ambari-server/src/test/python/TestStackSelect.py 3d4e5b6a43 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 0341092b69 
> 
> 
> Diff: https://reviews.apache.org/r/62226/diff/2/
> 
> 
> Testing
> ---
> 
> --
> Total run:1191
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 58.379 s
> [INFO] Finished at: 2017-09-11T16:25:26-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

[Jonathan Hurley]

> On Sept. 12, 2017, 9:07 a.m., Dmytro Grinenko wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
> > Lines 125 (patched)
> > 
> >
> > According to code below, this function would be called 
> > "get_supported_packages" each time in for cycle and would do/return the 
> > same. Can we optimize this?
> 
> Jonathan Hurley wrote:
> Yes, I thought about the fact it's called a lot. The problem is that 
> caching the result wouldn't work since we don't know when to clear the cache. 
> How would you recommend that we optimize this?
> 
> Dmytro Grinenko wrote:
> No need to cache it in the script-life cycle, it is enough only for 
> function-call lifetime, as i dont see any change, which may cause output 
> change per function call.
> 
> so it could be like:
> 
> def is_package_supported(package, pkgs=None):
>   if not pkgs:
> pkgs = get_supported_packages()
> 
>   ..
> 
> 
> def get_packages():
> 
>  ...
> 
>  pkgs = get_supported_packages()
> 
>  for .:
>   if not is_package_supported(package, pkgs)
>  .

Ah, I see - fair enough. I'll make the change.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62226/#review185174
---


On Sept. 11, 2017, 3:43 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62226/
> ---
> 
> (Updated Sept. 11, 2017, 3:43 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21931
> https://issues.apache.org/jira/browse/AMBARI-21931
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are several "INVALID" types listed in the stack_packages.json file. 
> These were placeholders that need to be updated with the packages exposed by 
> the stack-select tool. 
> 
> {code}
> ...
> "HDFS_CLIENT": {
>   "STACK-SELECT-PACKAGE": "hadoop-client",
>   "INSTALL": [
> "hadoop-client"
>   ],
>   "PATCH": [
> "INVALID"
>   ],
>   "STANDARD": [
> "hadoop-client"
>   ]
> },
> ...
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  eac1bef13c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  704fb54293 
>   ambari-server/src/test/python/TestStackSelect.py 3d4e5b6a43 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 0341092b69 
> 
> 
> Diff: https://reviews.apache.org/r/62226/diff/2/
> 
> 
> Testing
> ---
> 
> --
> Total run:1191
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 58.379 s
> [INFO] Finished at: 2017-09-11T16:25:26-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

[Dmytro Grinenko]

> On Sept. 12, 2017, 1:07 p.m., Dmytro Grinenko wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
> > Lines 145 (patched)
> > 
> >
> > while map function is present in python, using generators is more 
> > prefferable
> 
> Jonathan Hurley wrote:
> I've never used generators before - the syntax looks a bit cumbersome for 
> what's needed here. Can you provide an example of what a generator to trim a 
> string would look like?
> 
> Dmytro Grinenko wrote:
> return (s.strip() for s in stdout.splitlines())# this would return 
> gerator, which supports iterative interface
> 
> pros:
>  - actuall method execution would be issues only when you will call 
> iterator, each result would return via "yield" (code would run only once)
> 
> cons:
>  - this would be not list, so no index accessing and only one cycle
> 
> return [s.strip() for s in stdout.splitlines()]# this would return 
> list
>  - this will return list

however for python36, it looks that map is faster that list comphersation :)


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62226/#review185174
---


On Sept. 11, 2017, 7:43 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62226/
> ---
> 
> (Updated Sept. 11, 2017, 7:43 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21931
> https://issues.apache.org/jira/browse/AMBARI-21931
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are several "INVALID" types listed in the stack_packages.json file. 
> These were placeholders that need to be updated with the packages exposed by 
> the stack-select tool. 
> 
> {code}
> ...
> "HDFS_CLIENT": {
>   "STACK-SELECT-PACKAGE": "hadoop-client",
>   "INSTALL": [
> "hadoop-client"
>   ],
>   "PATCH": [
> "INVALID"
>   ],
>   "STANDARD": [
> "hadoop-client"
>   ]
> },
> ...
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  eac1bef13c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  704fb54293 
>   ambari-server/src/test/python/TestStackSelect.py 3d4e5b6a43 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 0341092b69 
> 
> 
> Diff: https://reviews.apache.org/r/62226/diff/2/
> 
> 
> Testing
> ---
> 
> --
> Total run:1191
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 58.379 s
> [INFO] Finished at: 2017-09-11T16:25:26-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

[Dmytro Grinenko]

> On Sept. 12, 2017, 1:07 p.m., Dmytro Grinenko wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
> > Lines 125 (patched)
> > 
> >
> > According to code below, this function would be called 
> > "get_supported_packages" each time in for cycle and would do/return the 
> > same. Can we optimize this?
> 
> Jonathan Hurley wrote:
> Yes, I thought about the fact it's called a lot. The problem is that 
> caching the result wouldn't work since we don't know when to clear the cache. 
> How would you recommend that we optimize this?

No need to cache it in the script-life cycle, it is enough only for 
function-call lifetime, as i dont see any change, which may cause output change 
per function call.

so it could be like:

def is_package_supported(package, pkgs=None):
  if not pkgs:
pkgs = get_supported_packages()

  ..


def get_packages():

 ...

 pkgs = get_supported_packages()

 for .:
  if not is_package_supported(package, pkgs)
 .


> On Sept. 12, 2017, 1:07 p.m., Dmytro Grinenko wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
> > Lines 145 (patched)
> > 
> >
> > while map function is present in python, using generators is more 
> > prefferable
> 
> Jonathan Hurley wrote:
> I've never used generators before - the syntax looks a bit cumbersome for 
> what's needed here. Can you provide an example of what a generator to trim a 
> string would look like?

return (s.strip() for s in stdout.splitlines())# this would return gerator, 
which supports iterative interface

pros:
 - actuall method execution would be issues only when you will call iterator, 
each result would return via "yield" (code would run only once)

cons:
 - this would be not list, so no index accessing and only one cycle

return [s.strip() for s in stdout.splitlines()]# this would return list
 - this will return list


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62226/#review185174
---


On Sept. 11, 2017, 7:43 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62226/
> ---
> 
> (Updated Sept. 11, 2017, 7:43 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21931
> https://issues.apache.org/jira/browse/AMBARI-21931
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are several "INVALID" types listed in the stack_packages.json file. 
> These were placeholders that need to be updated with the packages exposed by 
> the stack-select tool. 
> 
> {code}
> ...
> "HDFS_CLIENT": {
>   "STACK-SELECT-PACKAGE": "hadoop-client",
>   "INSTALL": [
> "hadoop-client"
>   ],
>   "PATCH": [
> "INVALID"
>   ],
>   "STANDARD": [
> "hadoop-client"
>   ]
> },
> ...
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  eac1bef13c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  704fb54293 
>   ambari-server/src/test/python/TestStackSelect.py 3d4e5b6a43 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 0341092b69 
> 
> 
> Diff: https://reviews.apache.org/r/62226/diff/2/
> 
> 
> Testing
> ---
> 
> --
> Total run:1191
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 58.379 s
> [INFO] Finished at: 2017-09-11T16:25:26-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

[Jonathan Hurley]

> On Sept. 12, 2017, 9:07 a.m., Dmytro Grinenko wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
> > Lines 125 (patched)
> > 
> >
> > According to code below, this function would be called 
> > "get_supported_packages" each time in for cycle and would do/return the 
> > same. Can we optimize this?

Yes, I thought about the fact it's called a lot. The problem is that caching 
the result wouldn't work since we don't know when to clear the cache. How would 
you recommend that we optimize this?


> On Sept. 12, 2017, 9:07 a.m., Dmytro Grinenko wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
> > Lines 145 (patched)
> > 
> >
> > while map function is present in python, using generators is more 
> > prefferable

I've never used generators before - the syntax looks a bit cumbersome for 
what's needed here. Can you provide an example of what a generator to trim a 
string would look like?


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62226/#review185174
---


On Sept. 11, 2017, 3:43 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62226/
> ---
> 
> (Updated Sept. 11, 2017, 3:43 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21931
> https://issues.apache.org/jira/browse/AMBARI-21931
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are several "INVALID" types listed in the stack_packages.json file. 
> These were placeholders that need to be updated with the packages exposed by 
> the stack-select tool. 
> 
> {code}
> ...
> "HDFS_CLIENT": {
>   "STACK-SELECT-PACKAGE": "hadoop-client",
>   "INSTALL": [
> "hadoop-client"
>   ],
>   "PATCH": [
> "INVALID"
>   ],
>   "STANDARD": [
> "hadoop-client"
>   ]
> },
> ...
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  eac1bef13c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  704fb54293 
>   ambari-server/src/test/python/TestStackSelect.py 3d4e5b6a43 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 0341092b69 
> 
> 
> Diff: https://reviews.apache.org/r/62226/diff/2/
> 
> 
> Testing
> ---
> 
> --
> Total run:1191
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 58.379 s
> [INFO] Finished at: 2017-09-11T16:25:26-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62226/#review185174
---


Fix it, then Ship it!




Ship It!


ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
Lines 125 (patched)


According to code below, this function would be called 
"get_supported_packages" each time in for cycle and would do/return the same. 
Can we optimize this?



ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
Lines 138 (patched)


No parentheses needed to define tuple in such way, just list variables 
using coma (it is pythonic way)



ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
Lines 145 (patched)


while map function is present in python, using generators is more 
prefferable


- Dmytro Grinenko


On Sept. 11, 2017, 7:43 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62226/
> ---
> 
> (Updated Sept. 11, 2017, 7:43 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21931
> https://issues.apache.org/jira/browse/AMBARI-21931
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are several "INVALID" types listed in the stack_packages.json file. 
> These were placeholders that need to be updated with the packages exposed by 
> the stack-select tool. 
> 
> {code}
> ...
> "HDFS_CLIENT": {
>   "STACK-SELECT-PACKAGE": "hadoop-client",
>   "INSTALL": [
> "hadoop-client"
>   ],
>   "PATCH": [
> "INVALID"
>   ],
>   "STANDARD": [
> "hadoop-client"
>   ]
> },
> ...
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  eac1bef13c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  704fb54293 
>   ambari-server/src/test/python/TestStackSelect.py 3d4e5b6a43 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 0341092b69 
> 
> 
> Diff: https://reviews.apache.org/r/62226/diff/2/
> 
> 
> Testing
> ---
> 
> --
> Total run:1191
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 58.379 s
> [INFO] Finished at: 2017-09-11T16:25:26-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62226/#review185170
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Sept. 11, 2017, 10:43 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62226/
> ---
> 
> (Updated Sept. 11, 2017, 10:43 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21931
> https://issues.apache.org/jira/browse/AMBARI-21931
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are several "INVALID" types listed in the stack_packages.json file. 
> These were placeholders that need to be updated with the packages exposed by 
> the stack-select tool. 
> 
> {code}
> ...
> "HDFS_CLIENT": {
>   "STACK-SELECT-PACKAGE": "hadoop-client",
>   "INSTALL": [
> "hadoop-client"
>   ],
>   "PATCH": [
> "INVALID"
>   ],
>   "STANDARD": [
> "hadoop-client"
>   ]
> },
> ...
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  eac1bef13c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  704fb54293 
>   ambari-server/src/test/python/TestStackSelect.py 3d4e5b6a43 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 0341092b69 
> 
> 
> Diff: https://reviews.apache.org/r/62226/diff/2/
> 
> 
> Testing
> ---
> 
> --
> Total run:1191
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 58.379 s
> [INFO] Finished at: 2017-09-11T16:25:26-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62226/#review185105
---


Ship it!




Ship It!

- Nate Cole


On Sept. 11, 2017, 3:43 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62226/
> ---
> 
> (Updated Sept. 11, 2017, 3:43 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21931
> https://issues.apache.org/jira/browse/AMBARI-21931
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are several "INVALID" types listed in the stack_packages.json file. 
> These were placeholders that need to be updated with the packages exposed by 
> the stack-select tool. 
> 
> {code}
> ...
> "HDFS_CLIENT": {
>   "STACK-SELECT-PACKAGE": "hadoop-client",
>   "INSTALL": [
> "hadoop-client"
>   ],
>   "PATCH": [
> "INVALID"
>   ],
>   "STANDARD": [
> "hadoop-client"
>   ]
> },
> ...
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  eac1bef13c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  704fb54293 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 0341092b69 
> 
> 
> Diff: https://reviews.apache.org/r/62226/diff/1/
> 
> 
> Testing
> ---
> 
> PENDING...
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>