Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-26 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62413/#review186259 --- Ship it! Ship It! - Jonathan Hurley On Sept. 26, 2017, 9:24

Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-26 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62413/ --- (Updated Sept. 26, 2017, 4:24 p.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-20 Thread Nate Cole
> On Sept. 19, 2017, 4:44 p.m., Jonathan Hurley wrote: > > Do you plan to include the ability to extract constraint names from tables > > in this review? It's marked currently as preview... > > Dmitro Lisnichenko wrote: > Yes. It's not a very simple thing, just wanted to make sure that we

Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-19 Thread Dmitro Lisnichenko
> On Sept. 19, 2017, 11:44 p.m., Jonathan Hurley wrote: > > Do you plan to include the ability to extract constraint names from tables > > in this review? It's marked currently as preview... Yes. It's not a very simple thing, just wanted to make sure that we want it (otherwise, current patch

Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62413/#review185755 --- Ship it! Needs a test. Other than Jonathan's comment, LGTM.

Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-19 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62413/#review185731 --- Do you plan to include the ability to extract constraint names

Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-19 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62413/#review185701 ---