Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

2017-11-09 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63573/#review190640
---


Ship it!




Ship It!

- Attila Doroszlai


On Nov. 9, 2017, 7:54 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63573/
> ---
> 
> (Updated Nov. 9, 2017, 7:54 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22366
> https://issues.apache.org/jira/browse/AMBARI-22366
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-22366. POST, GET and UPDATE API for cluster settings. 
> (/clusters/{clusterName}/settings).
> 
> **Background:** AMBARI-22196 did the following : 
>  (1). Refactoring work of moving all cluster related configs/settings in 
> cluster-env to "cluster-settings" files.
>  (2). Implementing READ only API to access *cluster-settings* file 
> *setting(s)* : *http://:/api/v1/cluster_settings/ *
> 
> - This was done to separate cluster related configs from stack related 
> configs.
> 
> **This JIRA implements the following :**
> 
> - POST, GET, UPDATE and DELETE APIs for cluster settings with endpoint : 
>   *http://:/api/v1/clusters/[[clusterName]]/settings*, where 
>-- the cluster settings would be initially read from the above mentioned 
> read-only API : *http://:/api/v1/cluster_settings/*. 
> 
> - Further, added cluster *settings* as a sub-resource of *cluster* resource.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ClusterSettingNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
>  e5680dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  6096fa5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
>  92f50f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  358b1bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  370f735 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3db55d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  20f4864 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java
>  147650c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  9050e3d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  c219d23 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
>  2e935af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  bd6d7bb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterSettingEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterSettingDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java
>  abbf709 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterSettingEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManager.java
>  3b74e69 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 5ba61b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSetting.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSettingFactory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSettingImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
>  7737c0d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  e896d0e

Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

2017-11-08 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63573/
---

(Updated Nov. 9, 2017, 4:04 a.m.)


Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.


Changes
---

Upated code based on last review comments.


Bugs: AMBARI-22366
https://issues.apache.org/jira/browse/AMBARI-22366


Repository: ambari


Description
---

AMBARI-22366. POST, GET and UPDATE API for cluster settings. 
(/clusters/{clusterName}/settings).

**Background:** AMBARI-22196 did the following : 
 (1). Refactoring work of moving all cluster related configs/settings in 
cluster-env to "cluster-settings" files.
 (2). Implementing READ only API to access *cluster-settings* file *setting(s)* 
: *http://:/api/v1/cluster_settings/ *

- This was done to separate cluster related configs from stack related configs.

**This JIRA implements the following :**

- POST, GET, UPDATE and DELETE APIs for cluster settings with endpoint : 
  *http://:/api/v1/clusters/[[clusterName]]/settings*, where 
   -- the cluster settings would be initially read from the above mentioned 
read-only API : *http://:/api/v1/cluster_settings/*. 

- Further, added cluster *settings* as a sub-resource of *cluster* resource.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/ClusterSettingNotFoundException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
 e5680dd 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 6096fa5 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
 92f50f4 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
 358b1bf 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 370f735 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 3db55d4 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
 20f4864 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java
 147650c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 9050e3d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
 c219d23 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
 2e935af 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 bd6d7bb 
  
ambari-server/src/main/java/org/apache/ambari/server/events/ClusterSettingEvent.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterSettingDAO.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java
 abbf709 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterSettingEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManager.java
 3b74e69 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
5ba61b7 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSetting.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSettingFactory.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSettingImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
 7737c0d 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 e896d0e 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 19e23c5 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b1990df 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 015d6ac 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d3c7ff6 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6bfe205 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 65315ec 
  ambari-server/src/main/resources/META-INF/persistence.xml 009ecd5

Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

2017-11-08 Thread Swapan Shridhar 


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
> > Lines 274-282 (patched)
> > 
> >
> > This method always returns an empty `Set`, so it never rejects any 
> > property.

@Override fn removed, as we are not doing anything special/different here.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
> > Lines 471-473 (patched)
> > 
> >
> > Can be simplified using `computeIfAbsent`

Fixed.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
> > Lines 538-540 (patched)
> > 
> >
> > Can be simplified using `computeIfAbsent`

Fixed.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterSettingEntityPK.java
> > Lines 27 (patched)
> > 
> >
> > Why is this PK class needed when it contains a single numeric ID, no 
> > composite key?

Removed.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterSettingEntityPK.java
> > Lines 55 (patched)
> > 
> >
> > Use `Objects.hashCode(...)`

ClusterSettingEntityPK.java has been removed.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSettingImpl.java
> > Lines 158 (patched)
> > 
> >
> > "uses Java locks" -- where?

Comment removed. Fn calls 'persistEntities' which is @Transactional.


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63573/#review190435
---


On Nov. 7, 2017, 11:59 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63573/
> ---
> 
> (Updated Nov. 7, 2017, 11:59 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22366
> https://issues.apache.org/jira/browse/AMBARI-22366
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-22366. POST, GET and UPDATE API for cluster settings. 
> (/clusters/{clusterName}/settings).
> 
> **Background:** AMBARI-22196 did the following : 
>  (1). Refactoring work of moving all cluster related configs/settings in 
> cluster-env to "cluster-settings" files.
>  (2). Implementing READ only API to access *cluster-settings* file 
> *setting(s)* : *http://:/api/v1/cluster_settings/ *
> 
> - This was done to separate cluster related configs from stack related 
> configs.
> 
> **This JIRA implements the following :**
> 
> - POST, GET, UPDATE and DELETE APIs for cluster settings with endpoint : 
>   *http://:/api/v1/clusters/[[clusterName]]/settings*, where 
>-- the cluster settings would be initially read from the above mentioned 
> read-only API : *http://:/api/v1/cluster_settings/*. 
> 
> - Further, added cluster *settings* as a sub-resource of *cluster* resource.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ClusterSettingNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
>  e5680dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  6096fa5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
>  92f50f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  358b1bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  370f735 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingRequest.java
>  PRE-CREATION 
>   
>

Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

2017-11-08 Thread Swapan Shridhar 


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingResponse.java
> > Lines 126-141 (patched)
> > 
> >
> > Can be simplified using `Objects.equals(...)`?
> > 
> > ```
> > return Objects.equals(clusterId, that.clusterId) &&
> >   Objects.equals(clusterSettingId, that.clusterSettingId) &&
> >   ...
> > ```

Fixed.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
> > Lines 461-464 (patched)
> > 
> >
> > Use `{}` placeholders to avoid unnecessary string concatenation and the 
> > need for `isDebugEnabled` check.

Fixed.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
> > Lines 528-531 (patched)
> > 
> >
> > Use `{}` placeholders to avoid unnecessary string concatenation and the 
> > need for `isDebugEnabled` check.

Done.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterSettingEntity.java
> > Lines 111-115 (patched)
> > 
> >
> > Can be simplified using `Objects.equals`?

Updated.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterSettingEntity.java
> > Lines 120-122 (patched)
> > 
> >
> > Can be simplified using `Objects.hash(...)`

Done.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSettingImpl.java
> > Lines 150-152 (patched)
> > 
> >
> > String concatenation in argument to `append()` -- should be several 
> > calls instead.

Fixed.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
> > Lines 985-989 (patched)
> > 
> >
> > Use `{}` placeholders instead of string concatenation, then 
> > `isDebugEnabled` check is not needed

Fixed.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
> > Lines 1009-1012 (patched)
> > 
> >
> > Use `{}` placeholders instead of string concatenation, then 
> > `isDebugEnabled` check is not needed

Done.


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63573/#review190435
---


On Nov. 7, 2017, 11:59 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63573/
> ---
> 
> (Updated Nov. 7, 2017, 11:59 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22366
> https://issues.apache.org/jira/browse/AMBARI-22366
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-22366. POST, GET and UPDATE API for cluster settings. 
> (/clusters/{clusterName}/settings).
> 
> **Background:** AMBARI-22196 did the following : 
>  (1). Refactoring work of moving all cluster related configs/settings in 
> cluster-env to "cluster-settings" files.
>  (2). Implementing READ only API to access *cluster-settings* file 
> *setting(s)* : *http://:/api/v1/cluster_settings/ *
> 
> - This was done to separate cluster related configs from stack related 
> configs.
> 
> **This JIRA implements the following :**
> 
> - POST, GET, UPDATE and DELETE APIs for cluster settings with endpoint : 
>   *http://:/api/v1/clusters/[[clusterName]]/settings*, where 
>-- the cluster settings would be initially read from the above mentioned 
> read-only API : *http://:/api/v1/cluster_settings/*. 
> 
> - Further, added cluster *settings* as a sub-resource of *cluster* resource.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ClusterSettingNotFoundException.java
>  PRE-CREATION 
>   
>

Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

2017-11-08 Thread Swapan Shridhar 


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
> > Lines 37-42 (patched)
> > 
> >
> > Why override only to return the same as `super`?

Removed.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
> > Lines 54 (patched)
> > 
> >
> > This should point to real interfaces that documents the request 
> > structure.

Not required, removed, as we are not creating any related dependency.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
> > Lines 55 (patched)
> > 
> >
> > Unused.

Not required, removed, as we are not creating any related dependency.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
> > Lines 233-235 (patched)
> > 
> >
> > Seems incomplete.  Can it be completed or removed?

Updated.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
> > Lines 68 (patched)
> > 
> >
> > left-over doc ("service"?)

Updated.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
> > Lines 84 (patched)
> > 
> >
> > could be final

Updated.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
> > Lines 85 (patched)
> > 
> >
> > `Arrays.asList` takes varargs, no need for `new String[]`.
> > 
> > Further, `new HashSet(Arrays.asList(...))` could be simplified 
> > to `Sets.newHashSet(...)` .

Fixed.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
> > Lines 89 (patched)
> > 
> >
> > Unused.

Removed.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
> > Lines 114 (patched)
> > 
> >
> > Unused.

Removed


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
> > Lines 120 (patched)
> > 
> >
> > Unused.

Removed.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
> > Lines 147-148 (patched)
> > 
> >
> > `= null` assignment is unnecessary.

Removed.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
> > Lines 193 (patched)
> > 
> >
> > no need for explicit type in `HashSet<...>`

Updated.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
> > Lines 220-221 (patched)
> > 
> >
> > `= null` assignment is unnecessary.

Updated.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
> > Lines 253 (patched)
> > 
> >
> > `= null` is unnecessary, move declaration to first assignment a few 
> > lines below.

Moved and null removed.


> On Nov. 8, 2017, 2:02 p.m., Attila Doroszlai wrote:
> >

Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

2017-11-08 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63573/#review190435
---




ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
Lines 37-42 (patched)


Why override only to return the same as `super`?



ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
Lines 54 (patched)


This should point to real interfaces that documents the request structure.



ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
Lines 55 (patched)


Unused.



ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
Lines 233-235 (patched)


Seems incomplete.  Can it be completed or removed?



ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingResponse.java
Lines 126-141 (patched)


Can be simplified using `Objects.equals(...)`?

```
return Objects.equals(clusterId, that.clusterId) &&
  Objects.equals(clusterSettingId, that.clusterSettingId) &&
  ...
```



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
Lines 68 (patched)


left-over doc ("service"?)



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
Lines 84 (patched)


could be final



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
Lines 85 (patched)


`Arrays.asList` takes varargs, no need for `new String[]`.

Further, `new HashSet(Arrays.asList(...))` could be simplified to 
`Sets.newHashSet(...)` .



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
Lines 89 (patched)


Unused.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
Lines 114 (patched)


Unused.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
Lines 120 (patched)


Unused.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
Lines 147-148 (patched)


`= null` assignment is unnecessary.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
Lines 193 (patched)


no need for explicit type in `HashSet<...>`



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
Lines 220-221 (patched)


`= null` assignment is unnecessary.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
Lines 253 (patched)


`= null` is unnecessary, move declaration to first assignment a few lines 
below.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
Lines 267 (patched)


`svgReq` name is not appropriate (no service groups here), could be simply 
`req`.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
Lines 274-282 (patched)


This method always returns an empty `Set`, so it never rejects any property.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
Lines 304 (patched)


The name `svcRequest` is not appropriate, since it's not a 
`ServiceRequest`.  Can be simplified to return without the local variable.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
Lines 309 (patched)


could be `private`

Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

2017-11-07 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63573/
---

(Updated Nov. 7, 2017, 11:59 p.m.)


Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.


Changes
---

- Removed Event creation/removal for Cluster Setting.
- Changed primary key as cluster setting Id only, which is unique.


Bugs: AMBARI-22366
https://issues.apache.org/jira/browse/AMBARI-22366


Repository: ambari


Description
---

AMBARI-22366. POST, GET and UPDATE API for cluster settings. 
(/clusters/{clusterName}/settings).

**Background:** AMBARI-22196 did the following : 
 (1). Refactoring work of moving all cluster related configs/settings in 
cluster-env to "cluster-settings" files.
 (2). Implementing READ only API to access *cluster-settings* file *setting(s)* 
: *http://:/api/v1/cluster_settings/ *

- This was done to separate cluster related configs from stack related configs.

**This JIRA implements the following :**

- POST, GET, UPDATE and DELETE APIs for cluster settings with endpoint : 
  *http://:/api/v1/clusters/[[clusterName]]/settings*, where 
   -- the cluster settings would be initially read from the above mentioned 
read-only API : *http://:/api/v1/cluster_settings/*. 

- Further, added cluster *settings* as a sub-resource of *cluster* resource.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/ClusterSettingNotFoundException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
 e5680dd 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 6096fa5 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
 92f50f4 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
 358b1bf 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 370f735 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 3db55d4 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
 20f4864 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java
 147650c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 9050e3d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
 c219d23 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
 2e935af 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 bd6d7bb 
  
ambari-server/src/main/java/org/apache/ambari/server/events/ClusterSettingEvent.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterSettingDAO.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java
 abbf709 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterSettingEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterSettingEntityPK.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManager.java
 3b74e69 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
5ba61b7 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSetting.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSettingFactory.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSettingImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
 7737c0d 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 e896d0e 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 19e23c5 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b1990df 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 015d6ac 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d3c7ff6

Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

2017-11-07 Thread Madhuvanthi Radhakrishnan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63573/#review190398
---


Ship it!




Ship It!

- Madhuvanthi Radhakrishnan


On Nov. 7, 2017, 11:59 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63573/
> ---
> 
> (Updated Nov. 7, 2017, 11:59 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22366
> https://issues.apache.org/jira/browse/AMBARI-22366
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-22366. POST, GET and UPDATE API for cluster settings. 
> (/clusters/{clusterName}/settings).
> 
> **Background:** AMBARI-22196 did the following : 
>  (1). Refactoring work of moving all cluster related configs/settings in 
> cluster-env to "cluster-settings" files.
>  (2). Implementing READ only API to access *cluster-settings* file 
> *setting(s)* : *http://:/api/v1/cluster_settings/ *
> 
> - This was done to separate cluster related configs from stack related 
> configs.
> 
> **This JIRA implements the following :**
> 
> - POST, GET, UPDATE and DELETE APIs for cluster settings with endpoint : 
>   *http://:/api/v1/clusters/[[clusterName]]/settings*, where 
>-- the cluster settings would be initially read from the above mentioned 
> read-only API : *http://:/api/v1/cluster_settings/*. 
> 
> - Further, added cluster *settings* as a sub-resource of *cluster* resource.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ClusterSettingNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
>  e5680dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  6096fa5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
>  92f50f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  358b1bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  370f735 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3db55d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  20f4864 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java
>  147650c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  9050e3d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  c219d23 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
>  2e935af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  bd6d7bb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterSettingEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterSettingDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java
>  abbf709 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterSettingEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterSettingEntityPK.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManager.java
>  3b74e69 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 5ba61b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSetting.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSettingFactory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSettingImpl.java
>  PRE-CREATION 
>   
>

Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

2017-11-07 Thread Swapan Shridhar 


> On Nov. 6, 2017, 8:06 p.m., Madhuvanthi Radhakrishnan wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java
> > Lines 138 (patched)
> > 
> >
> > Hi,
> > Do we need to create events for Cluster Setting creation?

Fixed. Removed.


> On Nov. 6, 2017, 8:06 p.m., Madhuvanthi Radhakrishnan wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql
> > Lines 179 (patched)
> > 
> >
> > Hi,
> > I guess we can have just id to be the primary key. Another uniquness 
> > will be cluster_id + setting_name in case of multi-cluster scenario.
> > Thanks.

Fixed.


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63573/#review190208
---


On Nov. 7, 2017, 11:59 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63573/
> ---
> 
> (Updated Nov. 7, 2017, 11:59 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22366
> https://issues.apache.org/jira/browse/AMBARI-22366
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-22366. POST, GET and UPDATE API for cluster settings. 
> (/clusters/{clusterName}/settings).
> 
> **Background:** AMBARI-22196 did the following : 
>  (1). Refactoring work of moving all cluster related configs/settings in 
> cluster-env to "cluster-settings" files.
>  (2). Implementing READ only API to access *cluster-settings* file 
> *setting(s)* : *http://:/api/v1/cluster_settings/ *
> 
> - This was done to separate cluster related configs from stack related 
> configs.
> 
> **This JIRA implements the following :**
> 
> - POST, GET, UPDATE and DELETE APIs for cluster settings with endpoint : 
>   *http://:/api/v1/clusters/[[clusterName]]/settings*, where 
>-- the cluster settings would be initially read from the above mentioned 
> read-only API : *http://:/api/v1/cluster_settings/*. 
> 
> - Further, added cluster *settings* as a sub-resource of *cluster* resource.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ClusterSettingNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
>  e5680dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  6096fa5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
>  92f50f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  358b1bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  370f735 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3db55d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  20f4864 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java
>  147650c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  9050e3d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  c219d23 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
>  2e935af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  bd6d7bb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterSettingEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterSettingDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java
>  abbf709 
>   
>

Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

2017-11-06 Thread Madhuvanthi Radhakrishnan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63573/#review190208
---




ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java
Lines 138 (patched)


Hi,
Do we need to create events for Cluster Setting creation?



ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql
Lines 179 (patched)


Hi,
I guess we can have just id to be the primary key. Another uniquness will 
be cluster_id + setting_name in case of multi-cluster scenario.
Thanks.


- Madhuvanthi Radhakrishnan


On Nov. 6, 2017, 6:54 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63573/
> ---
> 
> (Updated Nov. 6, 2017, 6:54 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22366
> https://issues.apache.org/jira/browse/AMBARI-22366
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-22366. POST, GET and UPDATE API for cluster settings. 
> (/clusters/{clusterName}/settings).
> 
> **Background:** AMBARI-22196 did the following : 
>  (1). Refactoring work of moving all cluster related configs/settings in 
> cluster-env to "cluster-settings" files.
>  (2). Implementing READ only API to access *cluster-settings* file 
> *setting(s)* : *http://:/api/v1/cluster_settings/ *
> 
> - This was done to separate cluster related configs from stack related 
> configs.
> 
> **This JIRA implements the following :**
> 
> - POST, GET, UPDATE and DELETE APIs for cluster settings with endpoint : 
>   *http://:/api/v1/clusters/[[clusterName]]/settings*, where 
>-- the cluster settings would be initially read from the above mentioned 
> read-only API : *http://:/api/v1/cluster_settings/*. 
> 
> - Further, added cluster *settings* as a sub-resource of *cluster* resource.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ClusterSettingNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
>  e5680dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  6096fa5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
>  92f50f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  358b1bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  370f735 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3db55d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  20f4864 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java
>  147650c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  9050e3d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  c219d23 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
>  2e935af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  bd6d7bb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
> c88c514 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterSettingEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterSettingInstalledEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterSettingRemovedEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterSettingDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java
>