Re: Review Request 64606: Fix unit tests in feature branch to make them workable

2017-12-14 Thread Attila Doroszlai

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64606/#review193800
---


Ship it!




Ship It!

- Attila Doroszlai


On Dec. 14, 2017, 2:46 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64606/
> ---
> 
> (Updated Dec. 14, 2017, 2:46 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai and Dmytro Sen.
> 
> 
> Bugs: AMBARI-22614
> https://issues.apache.org/jira/browse/AMBARI-22614
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix unit tests in feature branch to make them workable
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnableTest.java
>  62ff3d3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/query/render/DefaultRendererTest.java
>  96f80b1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/query/render/MinimalRendererTest.java
>  782f148 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java
>  c79e761 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  f2ee106 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java
>  3e4baed 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  0f99b08 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java
>  3ce6686 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java
>  7ccdadd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
>  4b5d6c0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  a6fc919 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java
>  efa351a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java
>  6611c55 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
>  e23ad79 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
>  6bc8b95 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java
>  ce3656c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java
>  4593409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProviderTest.java
>  91c048b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java
>  1bc8776 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
>  a38e44d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java
>  9df236f 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
> dafc5e8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java
>  4dac019 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java
>  933743f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
>  658ba84 
>   
> ambari-server/src/test/java/org/apache/ambari/server/testing/DBInconsistencyTests.java
>  fafeaff 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java
>  8546a9b 
> 
> 
> Diff: https://reviews.apache.org/r/64606/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>



Re: Review Request 64606: Fix unit tests in feature branch to make them workable

2017-12-14 Thread Vitalyi Brodetskyi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64606/
---

(Updated Гру. 14, 2017, 1:46 після полудня)


Review request for Ambari, Attila Doroszlai and Dmytro Sen.


Bugs: AMBARI-22614
https://issues.apache.org/jira/browse/AMBARI-22614


Repository: ambari


Description
---

Fix unit tests in feature branch to make them workable


Diffs (updated)
-

  
ambari-server/src/test/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnableTest.java
 62ff3d3 
  
ambari-server/src/test/java/org/apache/ambari/server/api/query/render/DefaultRendererTest.java
 96f80b1 
  
ambari-server/src/test/java/org/apache/ambari/server/api/query/render/MinimalRendererTest.java
 782f148 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java
 c79e761 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
 f2ee106 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java
 3e4baed 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 0f99b08 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java
 3ce6686 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java
 7ccdadd 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
 4b5d6c0 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
 a6fc919 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java
 efa351a 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java
 6611c55 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
 e23ad79 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
 6bc8b95 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java
 ce3656c 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java
 4593409 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProviderTest.java
 91c048b 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java
 1bc8776 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
 a38e44d 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java
 9df236f 
  ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
dafc5e8 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java
 4dac019 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java 
933743f 
  
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
 658ba84 
  
ambari-server/src/test/java/org/apache/ambari/server/testing/DBInconsistencyTests.java
 fafeaff 
  
ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java 
8546a9b 


Diff: https://reviews.apache.org/r/64606/diff/2/

Changes: https://reviews.apache.org/r/64606/diff/1-2/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi



Re: Review Request 64606: Fix unit tests in feature branch to make them workable

2017-12-14 Thread Dmytro Sen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64606/#review193792
---


Ship it!




Ship It!

- Dmytro Sen


On Dec. 14, 2017, 12:23 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64606/
> ---
> 
> (Updated Dec. 14, 2017, 12:23 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai and Dmytro Sen.
> 
> 
> Bugs: AMBARI-22614
> https://issues.apache.org/jira/browse/AMBARI-22614
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix unit tests in feature branch to make them workable
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  9be79e7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java
>  ea082c6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnableTest.java
>  62ff3d3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/query/render/DefaultRendererTest.java
>  96f80b1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/query/render/MinimalRendererTest.java
>  782f148 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java
>  c79e761 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  f2ee106 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  e584322 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java
>  3e4baed 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  0f99b08 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java
>  3ce6686 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java
>  7ccdadd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
>  4b5d6c0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  a6fc919 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java
>  efa351a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java
>  6611c55 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
>  e23ad79 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
>  6bc8b95 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java
>  ce3656c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java
>  4593409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProviderTest.java
>  91c048b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java
>  1bc8776 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
>  a38e44d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java
>  9df236f 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
> dafc5e8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java
>  4dac019 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java
>  933743f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
>  658ba84 
>   
> ambari-server/src/test/java/org/apache/ambari/server/testing/DBInconsistencyTests.java
>  fafeaff 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java
>  8546a9b 
> 
> 
> Diff: https://reviews.apache.org/r/64606/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>