Re: Review Request 64837: AMBARI-22696 Whitelist execute latency from Storm Ambari metrics (branch-2.6)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64837/#review194561 --- Ship it! Ship It! - Aravindan Vijayan On Dec. 25, 2017, 4:38 a.m., Jungtaek Lim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64837/ > --- > > (Updated Dec. 25, 2017, 4:38 a.m.) > > > Review request for Ambari, Arun Mahadevan and Aravindan Vijayan. > > > Bugs: AMBARI-22696 > https://issues.apache.org/jira/browse/AMBARI-22696 > > > Repository: ambari > > > Description > --- > > We have an use case which leverages execute latency along with process > latency. Given that we only register process latency as whitelist, we would > need to add execute latency as whitelist as well. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-site.xml > 558beaf8d9 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 4187dc9b55 > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > 8f27d79375 > > > Diff: https://reviews.apache.org/r/64837/diff/1/ > > > Testing > --- > > Manually applied the change to configuration of test cluster, and confirmed > it works. > > It doesn't mean I have tested it with upgrading, so please consider verifying > it works well with various upgrade cases. > > > Thanks, > > Jungtaek Lim > >
Re: Review Request 64837: AMBARI-22696 Whitelist execute latency from Storm Ambari metrics (branch-2.6)
> On 12월 28, 2017, 1:31 오전, Aravindan Vijayan wrote: > > These changes might be needed in > > ambari/ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/service_advisor.py > > as well. That file only exists on trunk branch. I've also published another review board for trunk branch. - Jungtaek --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64837/#review194559 --- On 12월 25, 2017, 4:38 오전, Jungtaek Lim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64837/ > --- > > (Updated 12월 25, 2017, 4:38 오전) > > > Review request for Ambari, Arun Mahadevan and Aravindan Vijayan. > > > Bugs: AMBARI-22696 > https://issues.apache.org/jira/browse/AMBARI-22696 > > > Repository: ambari > > > Description > --- > > We have an use case which leverages execute latency along with process > latency. Given that we only register process latency as whitelist, we would > need to add execute latency as whitelist as well. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-site.xml > 558beaf8d9 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 4187dc9b55 > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > 8f27d79375 > > > Diff: https://reviews.apache.org/r/64837/diff/1/ > > > Testing > --- > > Manually applied the change to configuration of test cluster, and confirmed > it works. > > It doesn't mean I have tested it with upgrading, so please consider verifying > it works well with various upgrade cases. > > > Thanks, > > Jungtaek Lim > >
Re: Review Request 64837: AMBARI-22696 Whitelist execute latency from Storm Ambari metrics (branch-2.6)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64837/#review194559 --- These changes might be needed in ambari/ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/service_advisor.py as well. - Aravindan Vijayan On Dec. 25, 2017, 4:38 a.m., Jungtaek Lim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64837/ > --- > > (Updated Dec. 25, 2017, 4:38 a.m.) > > > Review request for Ambari, Arun Mahadevan and Aravindan Vijayan. > > > Bugs: AMBARI-22696 > https://issues.apache.org/jira/browse/AMBARI-22696 > > > Repository: ambari > > > Description > --- > > We have an use case which leverages execute latency along with process > latency. Given that we only register process latency as whitelist, we would > need to add execute latency as whitelist as well. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-site.xml > 558beaf8d9 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 4187dc9b55 > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > 8f27d79375 > > > Diff: https://reviews.apache.org/r/64837/diff/1/ > > > Testing > --- > > Manually applied the change to configuration of test cluster, and confirmed > it works. > > It doesn't mean I have tested it with upgrading, so please consider verifying > it works well with various upgrade cases. > > > Thanks, > > Jungtaek Lim > >
Re: Review Request 64837: AMBARI-22696 Whitelist execute latency from Storm Ambari metrics (branch-2.6)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64837/#review194497 --- Ship it! Ship It! - Arun Mahadevan On Dec. 25, 2017, 4:38 a.m., Jungtaek Lim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64837/ > --- > > (Updated Dec. 25, 2017, 4:38 a.m.) > > > Review request for Ambari, Arun Mahadevan and Aravindan Vijayan. > > > Bugs: AMBARI-22696 > https://issues.apache.org/jira/browse/AMBARI-22696 > > > Repository: ambari > > > Description > --- > > We have an use case which leverages execute latency along with process > latency. Given that we only register process latency as whitelist, we would > need to add execute latency as whitelist as well. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-site.xml > 558beaf8d9 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 4187dc9b55 > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > 8f27d79375 > > > Diff: https://reviews.apache.org/r/64837/diff/1/ > > > Testing > --- > > Manually applied the change to configuration of test cluster, and confirmed > it works. > > It doesn't mean I have tested it with upgrading, so please consider verifying > it works well with various upgrade cases. > > > Thanks, > > Jungtaek Lim > >