Re: Review Request 44565: Hive view: Visual Explain does not work when there are multiple statements in the query editor

2016-03-19 Thread DIPAYAN BHOWMICK

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44565/#review124065
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On March 17, 2016, 4:07 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44565/
> ---
> 
> (Updated March 17, 2016, 4:07 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Srimanth Gunturi, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-15346
> https://issues.apache.org/jira/browse/AMBARI-15346
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding the "Explain | Explain Formatted" only for the last query. Make some 
> modification in "updateValue" function of query editor component to handle 
> this change.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/components/query-editor.js
>  10c6bb3 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js 
> a056759 
> 
> Diff: https://reviews.apache.org/r/44565/diff/
> 
> 
> Testing
> ---
> 
> manual testing done. No extra unit test case needed.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Re: Review Request 44565: Hive view: Visual Explain does not work when there are multiple statements in the query editor

2016-03-19 Thread Pallav Kulshreshtha

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44565/
---

(Updated March 17, 2016, 4:07 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Srimanth Gunturi, and Yusaku Sako.


Bugs: AMBARI-15346
https://issues.apache.org/jira/browse/AMBARI-15346


Repository: ambari


Description
---

Adding the "Explain | Explain Formatted" only for the last query. Make some 
modification in "updateValue" function of query editor component to handle this 
change.


Diffs (updated)
-

  
contrib/views/hive/src/main/resources/ui/hive-web/app/components/query-editor.js
 10c6bb3 
  contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js 
a056759 

Diff: https://reviews.apache.org/r/44565/diff/


Testing
---

manual testing done. No extra unit test case needed.


Thanks,

Pallav Kulshreshtha



Review Request 44565: Hive view: Visual Explain does not work when there are multiple statements in the query editor

2016-03-09 Thread Pallav Kulshreshtha

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44565/
---

Review request for Ambari, DIPAYAN BHOWMICK, Srimanth Gunturi, and Yusaku Sako.


Bugs: AMBARI-15346
https://issues.apache.org/jira/browse/AMBARI-15346


Repository: ambari


Description
---

Adding the "Explain | Explain Formatted" only for the last query. Make some 
modification in "updateValue" function of query editor component to handle this 
change.


Diffs
-

  
contrib/views/hive/src/main/resources/ui/hive-web/app/components/query-editor.js
 10c6bb3 
  contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js 
a056759 

Diff: https://reviews.apache.org/r/44565/diff/


Testing
---

manual testing done. No extra unit test case needed.


Thanks,

Pallav Kulshreshtha