Re: Review Request 44705: Counter values need to request for rate function to maintain parity

2016-03-11 Thread Andriy Babiichuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44705/#review123138
---


Ship it!




Ship It!

- Andriy Babiichuk


On Март 11, 2016, 1:18 п.п., Andrii Tkach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44705/
> ---
> 
> (Updated Март 11, 2016, 1:18 п.п.)
> 
> 
> Review request for Ambari, Andriy Babiichuk and Sid Wagle.
> 
> 
> Bugs: AMBARI-15385
> https://issues.apache.org/jira/browse/AMBARI-15385
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMS API will return back Counter metrics as is which means a monotonically 
> increasing sequence. To maintain parity with previous implementation the 
> Counter metrics need to be request with *._rate* as the aggregate function.
> 
> List of Counter metrics can be obtained by making a call to AMS metadata API:
> http://localhost:6188/ws/v1/timeline/metrics/metadata
> 
> 
> Diffs
> -
> 
>   
> ambari-funtest/src/test/resources/stacks/OTHER/2.0/services/HBASE/widgets.json
>  70a7fa0bf8faf97e76438a5c02738d783ab2d4ef 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json
>  9b4503478ca26a9993da3d1838beeb494570357a 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
> 89aab135d4e3e4127a1e89176e23e7ab7c6c8926 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/YARN_widgets.json
>  fedee4db27595978eb13ed5a71f6b4fda4e22f81 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/widgets.json 
> a0f5ba90a9cf04e7283c34e8741d5812d13aa74a 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
> ee745d905cbbdf25010f2156fa985be05f06d521 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/YARN_widgets.json
>  5179470d351f230fa09a0c9c73d5773da4359b00 
>   
> ambari-server/src/test/resources/stacks/OTHER/2.0/services/HBASE/widgets.json 
> 70a7fa0bf8faf97e76438a5c02738d783ab2d4ef 
>   ambari-web/app/views/main/service/widgets/create/expression_view.js 
> 0ec72787ef073d7776583471ace1d03345feed96 
> 
> Diff: https://reviews.apache.org/r/44705/diff/
> 
> 
> Testing
> ---
> 
> 24564 tests complete (30 seconds)
>   145 tests pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>



Review Request 44705: Counter values need to request for rate function to maintain parity

2016-03-11 Thread Andrii Tkach

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44705/
---

Review request for Ambari, Andriy Babiichuk and Sid Wagle.


Bugs: AMBARI-15385
https://issues.apache.org/jira/browse/AMBARI-15385


Repository: ambari


Description
---

AMS API will return back Counter metrics as is which means a monotonically 
increasing sequence. To maintain parity with previous implementation the 
Counter metrics need to be request with *._rate* as the aggregate function.

List of Counter metrics can be obtained by making a call to AMS metadata API:
http://localhost:6188/ws/v1/timeline/metrics/metadata


Diffs
-

  
ambari-funtest/src/test/resources/stacks/OTHER/2.0/services/HBASE/widgets.json 
70a7fa0bf8faf97e76438a5c02738d783ab2d4ef 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json 
9b4503478ca26a9993da3d1838beeb494570357a 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
89aab135d4e3e4127a1e89176e23e7ab7c6c8926 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/YARN_widgets.json
 fedee4db27595978eb13ed5a71f6b4fda4e22f81 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/widgets.json 
a0f5ba90a9cf04e7283c34e8741d5812d13aa74a 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
ee745d905cbbdf25010f2156fa985be05f06d521 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/YARN_widgets.json 
5179470d351f230fa09a0c9c73d5773da4359b00 
  ambari-server/src/test/resources/stacks/OTHER/2.0/services/HBASE/widgets.json 
70a7fa0bf8faf97e76438a5c02738d783ab2d4ef 
  ambari-web/app/views/main/service/widgets/create/expression_view.js 
0ec72787ef073d7776583471ace1d03345feed96 

Diff: https://reviews.apache.org/r/44705/diff/


Testing
---

24564 tests complete (30 seconds)
  145 tests pending


Thanks,

Andrii Tkach