> On March 29, 2016, 1:13 p.m., Jonathan Hurley wrote:
> > Was this committed? If so, can we close the review?
Yes this was committed. We can close this review.
- Alexandr
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44724/#review125866
---
Was this committed? If so, can we close the review?
- Jonathan Hu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44724/#review125330
---
Ship it!
Ship It!
- Richard Zang
On March 20, 2016, 5:50 a.m
> On March 22, 2016, 11:07 a.m., Jonathan Hurley wrote:
> > Any unit tests to cover this?
>
> Qin Liu wrote:
> Hi Jonathan, I didn't add unit tests to cover checking spaces but I
> tested it from UI. Can I still ship it? Or, can I add it from another patch
> if you really want it? :-)
>
> On March 22, 2016, 3:07 p.m., Jonathan Hurley wrote:
> > Any unit tests to cover this?
Hi Jonathan, I didn't add unit tests to cover checking spaces but I tested it
from UI. Can I still ship it? Or, can I add it from another patch if you really
want it? :-)
Also, Di is off and will be back
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44724/#review124805
---
Ship it!
Any unit tests to cover this?
- Jonathan Hurley
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44724/#review124180
---
ambari-web/app/controllers/main/alerts/manage_alert_notifications
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44724/
---
(Updated March 20, 2016, 5:50 a.m.)
Review request for Ambari, Di Li and Jonath
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44724/#review124178
---
ambari-web/app/controllers/main/alerts/manage_alert_notifications
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44724/
---
(Updated March 15, 2016, 7:17 p.m.)
Review request for Ambari, Di Li and Jonath
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44724/
---
Review request for Ambari and Di Li.
Bugs: AMBARI-12906
https://issues.apac
11 matches
Mail list logo