Re: Review Request 44784: Provide composite Kerberos Descriptor via the REST API

2016-03-14 Thread Robert Levas 


> On March 14, 2016, 12:10 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java,
> >  lines 122-123
> > 
> >
> > This is interesting. How do we enforce that this kind of stuff gets 
> > added to new providers? It's easy enough to not put it in, and then 
> > technically, there would be a security hole.
> > 
> > Nothing to do for this review, but something to think of.

I agree... but I am not sure how to solve this give the current architecture of 
the REST API.  Ideally this can be addressed when version 2 of the API is 
designed.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44784/#review123439
---


On March 14, 2016, 8:19 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44784/
> ---
> 
> (Updated March 14, 2016, 8:19 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, and 
> Sandor Magyari.
> 
> 
> Bugs: AMBARI-15373
> https://issues.apache.org/jira/browse/AMBARI-15373
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Provide an entry point in the REST API to retrieve the _composite_ Kerberos 
> descriptor. This includes the default Kerberos descriptor built from the 
> stack definitions overlaid with the (potentially sparse) Kerberos descriptor 
> stored as an artifact of the cluster. 
> 
> The entry point should be a read-only sub-resource of "clusters", and should 
> only be made available if asked for explicitly due to the size of the data 
> that will be returned.
> 
> #Example API call}
> ```
> GET /api/v1/clusters/:cluster_name/kerberos_descriptors/COMPOSITE
> ```
> Note: Kerberos Descriptors available via this interface are:
> - STACK - the default Kerberos Descriptor from the relevant stack definition
> - USER - the user-suppled updates to the stack default Kerberos Descriptor
> - COMPOSITE - the stack default Kerberos Descriptor with the user-suppled 
> updates applied (this is the Kerberos Descriptor used when performing 
> Kerberos-related operations)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
>  e57364f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  d10b7a8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterKerberosDescriptorService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
>  8e9b771 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  586924b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  85fd649 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java
>  cb68dfa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImplTest.java
>  e761a72 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterKerberosDescriptorServiceTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java
>  796c509 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44784/diff/
> 
> 
> Testing
> ---
> 
> Manually tests
> 
> # Local test results:
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:03:06.043s
> [INFO] Finished at: Sun Mar 13 11:53:32 EDT 2016
> [INFO] Final Memory: 71M/867M
> [INFO] 
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 44784: Provide composite Kerberos Descriptor via the REST API

2016-03-14 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44784/#review123439
---


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java
 (lines 122 - 123)


This is interesting. How do we enforce that this kind of stuff gets added 
to new providers? It's easy enough to not put it in, and then technically, 
there would be a security hole.

Nothing to do for this review, but something to think of.


- Jonathan Hurley


On March 14, 2016, 8:19 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44784/
> ---
> 
> (Updated March 14, 2016, 8:19 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, and 
> Sandor Magyari.
> 
> 
> Bugs: AMBARI-15373
> https://issues.apache.org/jira/browse/AMBARI-15373
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Provide an entry point in the REST API to retrieve the _composite_ Kerberos 
> descriptor. This includes the default Kerberos descriptor built from the 
> stack definitions overlaid with the (potentially sparse) Kerberos descriptor 
> stored as an artifact of the cluster. 
> 
> The entry point should be a read-only sub-resource of "clusters", and should 
> only be made available if asked for explicitly due to the size of the data 
> that will be returned.
> 
> #Example API call}
> ```
> GET /api/v1/clusters/:cluster_name/kerberos_descriptors/COMPOSITE
> ```
> Note: Kerberos Descriptors available via this interface are:
> - STACK - the default Kerberos Descriptor from the relevant stack definition
> - USER - the user-suppled updates to the stack default Kerberos Descriptor
> - COMPOSITE - the stack default Kerberos Descriptor with the user-suppled 
> updates applied (this is the Kerberos Descriptor used when performing 
> Kerberos-related operations)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
>  e57364f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  d10b7a8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterKerberosDescriptorService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
>  8e9b771 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  586924b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  85fd649 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java
>  cb68dfa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImplTest.java
>  e761a72 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterKerberosDescriptorServiceTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java
>  796c509 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44784/diff/
> 
> 
> Testing
> ---
> 
> Manually tests
> 
> # Local test results:
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:03:06.043s
> [INFO] Finished at: Sun Mar 13 11:53:32 EDT 2016
> [INFO] Final Memory: 71M/867M
> [INFO] 
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 44784: Provide composite Kerberos Descriptor via the REST API

2016-03-14 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44784/#review123428
---


Ship it!




Ship It!

- Nate Cole


On March 14, 2016, 8:19 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44784/
> ---
> 
> (Updated March 14, 2016, 8:19 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, and 
> Sandor Magyari.
> 
> 
> Bugs: AMBARI-15373
> https://issues.apache.org/jira/browse/AMBARI-15373
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Provide an entry point in the REST API to retrieve the _composite_ Kerberos 
> descriptor. This includes the default Kerberos descriptor built from the 
> stack definitions overlaid with the (potentially sparse) Kerberos descriptor 
> stored as an artifact of the cluster. 
> 
> The entry point should be a read-only sub-resource of "clusters", and should 
> only be made available if asked for explicitly due to the size of the data 
> that will be returned.
> 
> #Example API call}
> ```
> GET /api/v1/clusters/:cluster_name/kerberos_descriptors/COMPOSITE
> ```
> Note: Kerberos Descriptors available via this interface are:
> - STACK - the default Kerberos Descriptor from the relevant stack definition
> - USER - the user-suppled updates to the stack default Kerberos Descriptor
> - COMPOSITE - the stack default Kerberos Descriptor with the user-suppled 
> updates applied (this is the Kerberos Descriptor used when performing 
> Kerberos-related operations)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
>  e57364f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  d10b7a8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterKerberosDescriptorService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
>  8e9b771 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  586924b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  85fd649 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java
>  cb68dfa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImplTest.java
>  e761a72 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterKerberosDescriptorServiceTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java
>  796c509 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44784/diff/
> 
> 
> Testing
> ---
> 
> Manually tests
> 
> # Local test results:
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:03:06.043s
> [INFO] Finished at: Sun Mar 13 11:53:32 EDT 2016
> [INFO] Final Memory: 71M/867M
> [INFO] 
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 44784: Provide composite Kerberos Descriptor via the REST API

2016-03-14 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44784/
---

Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, and 
Sandor Magyari.


Bugs: AMBARI-15373
https://issues.apache.org/jira/browse/AMBARI-15373


Repository: ambari


Description
---

Provide an entry point in the REST API to retrieve the _composite_ Kerberos 
descriptor. This includes the default Kerberos descriptor built from the stack 
definitions overlaid with the (potentially sparse) Kerberos descriptor stored 
as an artifact of the cluster. 

The entry point should be a read-only sub-resource of "clusters", and should 
only be made available if asked for explicitly due to the size of the data that 
will be returned.

#Example API call}
```
GET /api/v1/clusters/:cluster_name/kerberos_descriptors/COMPOSITE
```
Note: Kerberos Descriptors available via this interface are:
- STACK - the default Kerberos Descriptor from the relevant stack definition
- USER - the user-suppled updates to the stack default Kerberos Descriptor
- COMPOSITE - the stack default Kerberos Descriptor with the user-suppled 
updates applied (this is the Kerberos Descriptor used when performing 
Kerberos-related operations)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
 e57364f 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 d10b7a8 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterKerberosDescriptorService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
 8e9b771 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 586924b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 85fd649 
  
ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java
 cb68dfa 
  
ambari-server/src/test/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImplTest.java
 e761a72 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterKerberosDescriptorServiceTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java
 796c509 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/44784/diff/


Testing
---

Manually tests

# Local test results:

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:03:06.043s
[INFO] Finished at: Sun Mar 13 11:53:32 EDT 2016
[INFO] Final Memory: 71M/867M
[INFO] 

# Jenkins test results: PENDING


Thanks,

Robert Levas