Re: Review Request 44809: RBAC: Name filter does not work for user with no role

2016-03-14 Thread Xi Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44809/#review123511
---


Ship it!




Ship It!

- Xi Wang


On March 14, 2016, 2:12 p.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44809/
> ---
> 
> (Updated March 14, 2016, 2:12 p.m.)
> 
> 
> Review request for Ambari and Xi Wang.
> 
> 
> Bugs: AMBARI-15411
> https://issues.apache.org/jira/browse/AMBARI-15411
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When user has no role, principle_name does not exist, so we have to fix url 
> building logic to user either user or group name.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js 
> d01646a 
> 
> Diff: https://reviews.apache.org/r/44809/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit test passed.
> 
> 
> Thanks,
> 
> Richard Zang
> 
>



Review Request 44809: RBAC: Name filter does not work for user with no role

2016-03-14 Thread Richard Zang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44809/
---

Review request for Ambari and Xi Wang.


Bugs: AMBARI-15411
https://issues.apache.org/jira/browse/AMBARI-15411


Repository: ambari


Description
---

When user has no role, principle_name does not exist, so we have to fix url 
building logic to user either user or group name.


Diffs
-

  ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js 
d01646a 

Diff: https://reviews.apache.org/r/44809/diff/


Testing
---

Manually tested on live cluster.
All unit test passed.


Thanks,

Richard Zang