Re: Review Request 44855: changing jdk version being used by HDP does not work

2016-03-15 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44855/#review123686
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On March 15, 2016, 6:09 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44855/
> ---
> 
> (Updated March 15, 2016, 6:09 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-15426
> https://issues.apache.org/jira/browse/AMBARI-15426
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> i followed the instructions here:  bari-2.2.1.0/bk_ambari_reference_guide/content/ch_changing_the_jdk_version_on_
> an_existing_cluster.html>
> 
> one issue was the above doc did not say i need to restart ambari server for
> the new java home to be picked up when i restart.
> 
> I went from JDK 7 and to JDK 8 and restarted oozie server and it failed with
> error like:
> 
> 
> 
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-ANY/scripts/hook.py",
>  line 35, in 
> BeforeAnyHook().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 219, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-ANY/scripts/hook.py",
>  line 32, in hook
> setup_java()
>   File 
> "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py",
>  line 209, in setup_java
> Execute(install_cmd,
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 
> 154, in __init__
> self.env.run()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 158, in run
> self.run_action(resource, action)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 121, in run_action
> provider_action()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
>  line 238, in action_run
> tries=self.resource.tries, try_sleep=self.resource.try_sleep)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 70, in inner
> result = function(command, **kwargs)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 92, in checked_call
> tries=tries, try_sleep=try_sleep)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 140, in _call_wrapper
> result = _call(command, **kwargs_copy)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 291, in _call
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'mkdir -p 
> /var/lib/ambari-agent/tmp/jdk && cd /var/lib/ambari-agent/tmp/jdk && tar -xf 
> /var/lib/ambari-agent/tmp/jdk-8u60-linux-x64.tar.gz && ambari-sudo.sh cp -rp 
> /var/lib/ambari-agent/tmp/jdk/* /usr/jdk64' returned 1. cp: cannot create 
> regular file `/usr/jdk64/jdk1.7.0_67/bin/java': Text file busy
> Error: Error: Unable to run the custom hook script ['/usr/bin/python2', 
> '/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-ANY/scripts/hook.py',
>  'ANY', '/var/lib/ambari-agent/data/command-4203.json', 
> '/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-ANY', 
> '/var/lib/ambari-agent/data/structured-out-4203.json', 'INFO', 
> '/var/lib/ambari-agent/tmp']Error: Error: Unable to run the custom hook 
> script ['/usr/bin/python2', 
> '/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py',
>  'START', '/var/lib/ambari-agent/data/command-4203.json', 
> '/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START', 
> '/var/lib/ambari-agent/data/structured-out-4203.json', 'INFO', 
> '/var/lib/ambari-agent/tmp']
> 
> 
> Issue is that
> 
> 
> 
> 
> [root@hcube1-1n03 ~]# ls /var/lib/ambari-agent/tmp/jdk
> jdk1.7.0_67  jdk1.8.0_60
> 
> 
> already has jdk 1.7 unpcaked.
> 
> We should change the cp command to only copy the specific directory
> 
> 
> 
> 
> ambari-sudo.sh cp -rp /var/lib/ambari-agent/tmp/jdk/* 
> 
> 
> We are also missing the JCE setup from the upgraded JDK.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/custom_actions/scripts/check_host.py 
> 09b2c05 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py
>  f5556fb 
>   ambari-server/src/test/python/custom_actions/TestCheckHost.py c82c

Review Request 44855: changing jdk version being used by HDP does not work

2016-03-15 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44855/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-15426
https://issues.apache.org/jira/browse/AMBARI-15426


Repository: ambari


Description
---

i followed the instructions here: 

one issue was the above doc did not say i need to restart ambari server for
the new java home to be picked up when i restart.

I went from JDK 7 and to JDK 8 and restarted oozie server and it failed with
error like:




Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-ANY/scripts/hook.py",
 line 35, in 
BeforeAnyHook().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 219, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-ANY/scripts/hook.py",
 line 32, in hook
setup_java()
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py",
 line 209, in setup_java
Execute(install_cmd,
  File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
line 154, in __init__
self.env.run()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 158, in run
self.run_action(resource, action)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 121, in run_action
provider_action()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
 line 238, in action_run
tries=self.resource.tries, try_sleep=self.resource.try_sleep)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 70, 
in inner
result = function(command, **kwargs)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 92, 
in checked_call
tries=tries, try_sleep=try_sleep)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 140, 
in _call_wrapper
result = _call(command, **kwargs_copy)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 291, 
in _call
raise Fail(err_msg)
resource_management.core.exceptions.Fail: Execution of 'mkdir -p 
/var/lib/ambari-agent/tmp/jdk && cd /var/lib/ambari-agent/tmp/jdk && tar -xf 
/var/lib/ambari-agent/tmp/jdk-8u60-linux-x64.tar.gz && ambari-sudo.sh cp -rp 
/var/lib/ambari-agent/tmp/jdk/* /usr/jdk64' returned 1. cp: cannot create 
regular file `/usr/jdk64/jdk1.7.0_67/bin/java': Text file busy
Error: Error: Unable to run the custom hook script ['/usr/bin/python2', 
'/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-ANY/scripts/hook.py',
 'ANY', '/var/lib/ambari-agent/data/command-4203.json', 
'/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-ANY', 
'/var/lib/ambari-agent/data/structured-out-4203.json', 'INFO', 
'/var/lib/ambari-agent/tmp']Error: Error: Unable to run the custom hook script 
['/usr/bin/python2', 
'/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py',
 'START', '/var/lib/ambari-agent/data/command-4203.json', 
'/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START', 
'/var/lib/ambari-agent/data/structured-out-4203.json', 'INFO', 
'/var/lib/ambari-agent/tmp']


Issue is that




[root@hcube1-1n03 ~]# ls /var/lib/ambari-agent/tmp/jdk
jdk1.7.0_67  jdk1.8.0_60


already has jdk 1.7 unpcaked.

We should change the cp command to only copy the specific directory




ambari-sudo.sh cp -rp /var/lib/ambari-agent/tmp/jdk/* 


We are also missing the JCE setup from the upgraded JDK.


Diffs
-

  ambari-server/src/main/resources/custom_actions/scripts/check_host.py 09b2c05 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py
 f5556fb 
  ambari-server/src/test/python/custom_actions/TestCheckHost.py c82c70d 
  
ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py 
a7eb9b1 

Diff: https://reviews.apache.org/r/44855/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk