Re: Review Request 45540: Alerts Using the SKIPPED State Cause Stale Alert Notification

2016-04-01 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45540/#review126564
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On March 31, 2016, 4:33 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45540/
> ---
> 
> (Updated March 31, 2016, 4:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-15637
> https://issues.apache.org/jira/browse/AMBARI-15637
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> SCRIPT alerts which use the {{SKIPPED}} state as a way of preventing 
> processing are causing instances of the Ambari Stale Alert to trigger. This 
> is because the agents do not return these alerts in the heartbeat causing 
> their timestamps not to update.
> 
> STR:
> - Create a SCRIPT alert which returns {{SKIPPED}} as it's state.
> - Wait for the stale alert to trigger.
> 
> {code}
> There are 1 stale alerts from 1 host(s): c6401.ambari.apache.org[NameNode 
> Service RPC Queue Latency (Hourly) (2h 18m), NameNode Service RPC Processing 
> Latency (Hourly) (2h 18m)]
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 92db07c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
>  f6aa1aa 
>   ambari-server/src/main/java/org/apache/ambari/server/state/AlertState.java 
> 8cc245a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
>  775fe83 
> 
> Diff: https://reviews.apache.org/r/45540/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 45540: Alerts Using the SKIPPED State Cause Stale Alert Notification

2016-03-31 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45540/#review126371
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 31, 2016, 1:33 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45540/
> ---
> 
> (Updated March 31, 2016, 1:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-15637
> https://issues.apache.org/jira/browse/AMBARI-15637
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> SCRIPT alerts which use the {{SKIPPED}} state as a way of preventing 
> processing are causing instances of the Ambari Stale Alert to trigger. This 
> is because the agents do not return these alerts in the heartbeat causing 
> their timestamps not to update.
> 
> STR:
> - Create a SCRIPT alert which returns {{SKIPPED}} as it's state.
> - Wait for the stale alert to trigger.
> 
> {code}
> There are 1 stale alerts from 1 host(s): c6401.ambari.apache.org[NameNode 
> Service RPC Queue Latency (Hourly) (2h 18m), NameNode Service RPC Processing 
> Latency (Hourly) (2h 18m)]
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 92db07c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
>  f6aa1aa 
>   ambari-server/src/main/java/org/apache/ambari/server/state/AlertState.java 
> 8cc245a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
>  775fe83 
> 
> Diff: https://reviews.apache.org/r/45540/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 45540: Alerts Using the SKIPPED State Cause Stale Alert Notification

2016-03-31 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45540/#review126304
---


Ship it!




Ship It!

- Nate Cole


On March 31, 2016, 9:33 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45540/
> ---
> 
> (Updated March 31, 2016, 9:33 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-15637
> https://issues.apache.org/jira/browse/AMBARI-15637
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> SCRIPT alerts which use the {{SKIPPED}} state as a way of preventing 
> processing are causing instances of the Ambari Stale Alert to trigger. This 
> is because the agents do not return these alerts in the heartbeat causing 
> their timestamps not to update.
> 
> STR:
> - Create a SCRIPT alert which returns {{SKIPPED}} as it's state.
> - Wait for the stale alert to trigger.
> 
> {code}
> There are 1 stale alerts from 1 host(s): c6401.ambari.apache.org[NameNode 
> Service RPC Queue Latency (Hourly) (2h 18m), NameNode Service RPC Processing 
> Latency (Hourly) (2h 18m)]
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 92db07c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
>  f6aa1aa 
>   ambari-server/src/main/java/org/apache/ambari/server/state/AlertState.java 
> 8cc245a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
>  775fe83 
> 
> Diff: https://reviews.apache.org/r/45540/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 45540: Alerts Using the SKIPPED State Cause Stale Alert Notification

2016-03-31 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45540/
---

Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate 
Cole.


Bugs: AMBARI-15637
https://issues.apache.org/jira/browse/AMBARI-15637


Repository: ambari


Description
---

SCRIPT alerts which use the {{SKIPPED}} state as a way of preventing processing 
are causing instances of the Ambari Stale Alert to trigger. This is because the 
agents do not return these alerts in the heartbeat causing their timestamps not 
to update.

STR:
- Create a SCRIPT alert which returns {{SKIPPED}} as it's state.
- Wait for the stale alert to trigger.

{code}
There are 1 stale alerts from 1 host(s): c6401.ambari.apache.org[NameNode 
Service RPC Queue Latency (Hourly) (2h 18m), NameNode Service RPC Processing 
Latency (Hourly) (2h 18m)]
{code}


Diffs
-

  ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 92db07c 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
 f6aa1aa 
  ambari-server/src/main/java/org/apache/ambari/server/state/AlertState.java 
8cc245a 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
 775fe83 

Diff: https://reviews.apache.org/r/45540/diff/


Testing
---

mvn clean test


Thanks,

Jonathan Hurley