Re: Review Request 45585: ambari-agent Build Reports SUCCESS Even When Tests Fail

2016-04-01 Thread Dmitro Lisnichenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45585/#review126582
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On April 1, 2016, 3:56 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45585/
> ---
> 
> (Updated April 1, 2016, 3:56 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15668
> https://issues.apache.org/jira/browse/AMBARI-15668
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Run a mvn clean test in the ambari-agent directory. You'll see that even if 
> tests fail, the build succeeds. This might also affect other branches aside 
> from trunk.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 56ba263 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 12e78c2 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py 477520e 
>   ambari-agent/src/test/python/ambari_agent/TestRecoveryManager.py ef81704 
> 
> Diff: https://reviews.apache.org/r/45585/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>



Review Request 45585: ambari-agent Build Reports SUCCESS Even When Tests Fail

2016-04-01 Thread Vitalyi Brodetskyi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45585/
---

Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sumit 
Mohanty.


Bugs: AMBARI-15668
https://issues.apache.org/jira/browse/AMBARI-15668


Repository: ambari


Description
---

Run a mvn clean test in the ambari-agent directory. You'll see that even if 
tests fail, the build succeeds. This might also affect other branches aside 
from trunk.


Diffs
-

  ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 56ba263 
  ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 12e78c2 
  ambari-agent/src/test/python/ambari_agent/TestMain.py 477520e 
  ambari-agent/src/test/python/ambari_agent/TestRecoveryManager.py ef81704 

Diff: https://reviews.apache.org/r/45585/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi