Re: Review Request 45865: Ambari Views : Reverting the changes for separation of logs in ambari branch-2.2

2016-04-07 Thread Gaurav Nagar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45865/#review127591
---


Ship it!




Ship It!

- Gaurav Nagar


On April 7, 2016, 11:20 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45865/
> ---
> 
> (Updated April 7, 2016, 11:20 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-15753
> https://issues.apache.org/jira/browse/AMBARI-15753
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> To revert changes of AMBARI-14084 from branch-2.2 following changes were done.
> Reverted the change in ViewRegistry.java
> deleted the view.log4j.properties files from views.
> deleted the changes in pom.xml for including the view.log4j.properties file
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> a75126e 
>   contrib/views/capacity-scheduler/pom.xml e523eb7 
>   contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
> 10b73a5 
>   contrib/views/files/pom.xml c60ba9e 
>   contrib/views/files/src/main/resources/view.log4j.properties 80f135e 
>   contrib/views/hive/pom.xml fd6fcfe 
>   contrib/views/hive/src/main/resources/view.log4j.properties 227d74b 
>   contrib/views/jobs/pom.xml 045920f 
>   contrib/views/jobs/src/main/resources/view.log4j.properties 03d193e 
>   contrib/views/pig/pom.xml c0beeb8 
>   contrib/views/pig/src/main/resources/view.log4j.properties 756fd3c 
>   contrib/views/slider/pom.xml 4188bb2 
>   contrib/views/slider/src/main/resources/view.log4j.properties aaed084 
>   contrib/views/storm/src/main/resources/view.log4j.properties 8d4f483 
>   contrib/views/tez/pom.xml 2daf7cc 
>   contrib/views/tez/src/main/resources/view.log4j.properties 8608da0 
> 
> Diff: https://reviews.apache.org/r/45865/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Re: Review Request 45865: Ambari Views : Reverting the changes for separation of logs in ambari branch-2.2

2016-04-07 Thread Rohit Choudhary

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45865/#review127588
---


Ship it!




Ship It!

- Rohit Choudhary


On April 7, 2016, 11:20 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45865/
> ---
> 
> (Updated April 7, 2016, 11:20 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-15753
> https://issues.apache.org/jira/browse/AMBARI-15753
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> To revert changes of AMBARI-14084 from branch-2.2 following changes were done.
> Reverted the change in ViewRegistry.java
> deleted the view.log4j.properties files from views.
> deleted the changes in pom.xml for including the view.log4j.properties file
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> a75126e 
>   contrib/views/capacity-scheduler/pom.xml e523eb7 
>   contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
> 10b73a5 
>   contrib/views/files/pom.xml c60ba9e 
>   contrib/views/files/src/main/resources/view.log4j.properties 80f135e 
>   contrib/views/hive/pom.xml fd6fcfe 
>   contrib/views/hive/src/main/resources/view.log4j.properties 227d74b 
>   contrib/views/jobs/pom.xml 045920f 
>   contrib/views/jobs/src/main/resources/view.log4j.properties 03d193e 
>   contrib/views/pig/pom.xml c0beeb8 
>   contrib/views/pig/src/main/resources/view.log4j.properties 756fd3c 
>   contrib/views/slider/pom.xml 4188bb2 
>   contrib/views/slider/src/main/resources/view.log4j.properties aaed084 
>   contrib/views/storm/src/main/resources/view.log4j.properties 8d4f483 
>   contrib/views/tez/pom.xml 2daf7cc 
>   contrib/views/tez/src/main/resources/view.log4j.properties 8608da0 
> 
> Diff: https://reviews.apache.org/r/45865/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Re: Review Request 45865: Ambari Views : Reverting the changes for separation of logs in ambari branch-2.2

2016-04-07 Thread Pallav Kulshreshtha

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45865/#review127587
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On April 7, 2016, 11:20 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45865/
> ---
> 
> (Updated April 7, 2016, 11:20 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-15753
> https://issues.apache.org/jira/browse/AMBARI-15753
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> To revert changes of AMBARI-14084 from branch-2.2 following changes were done.
> Reverted the change in ViewRegistry.java
> deleted the view.log4j.properties files from views.
> deleted the changes in pom.xml for including the view.log4j.properties file
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> a75126e 
>   contrib/views/capacity-scheduler/pom.xml e523eb7 
>   contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
> 10b73a5 
>   contrib/views/files/pom.xml c60ba9e 
>   contrib/views/files/src/main/resources/view.log4j.properties 80f135e 
>   contrib/views/hive/pom.xml fd6fcfe 
>   contrib/views/hive/src/main/resources/view.log4j.properties 227d74b 
>   contrib/views/jobs/pom.xml 045920f 
>   contrib/views/jobs/src/main/resources/view.log4j.properties 03d193e 
>   contrib/views/pig/pom.xml c0beeb8 
>   contrib/views/pig/src/main/resources/view.log4j.properties 756fd3c 
>   contrib/views/slider/pom.xml 4188bb2 
>   contrib/views/slider/src/main/resources/view.log4j.properties aaed084 
>   contrib/views/storm/src/main/resources/view.log4j.properties 8d4f483 
>   contrib/views/tez/pom.xml 2daf7cc 
>   contrib/views/tez/src/main/resources/view.log4j.properties 8608da0 
> 
> Diff: https://reviews.apache.org/r/45865/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Review Request 45865: Ambari Views : Reverting the changes for separation of logs in ambari branch-2.2

2016-04-07 Thread Nitiraj Rathore

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45865/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
and Rohit Choudhary.


Bugs: AMBARI-15753
https://issues.apache.org/jira/browse/AMBARI-15753


Repository: ambari


Description
---

To revert changes of AMBARI-14084 from branch-2.2 following changes were done.
Reverted the change in ViewRegistry.java
deleted the view.log4j.properties files from views.
deleted the changes in pom.xml for including the view.log4j.properties file


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
a75126e 
  contrib/views/capacity-scheduler/pom.xml e523eb7 
  contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
10b73a5 
  contrib/views/files/pom.xml c60ba9e 
  contrib/views/files/src/main/resources/view.log4j.properties 80f135e 
  contrib/views/hive/pom.xml fd6fcfe 
  contrib/views/hive/src/main/resources/view.log4j.properties 227d74b 
  contrib/views/jobs/pom.xml 045920f 
  contrib/views/jobs/src/main/resources/view.log4j.properties 03d193e 
  contrib/views/pig/pom.xml c0beeb8 
  contrib/views/pig/src/main/resources/view.log4j.properties 756fd3c 
  contrib/views/slider/pom.xml 4188bb2 
  contrib/views/slider/src/main/resources/view.log4j.properties aaed084 
  contrib/views/storm/src/main/resources/view.log4j.properties 8d4f483 
  contrib/views/tez/pom.xml 2daf7cc 
  contrib/views/tez/src/main/resources/view.log4j.properties 8608da0 

Diff: https://reviews.apache.org/r/45865/diff/


Testing
---

manual testing done.


Thanks,

Nitiraj Rathore