Re: Review Request 45866: File browser view should have some checks before starting similar to pig view

2016-04-07 Thread Nitiraj Rathore

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45866/#review127594
---


Ship it!




Ship It!

- Nitiraj Rathore


On April 7, 2016, 11:58 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45866/
> ---
> 
> (Updated April 7, 2016, 11:58 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-15756
> https://issues.apache.org/jira/browse/AMBARI-15756
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Added REST end points for hdfsStatus
> - Consuming these REST end points in front end code to check services status 
> on intermediate page.
> - If everything passes then only we are taking to the landing page
> 
> 
> Diffs
> -
> 
>   
> contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java
>  acaebfa 
>   
> contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java
>  4fe1d20 
>   contrib/views/files/src/main/resources/ui/app/controllers/splash.js 
> PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/router.js 801e932 
>   contrib/views/files/src/main/resources/ui/app/routes/index.js 1032334 
>   contrib/views/files/src/main/resources/ui/app/routes/splash.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/splash.hbs 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45866/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Re: Review Request 45866: File browser view should have some checks before starting similar to pig view

2016-04-07 Thread Gaurav Nagar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45866/#review127592
---


Ship it!




Ship It!

- Gaurav Nagar


On April 7, 2016, 11:58 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45866/
> ---
> 
> (Updated April 7, 2016, 11:58 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-15756
> https://issues.apache.org/jira/browse/AMBARI-15756
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Added REST end points for hdfsStatus
> - Consuming these REST end points in front end code to check services status 
> on intermediate page.
> - If everything passes then only we are taking to the landing page
> 
> 
> Diffs
> -
> 
>   
> contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java
>  acaebfa 
>   
> contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java
>  4fe1d20 
>   contrib/views/files/src/main/resources/ui/app/controllers/splash.js 
> PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/router.js 801e932 
>   contrib/views/files/src/main/resources/ui/app/routes/index.js 1032334 
>   contrib/views/files/src/main/resources/ui/app/routes/splash.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/splash.hbs 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45866/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Re: Review Request 45866: File browser view should have some checks before starting similar to pig view

2016-04-07 Thread Rohit Choudhary

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45866/#review127590
---


Ship it!




Ship It!

- Rohit Choudhary


On April 7, 2016, 11:58 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45866/
> ---
> 
> (Updated April 7, 2016, 11:58 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-15756
> https://issues.apache.org/jira/browse/AMBARI-15756
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Added REST end points for hdfsStatus
> - Consuming these REST end points in front end code to check services status 
> on intermediate page.
> - If everything passes then only we are taking to the landing page
> 
> 
> Diffs
> -
> 
>   
> contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java
>  acaebfa 
>   
> contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java
>  4fe1d20 
>   contrib/views/files/src/main/resources/ui/app/controllers/splash.js 
> PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/router.js 801e932 
>   contrib/views/files/src/main/resources/ui/app/routes/index.js 1032334 
>   contrib/views/files/src/main/resources/ui/app/routes/splash.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/splash.hbs 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45866/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Review Request 45866: File browser view should have some checks before starting similar to pig view

2016-04-07 Thread Pallav Kulshreshtha

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45866/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-15756
https://issues.apache.org/jira/browse/AMBARI-15756


Repository: ambari


Description
---

- Added REST end points for hdfsStatus
- Consuming these REST end points in front end code to check services status on 
intermediate page.
- If everything passes then only we are taking to the landing page


Diffs
-

  
contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java
 acaebfa 
  
contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java
 4fe1d20 
  contrib/views/files/src/main/resources/ui/app/controllers/splash.js 
PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/router.js 801e932 
  contrib/views/files/src/main/resources/ui/app/routes/index.js 1032334 
  contrib/views/files/src/main/resources/ui/app/routes/splash.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/templates/splash.hbs 
PRE-CREATION 

Diff: https://reviews.apache.org/r/45866/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha