Re: Review Request 45903: AMBARI-15775 Integrate Red Hat Satellite option in Ambari Admin

2016-04-08 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45903/#review127818
---


Ship it!




Ship It!

- Nate Cole


On April 7, 2016, 8:36 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45903/
> ---
> 
> (Updated April 7, 2016, 8:36 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Nate Cole, Oleg 
> Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15775
> https://issues.apache.org/jira/browse/AMBARI-15775
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Provide RedHat satellite option. It can be used wherever we show redhat6 
> urls, and applicable to redhat6/redhat7. For example, registering repos, etc.
> The API call to update links when using VDF can specify the new property. In 
> order to make it more generic (and default true), it is called 
> "ambari_managed_repositories". API looks like:
> PUT /api/v1/stacks/HDP/versions/2.3/repository_versions/2
> {
>   "RepositoryVersions" : {
> "id" : 2
>   },
>   "operating_systems" : [
> {
>   "OperatingSystems" : {
> "ambari_managed_repositories": false,
> "os_type" : "redhat6",
> "repository_version_id" : 2,
> "stack_name" : "HDP",
> "stack_version" : "2.3"
>   },
>   "repositories" : [
> {
>   "Repositories" : {
> "base_url" : "http://repos.ambari.apache.org/hdp/HDP-2.3.4.14-4";,
> "repo_id" : "HDP-2.3",
> "repo_name" : "HDP"
>   }
> },
> {
>   "Repositories" : {
> "base_url" : 
> "http://repos.ambari.apache.org/hdp/HDP-UTILS-1.1.0.20";,
> "repo_id" : "HDP-UTILS-1.1.0.20",
> "repo_name" : "HDP-UTILS"
>   }
> }
>   ]
> }
>   ]
> }
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
>  6feeeac 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js
>  c209fcc 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
> 4ba0fc1 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
>  39fabf6 
> 
> Diff: https://reviews.apache.org/r/45903/diff/
> 
> 
> Testing
> ---
> 
> ambari-admin:
> Executed 64 of 64 SUCCESS (0.048 secs / 0.299 secs)
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 45903: AMBARI-15775 Integrate Red Hat Satellite option in Ambari Admin

2016-04-07 Thread Yusaku Sako 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45903/#review127709
---


Ship it!




Ship It!

- Yusaku Sako


On April 8, 2016, 12:36 a.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45903/
> ---
> 
> (Updated April 8, 2016, 12:36 a.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Nate Cole, Oleg 
> Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15775
> https://issues.apache.org/jira/browse/AMBARI-15775
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Provide RedHat satellite option. It can be used wherever we show redhat6 
> urls, and applicable to redhat6/redhat7. For example, registering repos, etc.
> The API call to update links when using VDF can specify the new property. In 
> order to make it more generic (and default true), it is called 
> "ambari_managed_repositories". API looks like:
> PUT /api/v1/stacks/HDP/versions/2.3/repository_versions/2
> {
>   "RepositoryVersions" : {
> "id" : 2
>   },
>   "operating_systems" : [
> {
>   "OperatingSystems" : {
> "ambari_managed_repositories": false,
> "os_type" : "redhat6",
> "repository_version_id" : 2,
> "stack_name" : "HDP",
> "stack_version" : "2.3"
>   },
>   "repositories" : [
> {
>   "Repositories" : {
> "base_url" : "http://repos.ambari.apache.org/hdp/HDP-2.3.4.14-4";,
> "repo_id" : "HDP-2.3",
> "repo_name" : "HDP"
>   }
> },
> {
>   "Repositories" : {
> "base_url" : 
> "http://repos.ambari.apache.org/hdp/HDP-UTILS-1.1.0.20";,
> "repo_id" : "HDP-UTILS-1.1.0.20",
> "repo_name" : "HDP-UTILS"
>   }
> }
>   ]
> }
>   ]
> }
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
>  6feeeac 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js
>  c209fcc 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
> 4ba0fc1 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
>  39fabf6 
> 
> Diff: https://reviews.apache.org/r/45903/diff/
> 
> 
> Testing
> ---
> 
> ambari-admin:
> Executed 64 of 64 SUCCESS (0.048 secs / 0.299 secs)
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 45903: AMBARI-15775 Integrate Red Hat Satellite option in Ambari Admin

2016-04-07 Thread Zhe (Joe) Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45903/
---

(Updated April 8, 2016, 12:36 a.m.)


Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Nate Cole, Oleg 
Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-15775
https://issues.apache.org/jira/browse/AMBARI-15775


Repository: ambari


Description
---

Provide RedHat satellite option. It can be used wherever we show redhat6 urls, 
and applicable to redhat6/redhat7. For example, registering repos, etc.
The API call to update links when using VDF can specify the new property. In 
order to make it more generic (and default true), it is called 
"ambari_managed_repositories". API looks like:
PUT /api/v1/stacks/HDP/versions/2.3/repository_versions/2
{
  "RepositoryVersions" : {
"id" : 2
  },
  "operating_systems" : [
{
  "OperatingSystems" : {
"ambari_managed_repositories": false,
"os_type" : "redhat6",
"repository_version_id" : 2,
"stack_name" : "HDP",
"stack_version" : "2.3"
  },
  "repositories" : [
{
  "Repositories" : {
"base_url" : "http://repos.ambari.apache.org/hdp/HDP-2.3.4.14-4";,
"repo_id" : "HDP-2.3",
"repo_name" : "HDP"
  }
},
{
  "Repositories" : {
"base_url" : 
"http://repos.ambari.apache.org/hdp/HDP-UTILS-1.1.0.20";,
"repo_id" : "HDP-UTILS-1.1.0.20",
"repo_name" : "HDP-UTILS"
  }
}
  ]
}
  ]
}


Diffs (updated)
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
 6feeeac 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js
 c209fcc 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
4ba0fc1 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
 39fabf6 

Diff: https://reviews.apache.org/r/45903/diff/


Testing
---

ambari-admin:
Executed 64 of 64 SUCCESS (0.048 secs / 0.299 secs)
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 45903: AMBARI-15775 Integrate Red Hat Satellite option in Ambari Admin

2016-04-07 Thread Yusaku Sako 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45903/#review127707
---




ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js
 (line 138)


Should this be negated?


- Yusaku Sako


On April 8, 2016, 12:19 a.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45903/
> ---
> 
> (Updated April 8, 2016, 12:19 a.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Nate Cole, Oleg 
> Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15775
> https://issues.apache.org/jira/browse/AMBARI-15775
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Provide RedHat satellite option. It can be used wherever we show redhat6 
> urls, and applicable to redhat6/redhat7. For example, registering repos, etc.
> The API call to update links when using VDF can specify the new property. In 
> order to make it more generic (and default true), it is called 
> "ambari_managed_repositories". API looks like:
> PUT /api/v1/stacks/HDP/versions/2.3/repository_versions/2
> {
>   "RepositoryVersions" : {
> "id" : 2
>   },
>   "operating_systems" : [
> {
>   "OperatingSystems" : {
> "ambari_managed_repositories": false,
> "os_type" : "redhat6",
> "repository_version_id" : 2,
> "stack_name" : "HDP",
> "stack_version" : "2.3"
>   },
>   "repositories" : [
> {
>   "Repositories" : {
> "base_url" : "http://repos.ambari.apache.org/hdp/HDP-2.3.4.14-4";,
> "repo_id" : "HDP-2.3",
> "repo_name" : "HDP"
>   }
> },
> {
>   "Repositories" : {
> "base_url" : 
> "http://repos.ambari.apache.org/hdp/HDP-UTILS-1.1.0.20";,
> "repo_id" : "HDP-UTILS-1.1.0.20",
> "repo_name" : "HDP-UTILS"
>   }
> }
>   ]
> }
>   ]
> }
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
>  6feeeac 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js
>  c209fcc 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
> 4ba0fc1 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
>  39fabf6 
> 
> Diff: https://reviews.apache.org/r/45903/diff/
> 
> 
> Testing
> ---
> 
> ambari-admin:
> Executed 64 of 64 SUCCESS (0.048 secs / 0.299 secs)
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 45903: AMBARI-15775 Integrate Red Hat Satellite option in Ambari Admin

2016-04-07 Thread Zhe (Joe) Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45903/
---

(Updated April 8, 2016, 12:19 a.m.)


Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Nate Cole, Oleg 
Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-15775
https://issues.apache.org/jira/browse/AMBARI-15775


Repository: ambari


Description
---

Provide RedHat satellite option. It can be used wherever we show redhat6 urls, 
and applicable to redhat6/redhat7. For example, registering repos, etc.
The API call to update links when using VDF can specify the new property. In 
order to make it more generic (and default true), it is called 
"ambari_managed_repositories". API looks like:
PUT /api/v1/stacks/HDP/versions/2.3/repository_versions/2
{
  "RepositoryVersions" : {
"id" : 2
  },
  "operating_systems" : [
{
  "OperatingSystems" : {
"ambari_managed_repositories": false,
"os_type" : "redhat6",
"repository_version_id" : 2,
"stack_name" : "HDP",
"stack_version" : "2.3"
  },
  "repositories" : [
{
  "Repositories" : {
"base_url" : "http://repos.ambari.apache.org/hdp/HDP-2.3.4.14-4";,
"repo_id" : "HDP-2.3",
"repo_name" : "HDP"
  }
},
{
  "Repositories" : {
"base_url" : 
"http://repos.ambari.apache.org/hdp/HDP-UTILS-1.1.0.20";,
"repo_id" : "HDP-UTILS-1.1.0.20",
"repo_name" : "HDP-UTILS"
  }
}
  ]
}
  ]
}


Diffs (updated)
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
 6feeeac 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js
 c209fcc 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
4ba0fc1 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
 39fabf6 

Diff: https://reviews.apache.org/r/45903/diff/


Testing
---

ambari-admin:
Executed 64 of 64 SUCCESS (0.048 secs / 0.299 secs)
Manual testing done.


Thanks,

Zhe (Joe) Wang

Review Request 45903: AMBARI-15775 Integrate Red Hat Satellite option in Ambari Admin

2016-04-07 Thread Zhe (Joe) Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45903/
---

Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Nate Cole, Oleg 
Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-15775
https://issues.apache.org/jira/browse/AMBARI-15775


Repository: ambari


Description
---

Provide RedHat satellite option. It can be used wherever we show redhat6 urls, 
and applicable to redhat6/redhat7. For example, registering repos, etc.
The API call to update links when using VDF can specify the new property. In 
order to make it more generic (and default true), it is called 
"ambari_managed_repositories". API looks like:
PUT /api/v1/stacks/HDP/versions/2.3/repository_versions/2
{
  "RepositoryVersions" : {
"id" : 2
  },
  "operating_systems" : [
{
  "OperatingSystems" : {
"ambari_managed_repositories": false,
"os_type" : "redhat6",
"repository_version_id" : 2,
"stack_name" : "HDP",
"stack_version" : "2.3"
  },
  "repositories" : [
{
  "Repositories" : {
"base_url" : "http://repos.ambari.apache.org/hdp/HDP-2.3.4.14-4";,
"repo_id" : "HDP-2.3",
"repo_name" : "HDP"
  }
},
{
  "Repositories" : {
"base_url" : 
"http://repos.ambari.apache.org/hdp/HDP-UTILS-1.1.0.20";,
"repo_id" : "HDP-UTILS-1.1.0.20",
"repo_name" : "HDP-UTILS"
  }
}
  ]
}
  ]
}


Diffs
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
 6feeeac 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js
 c209fcc 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
4ba0fc1 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
 39fabf6 

Diff: https://reviews.apache.org/r/45903/diff/


Testing
---

ambari-admin:
Executed 64 of 64 SUCCESS (0.048 secs / 0.299 secs)
Manual testing done.


Thanks,

Zhe (Joe) Wang